Repository navigation
Revert "Reduce typing latency in large busy workspaces" (#7863) - #8138
Merged
Merged
Conversation
This reverts commit dcf320a.
Contributor
|
Too many files changed for review. ( Bypass the limit by tagging |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedToo many files! This PR contains 193 files, which is 43 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (193)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # cmux.xcodeproj/project.pbxproj
This was referenced Jul 15, 2026
|
Was there a specific regression behind reverting #7863? The revert PR documents what it keeps but not what failed. We're planning similar FSEvents event-ID/flag forwarding and would like to avoid repeating whatever sank it. |
4 of 6 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #7863 (squash commit dcf320a).
Three deliberate deviations from a mechanical revert, all because later merges built on top of 7863:
ghosttysubmodule pointer andscripts/ghosttykit-checksums.txtstay at current main. Fix Ghostty SSH wrapper path in embedded app bundles #8109 bumped the fork past 7863's bump, and rolling the submodule back would lose the embedded SSH wrapper fix.AtomicBooleanGate(plus itsCmuxFoundationAtomicsCtarget and tests) is kept. Run cmux iOS over authenticated Iroh transport #7908 Iroh byte-tee lane gate (laneDemand) depends on it.MobileTerminalByteTee.appendreturns to the pre-7863 per-topic subscriber checks, with 7908'slaneDemand.loadAcquire()gate preserved as an additional condition.Everything else is a straight revert: hidden-renderer suspension, background workspace mount bounding, shared process snapshots, Git snapshot single-flighting, invalidation batching, the Release perf counters, and 7863's tests.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Summary by cubic
Reverts the typing-latency work from #7863 to restore the prior terminal, Git, sidebar, and control-socket behavior. Keeps downstream fixes (e.g.,
ghosttystaying at current main) and preserves theAtomicBooleanGateand the mobilelaneDemand.loadAcquire()gating.New Features
Refactors
performance.metrics.*APIs and DEBUG-only process metrics; make socket client authorization stateless (drop cached ancestry admission).LatestWinsBatcherutility.AtomicBooleanGateand the mobile byte-teelaneDemand.loadAcquire()check.Written for commit e6dcb57. Summary will update on new commits.