Repository navigation
Fix Iroh relay policy Vercel deployment - #8118
Merged
Merged
Conversation
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThe relay catalog generator moved from ChangesRelay catalog generation
Swift test adjustments
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 25✅ Passed checks (25 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Greptile SummaryThis PR fixes Vercel deployments broken by the Iroh merge by moving the relay catalog generator from
Confidence Score: 5/5Safe to merge — the change is a targeted relocation of a build-time generator with all call sites and path computations verified correct. All changed code is build/tooling infrastructure with no production runtime logic. The repositoryRoot depth ("../.." ) is correct for the new web/tools/ location, every caller (root, web, presence, CI) has been updated consistently, and the new regression test hard-pins the invariant that the generator must live inside the Vercel project. The Swift changes are test-file-only fixes with no production impact. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["config/iroh/managed-relay-catalog.json"] -->|read by| B["web/tools/generate-managed-iroh-relay-catalog.ts"]
B -->|--check or generate| C["web/services/relay/generated/managedRelayCatalog.ts"]
B -->|--check or generate| D["workers/presence/src/generated/managedRelayCatalog.ts"]
E["web/package.json\nbuild / vercel-build"] -->|bun tools/...| B
F["package.json\niroh:relay-catalog:check"] -->|bun web/tools/...| B
G["workers/presence/package.json\nrelay-catalog:check"] -->|bun ../../web/tools/...| B
H[".github/workflows/ci.yml\nValidate managed relay catalog"] -->|bun tools/...| B
style B fill:#c8e6c9,stroke:#388e3c
style A fill:#fff9c4,stroke:#f9a825
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A["config/iroh/managed-relay-catalog.json"] -->|read by| B["web/tools/generate-managed-iroh-relay-catalog.ts"]
B -->|--check or generate| C["web/services/relay/generated/managedRelayCatalog.ts"]
B -->|--check or generate| D["workers/presence/src/generated/managedRelayCatalog.ts"]
E["web/package.json\nbuild / vercel-build"] -->|bun tools/...| B
F["package.json\niroh:relay-catalog:check"] -->|bun web/tools/...| B
G["workers/presence/package.json\nrelay-catalog:check"] -->|bun ../../web/tools/...| B
H[".github/workflows/ci.yml\nValidate managed relay catalog"] -->|bun tools/...| B
style B fill:#c8e6c9,stroke:#388e3c
style A fill:#fff9c4,stroke:#f9a825
Reviews (5): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/package.json`:
- Around line 8-9: Update the web-typecheck command in the CI workflow to invoke
generate-managed-iroh-relay-catalog.ts through the web working directory using
the tools/generate-managed-iroh-relay-catalog.ts path, matching the package
scripts and preserving the --check flag.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0d566e38-9a65-4cc3-a53e-aaee2d98e9b8
⛔ Files ignored due to path filters (3)
.github/swift-file-length-budget.tsvis excluded by!**/*.tsvweb/services/relay/generated/managedRelayCatalog.tsis excluded by!**/generated/**workers/presence/src/generated/managedRelayCatalog.tsis excluded by!**/generated/**
📒 Files selected for processing (5)
package.jsonweb/package.jsonweb/tests/vercel-build-inputs.test.tsweb/tools/generate-managed-iroh-relay-catalog.tsworkers/presence/package.json
…loy-fix # Conflicts: # .github/swift-file-length-budget.tsv
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
bun test tests/vercel-build-inputs.test.ts tests/relay-policy.test.ts tests/relay-token-route.test.ts tests/relay-preferences-route.test.tsSKIP_ENV_VALIDATION=1 bun run vercel-buildpython3 scripts/swift_file_length_budget.py --base-ref origin/mainNeed help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Summary by cubic
Fixes Vercel deploys for the Iroh relay policy by validating the relay catalog inside the
webapp and making the generator Node-compatible so Bun/Next.js type checks and builds pass. Also updates CI/Presence workflows and adds a regression test to keep validation inside the Vercel project.web/tools/generate-managed-iroh-relay-catalog.ts; run--checkfromwebin root,web, andworkers/presencescripts and CI.process.argv, fixed repo root resolution, preserved--check).web/tests/vercel-build-inputs.test.tsto ensurevercel-buildcalls the in-web script.MobileHostAuthorizationTests.swift.Written for commit d3f0da8. Summary will update on new commits.
Summary by CodeRabbit