Repository navigation
Fix Ghostty SSH wrapper path in embedded app bundles - #8102
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 8 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR adds regression coverage for Ghostty SSH wrappers in embedded app bundles. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "test: reproduce embedded Ghostty SSH bin..." | Re-trigger Greptile |
Summary
<GUI executable dir>/ghosttyRoot cause
Ghostty derived
GHOSTTY_BIN_DIRfromselfExePath()and every SSH shell wrapper appended/ghostty. In a GhosttyKit host,selfExePath()is cmux, so the wrapper constructed/Applications/cmux.app/Contents/MacOS/ghostty. cmux actually ships the Ghostty CLI helper atContents/Resources/bin/ghostty.The fix introduces one full executable-path contract,
GHOSTTY_BIN. Native Ghostty resolves it to its own executable; cmux sets it to its bundled helper.GHOSTTY_BIN_DIRremains only the directory used by the independent PATH feature. Embedded hosts without a helper do not install a broken SSH wrapper.Affected users
Ghostty defaults
ssh-envandssh-terminfoto off, so ordinary sessions without either feature do not define the wrapper and will not reproduce the bug. It affects sessions where either feature is enabled by Ghostty config or cmux remote/bootstrap behavior. A separately installed Ghostty does not determine the outcome because the old wrapper directly executed the derived bundle path instead of searchingPATH.Regression proof
Commit
d08653b7d4contains the failing test only. Against the old submodule it invokes the actual zsh integration and fails with exit 127 andssh:4: no such file or directory: .../cmux.app/Contents/MacOS/ghostty, matching #8093. Against the fixed head the same zsh and bash behavior checks invoke the host-provided helper as+ssh -- user@example.comand pass.Verification
python3 tests/test_issue_8093_ghostty_ssh_binary_path.pyb4b6d69c8, archive validator passed, GitHub asset digest pinned as89a2d738fc566c9c91e2c0ed7c2c9fa9f6ac18d9f0541fd9ff58e41bb8b8caa9./tests/test_ci_ghosttykit_checksum_present.sh./tests/test_ci_ghosttykit_checksum_verification.shpython3 scripts/check-package-resolved-policy.pypython3 scripts/check-workspace-package-groups.py --checkCloses #8093