Repository navigation
Add keyboard copy mode for terminal scrollback #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,092
−1
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e14914f
Add keyboard copy mode for terminal scrollback
lawrencecchen 77f4a06
Show vim copy mode indicator in terminal
lawrencecchen ebb8d73
Fix vi copy-mode symbol keys and pending yank handling
lawrencecchen 2aa0ed7
Refine copy-mode badge wording and font
lawrencecchen 861f9d4
Rename keyboard copy-mode badge to VI MODE
lawrencecchen b363a66
Address PR feedback for copy-mode routing and keyup handling
lawrencecchen d1186d5
Refresh copy-mode viewport row after scrolling
lawrencecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This handler always returns
trueonce the shortcut matches, even whentoggleFocusedTerminalCopyMode()fails (for example, when a browser panel or another non-terminal responder is focused), so the local shortcut monitor swallowsCmd+Shift+Mand the focused control never receives it. In practice this breaks browser/web-app shortcuts in those contexts and only plays a beep; returningfalsewhen no terminal panel is actionable would preserve expected responder behavior.Useful? React with 👍 / 👎.