-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Harden E2E recording and dual-Xcode CI routing #7835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
27abda1
Arm E2E recording after app activation
lawrencecchen 6bb14ce
Route dual-Xcode CI to Blacksmith
lawrencecchen c6448e7
Isolate terminal resync test surface
lawrencecchen 0c5f4ec
Apply dual-Xcode routing to package tests
lawrencecchen 38a71ba
Serialize terminal resync replay ownership
lawrencecchen 1816ca3
Keep E2E frame recorder alive after capture errors
lawrencecchen b75f025
Scope replay deferral to input recovery
lawrencecchen 09953f9
Keep resync policy out of shell store
lawrencecchen ce76d4a
Report recorder startup death
lawrencecchen 1ece89e
Make replay ownership regression deterministic
lawrencecchen 1d2af9a
Preserve hybrid input catch-up semantics
lawrencecchen 8a39135
Merge remote-tracking branch 'origin/main' into fix-e2e-recording-act…
lawrencecchen 777f573
Install Node for CLI wrapper CI regressions
lawrencecchen 5816b13
Address CI canary review findings
lawrencecchen b1904ab
Split legacy replay compatibility test
lawrencecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
...muxMobileShell/Tests/CmuxMobileShellTests/MobileShellLegacyReplayCompatibilityTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import Foundation | ||
| import Testing | ||
| @testable import CmuxMobileShell | ||
|
|
||
| @MainActor | ||
| @Test func legacyHostResyncDoesNotBlockLiveOutputBehindReplayBarrier() async throws { | ||
| let clock = TestClock() | ||
| let router = LivenessHostRouter() | ||
| await router.setCapabilities(["events.v1", "terminal.render_grid.v1"]) | ||
| let box = TransportBox() | ||
| let store = try await makeConnectedStore(router: router, box: box, clock: clock) | ||
|
|
||
| let collector = OutputCollector() | ||
| collector.mount(store: store, surfaceID: "live-terminal") | ||
| let coldReplayRequested = try await pollUntil { | ||
| await router.count(of: "mobile.terminal.replay") >= 1 | ||
| } | ||
| #expect(coldReplayRequested) | ||
| try await waitForReplayResponsesServed( | ||
| 1, | ||
| router: router, | ||
| "the legacy cold replay must settle before testing resync" | ||
| ) | ||
|
|
||
| let transport = try #require(box.get()) | ||
| let liveFrame = try renderGridEventFrame( | ||
| surfaceID: "live-terminal", | ||
| seq: 100, | ||
| text: "legacy-live" | ||
| ) | ||
| let replayCount = await router.count(of: "mobile.terminal.replay") | ||
| await router.holdNextReplayResponses() | ||
| store.requestTerminalResync(surfaceID: "live-terminal", deferBehindActiveReplay: true) | ||
| let resyncRequested = try await pollUntil { | ||
| await router.count(of: "mobile.terminal.replay") > replayCount | ||
| } | ||
| #expect(resyncRequested) | ||
|
|
||
| await transport.deliver(liveFrame) | ||
| let liveOutputDelivered = try await pollUntil { | ||
| collector.lines.contains { $0.contains("legacy-live") } | ||
| } | ||
| #expect( | ||
| liveOutputDelivered, | ||
| "a host without terminal.replay.v1 must keep delivering live output while its unbarriered resync is pending" | ||
| ) | ||
|
|
||
| await router.releaseAllHeld() | ||
| collector.unmount() | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.