Repository navigation
Fix account.me test after Stack billing removal - #7807
lawrencecchen wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesLegacy Stack Pro eligibility
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 25✅ Passed checks (25 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR updates the
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "Fix account.me billing test after Stack ..." | Re-trigger Greptile |
|
Superseded by #7808, which landed the same account.me test repair on main. |
Summary
PRO_PRODUCT_IDtest import deleted by the Stack billing removalaccount.meprocedure ignores a legacy Stack Pro product and returns the Stripe-only Free stateTesting
cd web && bun test tests/account-me-orpc.test.tscd web && bun run typecheckContext
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Note
Low Risk
Test-only changes with no production code touched.
Overview
Updates
account-me-orpc.test.tsso it matches Stripe-only Pro resolution after Stack billing was removed.The test that used to assert Stack Pro users get
planId: "pro"now asserts a user with only a legacy Stackproproduct getsfree,isPro: false, andbillingManagement: "none". ThePRO_PRODUCT_IDimport is dropped; the fake user helper useslegacyStackProand a hardcoded product id instead ofpro: true.Reviewed by Cursor Bugbot for commit 4203094. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Update the
account.metest to remove the stalePRO_PRODUCT_IDfrom Stack billing and verify that a legacy Stack “Pro” product no longer grants Pro status. The test now expects the Stripe-only Free state (planId: "free",isPro: false,billingManagement: "none").Written for commit 4203094. Summary will update on new commits.
Summary by CodeRabbit