Route the checklist's first item through the popover in popover style

[azooz2003-bit]

Stacks on #7790

This PR is stacked on #7790 (restore-workspace-todos-default-none) and should be reviewed/merged after it. Do not merge this PR on its own.

Summary

SidebarWorkspaceChecklistView.swift's presentsPopover was usesPopoverPresentation && totalCount > 0, so a workspace with zero checklist items always fell into inline text-field entry regardless of sidebar.beta.workspaceTodos.checklistStyle (default .popover). A workspace's very first checklist item never got the popover treatment.

• presentsPopover now equals usesPopoverPresentation directly (no totalCount gate).
• Moved the ChecklistSummaryPopoverModifier (the NSPopover anchor) from summaryLine to the section's outer container, so the same backing NSView/Coordinator anchors the popover across the 0->1 item transition instead of re-anchoring to a freshly created view (which would close and immediately reopen the popover).
• The ghost "Add item" row's button now routes through the same popover-toggle path as the summary line when presentsPopover is true.
• Fixed a second bug in ContentView.swift's .onReceive handler for .workspaceChecklistAddItemRequested: it special-cased !workspace.todoState.checklist.isEmpty before routing to the popover, so the "Add Checklist Item..." context-menu/palette action still fell back to inline for a workspace's first item even after the view-level fix. Removed that gate; popover style now always routes the add request into the popover.
• .inline style is untouched: presentsPopover is false there regardless of item count, same as before.

No changes to WorkspaceTodoChecklistStyle, its default, the settings UI, or WorkspaceTodoState.statusHidden/default-status logic (all handled by #7790).

Test plan

No new pure-logic seam was created worth a unit test: presentsPopover reduces to exactly usesPopoverPresentation, an identity, and the rest of the fix is SwiftUI view-wiring (anchor attachment point, button action branch, notification-handler condition) that isn't expressible as a standalone testable function. Verified manually instead, tag chkpop:

• Fresh workspace, zero items, .popover style (default): triggering "Add Checklist Item..." (context-menu/palette path, exercised via the debug.workspace_todo.checklist_add_field debug RPC, which shares the same WorkspaceTodoActions.requestChecklistAddField path as the context menu and the ghost row's own tap) opens the anchored NSPopover immediately, with the header showing the workspace title and 0/0, and the add field focused — no intermediate inline TextField state at any point. Screenshot evidence captured.
• Typed into the popover's add field and committed: item appears (1. [ ] Buy milk, 0/1 completed), popover stays anchored (no visible close/reopen), summary line updates to 0/1 · Buy milk.
• Reopened the popover on the now-non-empty checklist (regression check) and added a second item (2. [ ] Walk the dog, 0/2 completed) — pre-existing popover-for-non-empty-checklist behavior unaffected.
• Fresh second workspace with sidebarWorkspaceTodosChecklistStyle overridden to inline: triggering the same add-item path shows the inline ghost-row TextField (not a popover) for the very first item — confirms no regression to the non-default path.
• Build: ./scripts/reload.sh --tag chkpop succeeded (local reload; reload-cloud.sh known-broken in this hq checkout).
• Killed the tagged app after verification; no stray cmux DEV chkpop processes remain.

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.}

---

Note

Medium Risk
Changes are mostly sidebar/todo UI and NSPopover focus/hover plumbing, but they touch lazy-list layout, popover lifecycle, and keyboard routing in ContentView, so regressions could show up as wrong anchor position, popover churn, or focus stealing from the terminal.

Overview
Popover style now covers empty checklists and the first item. presentsPopover no longer depends on item count; the NSPopover anchor lives on the section container via a full-width ChecklistSummaryPopoverModifier (1×1pt trailing overlay) so the same NSView survives 0→1 items. ContentView always routes .workspaceChecklistAddItemRequested to the popover in popover style, dismisses checklist/status popovers on workspace switch, and shows the checklist block without requiring a visible status glyph.

SidebarWorkspaceTodoPopoverHost is hardened against real-world AppKit/SwiftUI races: AnchorView retries present() after window attach; missing window no longer forces isPresented = false; an awaitingDismissAck latch stops close/reopen churn after transient dismissal; presentationRequestToken (add-field bump) clears the latch; layout is forced from the window root before show.

Checklist UI behavior is expanded and polished across sidebar, popover, and todo pane. The “… N more” clamp is replaced by scrollable lists capped at six rows. Long item text wraps with first-line-aligned checkboxes and controls. Hover-reveal delete buttons (plus sidebar.checklist.removeItemTooltip) appear on inline rows (onContinuousHover) and in the popover via new PopoverPointerTracker (persistent AppKit tracking + geometry-derived hover, with PopoverKeyWindowElevator). The popover add field gains empty-draft Backspace-to-delete and stricter highlight vs. typing disambiguation; the pane scrolls keyboard highlight into view.

^{Reviewed by Cursor Bugbot for commit cf219bf. Bugbot is set up for automated code reviews on this repo. Configure here.}

---

Summary by cubic

Empty checklists in .popover style now open the checklist popover for the first item reliably, with a stable right‑edge anchor, robust hover/focus, and no inline ghost row. .inline is unchanged.

• Bug Fixes

  • Always use the popover in .popover (no totalCount gate) and route .workspaceChecklistAddItemRequested; remove the inline ghost row when empty.
  • Anchor lives on the section container as a 1×1pt trailing overlay with an AnchorView that retries after window attach; stays right‑aligned, doesn’t intercept row hover, and remains mounted while the popover is open to avoid teardown during first‑add/last‑delete.
  • Popover hover tracking runs in AppKit via PopoverPointerTracker (hit‑test pass‑through) with pointer location held in a reference box and row frames via preference; coalesces updates, survives content changes, and is kept alive by a key‑window elevator.
  • Stop reopen churn by refreshing the host’s isPresented binding each update, latching after AppKit closes, only unlatching on non‑zero add‑request tokens; run root layout only on hidden‑to‑shown before show. Consume pending add‑field activation on close; workspace switches dismiss popovers and clear tokens.
  • Scrollable lists capped at 6 rows (inline and popover) instead of “… N more”; wrap long text and align checkbox/delete to the first line of wrapped text; typing clears any item highlight. Todo Pane wraps text, scroll‑follows arrow‑key highlight, and re‑arms the add field on open/focus; “Open as Pane” closes the popover before focusing the pane. Checklist renders even when status is hidden.

• New Features

  • Hover‑reveal delete button on checklist rows (inline and popover) with tooltip sidebar.checklist.removeItemTooltip (en, ja).
  • Backspace deletes the highlighted item when the add field is empty.

^{Written for commit 73fa1c1. Summary will update on new commits.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: cb4ec2e9-0e18-4b3a-974c-cc7b3b239096

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch checklist-popover-first-item

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
cmux	Ready	Preview, Comment	Jul 14, 2026 6:06am
cmux-staging	Building	Preview, Comment	Jul 14, 2026 6:06am

[greptile-apps]

Greptile Summary

This PR makes the checklist popover handle empty checklists and first-item entry. The main changes are:

• Routes popover-style add requests through the popover even when the checklist is empty.
• Moves the checklist popover anchor to the section container for the 0-to-1 item transition.
• Clears pending add-field activation when the popover closes or the selected workspace changes.
• Adds checklist hover removal, wrapped rows, scroll-capped lists, and pane add-field re-arming.

Confidence Score: 5/5

This looks safe to merge.

• No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
Sources/ContentView.swift	Routes checklist add requests into popover style for empty workspaces and clears pending add state on workspace changes.
Sources/SidebarWorkspaceChecklistView.swift	Uses the popover path for first-item entry and hosts the popover from the section container.
Sources/ChecklistSummaryPopoverModifier.swift	Adds the stable section-level popover anchor and forwards close state to the checklist popover.
Sources/SidebarWorkspaceTodoPopoverHost.swift	Updates NSPopover lifecycle handling for presentation, dismissal, and repeated add requests.
Sources/SidebarWorkspaceChecklistPopover.swift	Adds wrapped checklist rows, hover removal, keyboard deletion, and pane handoff behavior in the popover.

_{Reviews (14): Last reviewed commit: "Address review: keep popover host mounte..." | Re-trigger Greptile}

[greptile-apps]

Activation Token Stays Pending

When an empty checklist is opened through the new popover path and then dismissed without adding an item, the inline cancel path no longer runs and the popover close path does not consume addFieldActivationToken. That leaves checklistAddFieldActivationTokens[workspaceId] > 0, so an otherwise-empty checklist section can stay rendered indefinitely just because of stale add state.

Rule Used: Flag SwiftUI changes that can cause stale state, b... (source)

[greptile-apps]

Add Row Closes Popover

For an empty checklist opened by the add-item notification, the ghost “Add item” row remains visible while the popover is already open. Clicking it sends false here and closes the popover instead of keeping the add field available, so the add affordance behaves like a dismiss action.

Suggested change

	if presentsPopover {
	onPopoverPresentedChange(!isPopoverPresented)
	} else {
	if presentsPopover {
	onPopoverPresentedChange(true)
	} else {

Rule Used: Flag SwiftUI changes that can cause stale state, b... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[greptile-apps]

Add Row Dismisses In an empty checklist, expandedList keeps this ghost add row visible while the popover is already open. Clicking “Add item” then sends false through this toggle and closes the popover instead of keeping the add field available. The row should open the popover when closed and avoid dismissing it when it is already presented.

[greptile-apps]

Activation Token Persists When an empty checklist is opened through the popover and then dismissed without adding an item, the add-field activation token is still left in checklistAddFieldActivationTokens. The popover close path clears checklistPopoverWorkspaceId, but it does not consume the token. Since this gate keeps rendering the checklist section whenever checklistAddFieldActivationToken > 0, an otherwise-empty workspace can keep an empty checklist section alive after the user clicks outside the transient popover or cancels without committing. Clear the token when the popover add flow closes without a commit, or stop using the pending activation token as section visibility state after dismissal.

[greptile-apps]

Activation Token Persists This branch opens the checklist popover and leaves checklistAddFieldActivationTokens set. If the user dismisses the transient popover without adding an item, the close path clears checklistPopoverWorkspaceId but does not consume the activation token. Since the sidebar section still renders when checklistAddFieldActivationToken > 0, an empty workspace can keep stale add state after the popover closes. Clear the token when the popover add flow is dismissed without a commit, or make section visibility stop depending on a token after that flow has closed.

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit aee3354. Configure here.}

[greptile-apps]

Activation Token Persists This add-request path still bumps checklistAddFieldActivationTokens before opening the popover, but the popover can close without consuming that token. When a user opens the first-item popover and then presses Escape, clicks away, deactivates the app, or switches workspaces, the close path clears checklistPopoverWorkspaceId while the positive token still satisfies the empty-section visibility gate. That leaves the workspace in stale add state after the user canceled the add flow. Clear the token from the popover cancel/dismiss path when no item is committed.

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.