Make Settings open structurally reliable: AppKit-owned window lifecycle by austinywang · Pull Request #7783 · manaflow-ai/cmux

Add failing regression tests: Settings open must always produce a visible window

austinywang

and

claude

committed

33313fc

Make Settings open structurally reliable: AppKit-owned window lifecycle

austinywang

and

claude

committed

94b7af2

Address review: deliver navigation under hidden app, surface menu-path failure, truthful UI-test capture

austinywang

and

claude

committed

8977ae1

Address codex review: no-activate opens don't steal focus, deterministic mid-close rejection, fail-closed nil context

austinywang

and

claude

committed

ee23c79

Address review round 2: supersede-safe queued navigation, Settings sidebar toggle routing

austinywang

and

claude

committed

708080a

Fix workflow-guard-tests: move Settings-open entrypoints out of AppDelegate.swift

austinywang

and

claude

committed

40edeae

Address review round 3: content-readiness gating for navigation, browser entrypoint failure surfacing, Khmer localization

austinywang

and

claude

committed

7788d21

Fix CI test compile and Cursor findings: decouple test from package symbol, preserve pending target on untargeted shows

austinywang

and

claude

committed

43e05e5

Fix Swift warning budget: drop deprecated activation option, remove main-actor default argument

austinywang

and

claude

committed

ebbe77b

Address review round 4: reentrancy-safe teardown recovery

austinywang

and

claude

committed

9526370

Navigation Menu

Repository navigation

Make Settings open structurally reliable: AppKit-owned window lifecycle - #7783

Make Settings open structurally reliable: AppKit-owned window lifecycle#7783
austinywang merged 10 commits into
mainfrom
issue-7777-settings-always-open

Commits on Jul 10, 2026

Add failing regression tests: Settings open must always produce a visible window

Make Settings open structurally reliable: AppKit-owned window lifecycle

Address review: deliver navigation under hidden app, surface menu-path failure, truthful UI-test capture

Address codex review: no-activate opens don't steal focus, deterministic mid-close rejection, fail-closed nil context

Address review round 2: supersede-safe queued navigation, Settings sidebar toggle routing

Fix workflow-guard-tests: move Settings-open entrypoints out of AppDelegate.swift

Address review round 3: content-readiness gating for navigation, browser entrypoint failure surfacing, Khmer localization

Fix CI test compile and Cursor findings: decouple test from package symbol, preserve pending target on untargeted shows

Fix Swift warning budget: drop deprecated activation option, remove main-actor default argument

Address review round 4: reentrancy-safe teardown recovery