Repository navigation
Use existing prod profile secret for App Store workflow - #7753
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR updates the iOS App Store release workflow. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "Use existing prod profile secret for App..." | Re-trigger Greptile |
📝 WalkthroughWalkthroughThe iOS App Store workflow now uses ChangesiOS provisioning workflow
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| - name: Install App Store provisioning profile | ||
| env: | ||
| IOS_APPSTORE_PROVISIONING_PROFILE_BASE64: ${{ secrets.IOS_APPSTORE_PROVISIONING_PROFILE_BASE64 }} | ||
| IOS_APPSTORE_PROVISIONING_PROFILE_BASE64: ${{ secrets.IOS_APPSTORE_PROVISIONING_PROFILE_BASE64 || secrets.IOS_PROD_PROVISIONING_PROFILE_BASE64 }} |
There was a problem hiding this comment.
When the App Store secret is absent and the fallback profile decodes successfully but has a Name different from the upload script default, this step installs that profile but the export step still looks for cmux App Store Distribution. The workflow can fail later during xcodebuild -exportArchive even though the profile passed the new fallback validation.
Rule Used: Flag SwiftPM package, Xcode project, .gitignore, w... (source)
257872c to
c0ee3d8
Compare
Summary
Verification
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Note
Low Risk
Workflow-only secret fallback with the same profile validation; no app or signing logic changes.
Overview
The iOS App Store workflow’s “Install App Store provisioning profile” step now resolves
IOS_APPSTORE_PROVISIONING_PROFILE_BASE64fromIOS_APPSTORE_PROVISIONING_PROFILE_BASE64or, if that secret is missing, fromIOS_PROD_PROVISIONING_PROFILE_BASE64.Decode, install, and plist checks (bundle id
com.cmuxterm.app, production APNs, Sign in with Apple) are unchanged—only which secret supplies the profile bytes.Reviewed by Cursor Bugbot for commit 257872c. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
App Store build workflow now falls back to
IOS_PROD_PROVISIONING_PROFILE_BASE64ifIOS_APPSTORE_PROVISIONING_PROFILE_BASE64is missing, preventing failed builds when the App Store secret isn’t set. Existing profile checks forcom.cmuxterm.app, production APNs, and Sign in with Apple remain unchanged; CI-only updates with no app code changes.Written for commit c0ee3d8. Summary will update on new commits.
Summary by CodeRabbit