Repository navigation
Use approved iOS version 1.0.1 for TestFlight beta CI - #7636
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThe TestFlight scheduled upload flow now reuses the checked-in iOS MARKETING_VERSION instead of auto-versioning. Workflow comments, the iOS version source, upload metadata, and README instructions were updated to match the new scheduled and override behavior. ChangesScheduled TestFlight versioning update
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR stops the scheduled iOS TestFlight lane from passing
Confidence Score: 5/5Safe to merge — all three changed files make consistent, intentional adjustments to version policy and documentation with no logic regressions. The workflow change (dropping --auto-version) aligns with the xcconfig rollback to the approved MARKETING_VERSION; the upload_mode rename is inert because no downstream job or script parses the field value. The README and inline comments are updated consistently, and the operator caveat for internal testers is clearly documented. No files require special attention. Important Files Changed
Reviews (3): Last reviewed commit: "Use approved iOS beta version 1.0.1" | Re-trigger Greptile |
32b096b to
302433d
Compare
302433d to
d9895d5
Compare
azooz2003-bit
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d9895d5. Configure here.
| # Test" notes from the commits since the previous beta (skipped if we | ||
| # have no base SHA yet). | ||
| ARGS=(--lane beta --signing manual --auto-version --external) | ||
| ARGS=(--lane beta --signing manual --external) |
There was a problem hiding this comment.
Missing range notes guard
Medium Severity
Dropping --auto-version without always enabling range-notes mode means canonical uploads with an empty LAST_UPLOADED_SHA fall back to changelog validation. This commit sets MARKETING_VERSION to 1.0.1 while ios/CHANGELOG.md still tops out at 1.0.3, so upload-testflight.sh preflight fails before archive.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit d9895d5. Configure here.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/ios-testflight.yml (1)
440-464: 🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy liftHandle the empty
LAST_UPLOADED_SHApath
WhenLAST_UPLOADED_SHAis empty, this upload falls back to the changelog version guard and comparesios/CHANGELOG.md’s top entry (1.0.3) against the archivedMARKETING_VERSION(1.0.1), so the first no-history run will fail. Add a fallback--notes-from-rangebase for the empty-history case, or don’t reuse the older marketing version here.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/ios-testflight.yml around lines 440 - 464, The beta upload path in the workflow is missing a valid notes base when LAST_UPLOADED_SHA is empty, which causes the changelog/version guard to compare the current top entry against an older MARKETING_VERSION and fail. Update the upload logic around the ARGS construction in the iOS TestFlight workflow to either supply a fallback --notes-from-range value for the first no-history run or avoid reusing the archived marketing version in that branch, so the upload script can proceed cleanly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/ios-testflight.yml:
- Around line 440-464: The beta upload path in the workflow is missing a valid
notes base when LAST_UPLOADED_SHA is empty, which causes the changelog/version
guard to compare the current top entry against an older MARKETING_VERSION and
fail. Update the upload logic around the ARGS construction in the iOS TestFlight
workflow to either supply a fallback --notes-from-range value for the first
no-history run or avoid reusing the archived marketing version in that branch,
so the upload script can proceed cleanly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 73739003-3c7d-4884-959b-c91240a5f316
📒 Files selected for processing (3)
.github/workflows/ios-testflight.ymlios/Config/Shared.xcconfigios/README.md
This branch was successfully deployed
1 participant
Summary
--auto-versionMARKETING_VERSIONto the approved1.0.1MARKETING_VERSIONso CI can publish builds under the already-approved versionCaveat
External testers could not install the unapproved pending version, so this unblocks the external beta path. Internal testers who already installed a higher internal-only TestFlight build will not see lower-version builds as updates. They need a one-time reinstall, or an operator needs to cut an internal-only build on the higher version.
Verification
git diff --checkruby -e 'require "yaml"; YAML.load_file(".github/workflows/ios-testflight.yml"); puts "workflow yaml ok"'\n-bash -n ios/scripts/upload-testflight.sh\n\nNo tagged reload: workflow/version metadata change.Note
Medium Risk
Changes release versioning and TestFlight distribution behavior for all scheduled main betas; wrong MARKETING_VERSION in xcconfig could ship misleading user-visible versions or delay external access until review.
Overview
Scheduled iOS TestFlight uploads on
mainno longer pass--auto-version, so each beta uses theMARKETING_VERSIONinios/Config/Shared.xcconfiginstead of stamping the next patch above the lastios-v*tag. That keeps external builds on an already Beta App Review–approved marketing version so CI can keep shippingmainwithout waiting on a pending higher version.The checked-in version is set to
1.0.1(down from1.0.3). Workflow comments, step summaries, and build metadata now label this path aschecked_in_versionrather thanauto_version.ios/README.mdexplains that external testers are unblocked by the rollback, while internal testers who already installed a higher pending build must reinstall or take a one-off higher-version internal cut—TestFlight does not treat lower marketing versions as updates.Reviewed by Cursor Bugbot for commit d9895d5. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
Documentation
Bug Fixes
Chores
MARKETING_VERSIONvalue from1.0.3to1.0.1.