Skip to content

Fix Cloud VM panel text readability across all terminal themes #7538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamleaderleo merged 3 commits into from
Sep 24, 2026
Merged

Fix Cloud VM panel text readability across all terminal themes #7538

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29cb166
Fix Cloud VM panel text readability across all terminal themes
lawrencecchen Jul 7, 2026
1b6d9a1
Merge main and preserve Cloud panel theme contrast after extraction
lawrencecchen Sep 17, 2026
a1da579
Merge remote-tracking branch 'origin/main' into bk-7538
teamleaderleo Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Sources/Panels/CloudVMLoadingPanelView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@ struct CloudVMLoadingPanelView: View {
}

private func baseContent(elapsedSeconds: Int) -> some View {
VStack(spacing: 14) {
// Match semantic text colors to the terminal background, which can
// differ from the system appearance.
let backgroundColor = GhosttyApp.shared.defaultBackgroundColor
let readableScheme = WindowChromeColorResolver().readableColorScheme(for: backgroundColor)
return VStack(spacing: 14) {
switch panel.phase {
case .loading(let loadingHeadline):
if let loadingHeadline {
Expand Down Expand Up @@ -97,7 +101,8 @@ struct CloudVMLoadingPanelView: View {
}
.padding(32)
.frame(maxWidth: .infinity, maxHeight: .infinity)
.background(Color(nsColor: GhosttyApp.shared.defaultBackgroundColor))
.background(Color(nsColor: backgroundColor))
.environment(\.colorScheme, readableScheme)
}
}

Expand Down
Loading