Skip to content

Refresh Swift file length budget for WorkspaceDetailView.swift - #7326

Closed
lawrencecchen wants to merge 1 commit into
mainfrom
fix-swift-length-budget
Closed

lawrencecchen wants to merge 1 commit into
mainfrom
fix-swift-length-budget

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Jul 4, 2026 •

Copy link
Copy Markdown
Contributor

#7067 grew Packages/iOS/CmuxMobileShellUI/Sources/CmuxMobileShellUI/WorkspaceDetailView.swift to 697 lines without refreshing its 694-line entry in .github/swift-file-length-budget.tsv, so workflow-guard-tests currently fails on main and on every branch cut from it (main's recent CI runs were cancelled, which hid it; first surfaced on #7324). One-line budget refresh accepting the already-merged growth, per the guard's own remediation message. python3 scripts/swift_file_length_budget.py exits 0 after the bump.

🤖 Generated with Claude Code


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.


Note

Low Risk
Single metadata line in a CI budget TSV; no production code or security-sensitive paths touched.

Overview
Updates .github/swift-file-length-budget.tsv so WorkspaceDetailView.swift is allowed 697 lines instead of 694, matching growth already merged in an earlier PR.

This is a CI guard refresh only—no Swift or app behavior changes. It unblocks workflow-guard-tests / swift_file_length_budget.py on main and branches that inherited the stale budget.

Reviewed by Cursor Bugbot for commit af129bc. Bugbot is set up for automated code reviews on this repo. Configure here.


Summary by cubic

Updates the Swift file length budget for Packages/iOS/CmuxMobileShellUI/Sources/CmuxMobileShellUI/WorkspaceDetailView.swift from 694 to 697 to match the file and restore passing workflow-guard-tests on main and new branches. No app code changes; only .github/swift-file-length-budget.tsv updated.

Written for commit af129bc. Summary will update on new commits.

Review in cubic

#7067 grew
Packages/iOS/CmuxMobileShellUI/Sources/CmuxMobileShellUI/WorkspaceDetailView.swift
to 697 lines without refreshing the 694-line budget entry, so
workflow-guard-tests fails on main and on every branch cut from it
(main's own CI runs were cancelled, which hid the breakage). Bump the
single entry to the actual length; no other entries touched.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmux Ready Ready Preview, Comment Jul 4, 2026 3:48pm
cmux-staging Building Building Preview, Comment Jul 4, 2026 3:48pm

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • .github/swift-file-length-budget.tsv is excluded by !**/*.tsv

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a6fb28ae-80ff-4448-b813-b56a25c7122d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-swift-length-budget

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Obsolete: main refreshed this budget entry (now 712) independently, so this branch is now identical to main. The guard failure that motivated it is fixed by merging current main.

@lawrencecchen
lawrencecchen deleted the fix-swift-length-budget branch July 4, 2026 23:42

This branch was successfully deployed

1 active deployment
Preview – cmux — af129bcb Deployed Jul 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant