Repository navigation
Fix infinite recursion crash in FileDropOverlayView.mouseDown - #69
Closed
austinywang wants to merge 1 commit into
Closed
austinywang wants to merge 1 commit into
austinywang wants to merge 1 commit into
Conversation
The hide-send-unhide pattern in forwardEvent() causes infinite recursion because NSWindow.sendEvent: doesn't always re-do hit testing for mouse events — it routes the event back to the same overlay view, creating a loop that overflows the 8MB stack after ~43K frames. Add a reentrancy guard so re-entrant calls from sendEvent: are dropped. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Preview Videos and ScreenshotsOpen Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap Screenshot capture was skipped.
Generated by manaflow preview system |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Closing in favor of #68 which is a better fix — direct dispatch via hit-test instead of reentrancy guard that would silently swallow mouse events. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileDropOverlayView.forwardEvent()NSWindow.sendEvent:routes the event back to the same overlay view without re-doing hit testingisForwardingreentrancy guard to break the cycleTest plan
🤖 Generated with Claude Code