Add configurable Cmd+Shift/Option+Shift override for sidebar PR links

Sources/ContentView.swift

@@ -2103,7 +2103,7 @@
             }
         })
 
         view = AnyView(view.onChange(of: tabManager.selectedTabId) { newValue in
 #if DEBUG
             if let snapshot = tabManager.debugCurrentWorkspaceSwitchSnapshot() {
                 let dtMs = (CACurrentMediaTime() - snapshot.startedAt) * 1000
@@ -2125,7 +2125,7 @@
             updateTitlebarText()
         })
 
         view = AnyView(view.onChange(of: tabManager.isWorkspaceCycleHot) { _ in
 #if DEBUG
             if let snapshot = tabManager.debugCurrentWorkspaceSwitchSnapshot() {
                 let dtMs = (CACurrentMediaTime() - snapshot.startedAt) * 1000
@@ -2139,7 +2139,7 @@
             reconcileMountedWorkspaceIds()
         })
 
         view = AnyView(view.onChange(of: retiringWorkspaceId) { _ in
             reconcileMountedWorkspaceIds()
         })
 
@@ -2330,11 +2330,11 @@
             }
         }))
 
         view = AnyView(view.onChange(of: bgGlassTintHex) { _ in
             updateWindowGlassTint()
         })
 
         view = AnyView(view.onChange(of: bgGlassTintOpacity) { _ in
             updateWindowGlassTint()
         })
 
@@ -2361,7 +2361,7 @@
             updateSidebarResizerBandState()
         })
 
         view = AnyView(view.onChange(of: sidebarWidth) { _ in
             let sanitized = normalizedSidebarWidth(sidebarWidth)
             if abs(sidebarWidth - sanitized) > 0.5 {
                 sidebarWidth = sanitized
@@ -2373,11 +2373,11 @@
             updateSidebarResizerBandState()
         })
 
         view = AnyView(view.onChange(of: sidebarState.isVisible) { _ in
             updateSidebarResizerBandState()
         })
 
         view = AnyView(view.onChange(of: sidebarState.persistedWidth) { newValue in
             let sanitized = normalizedSidebarWidth(newValue)
             if abs(newValue - sanitized) > 0.5 {
                 sidebarState.persistedWidth = sanitized
@@ -2781,7 +2781,7 @@
                 ),
                 anchor: commandPaletteScrollTargetAnchor
             )
             .onChange(of: commandPaletteSelectedResultIndex) { _ in
                 updateCommandPaletteScrollTarget(resultCount: visibleResults.count, animated: true)
             }
 
@@ -2800,14 +2800,14 @@
             updateCommandPaletteScrollTarget(resultCount: visibleResults.count, animated: false)
             resetCommandPaletteSearchFocus()
         }
         .onChange(of: commandPaletteQuery) { _ in
             commandPaletteSelectedResultIndex = 0
             commandPaletteHoveredResultIndex = nil
             commandPaletteScrollTargetIndex = nil
             commandPaletteScrollTargetAnchor = nil
             syncCommandPaletteDebugStateForObservedWindow()
         }
         .onChange(of: visibleResults.count) { _ in
             commandPaletteSelectedResultIndex = commandPaletteSelectedIndex(resultCount: visibleResults.count)
             updateCommandPaletteScrollTarget(resultCount: visibleResults.count, animated: false)
             if let hoveredIndex = commandPaletteHoveredResultIndex, hoveredIndex >= visibleResults.count {
@@ -2815,7 +2815,7 @@
             }
             syncCommandPaletteDebugStateForObservedWindow()
         }
         .onChange(of: commandPaletteSelectedResultIndex) { _ in
             syncCommandPaletteDebugStateForObservedWindow()
         }
     }
@@ -4214,8 +4214,9 @@
             tabManager.selectPreviousSurface()
         }
         registry.register(commandId: "palette.openWorkspacePullRequests") {
+            let modifierFlags = NSEvent.modifierFlags
             DispatchQueue.main.async {
-                if !openWorkspacePullRequestsInConfiguredBrowser() {
+                if !openWorkspacePullRequestsInConfiguredBrowser(modifierFlags: modifierFlags) {
                     NSSound.beep()
                 }
             }
@@ -4884,13 +4885,18 @@
         return NSWorkspace.shared.open(url)
     }
 
-    private func openWorkspacePullRequestsInConfiguredBrowser() -> Bool {
+    private func openWorkspacePullRequestsInConfiguredBrowser(
+        modifierFlags: NSEvent.ModifierFlags = NSEvent.modifierFlags
+    ) -> Bool {
         guard let workspace = tabManager.selectedWorkspace else { return false }
         let pullRequests = workspace.sidebarPullRequestsInDisplayOrder()
         guard !pullRequests.isEmpty else { return false }
 
+        let shouldOpenInCmuxBrowser = BrowserLinkOpenSettings.shouldOpenSidebarPullRequestLinkInCmuxBrowser(
+            modifierFlags: modifierFlags
+        )
         var openedCount = 0
-        if openSidebarPullRequestLinksInCmuxBrowser {
+        if shouldOpenInCmuxBrowser {
             for pullRequest in pullRequests {
                 if tabManager.openBrowser(url: pullRequest.url, insertAtEnd: true) != nil {
                     openedCount += 1
@@ -5652,7 +5658,7 @@
                 reason: "sidebar_disappear"
             )
         }
         .onChange(of: draggedTabId) { newDraggedTabId in
             SidebarDragLifecycleNotification.postStateDidChange(
                 tabId: newDraggedTabId,
                 reason: "drag_state_change"
@@ -6762,7 +6768,7 @@
                     .onAppear {
                         rowHeight = max(proxy.size.height, 1)
                     }
                     .onChange(of: proxy.size.height) { newHeight in
                         rowHeight = max(newHeight, 1)
                     }
             }
@@ -7054,17 +7060,17 @@
         selection = .tabs
     }
 
-    private func updateSelection() {
+    private func updateSelection(modifierFlags: NSEvent.ModifierFlags = NSEvent.modifierFlags) {
         #if DEBUG
-        let mods = NSEvent.modifierFlags
+        let mods = modifierFlags
         var modStr = ""
         if mods.contains(.command) { modStr += "cmd " }
         if mods.contains(.shift) { modStr += "shift " }
         if mods.contains(.option) { modStr += "opt " }
         if mods.contains(.control) { modStr += "ctrl " }
         dlog("sidebar.select workspace=\(tab.id.uuidString.prefix(5)) modifiers=\(modStr.isEmpty ? "none" : modStr.trimmingCharacters(in: .whitespaces))")
         #endif
-        let modifiers = NSEvent.modifierFlags
+        let modifiers = modifierFlags
         let isCommand = modifiers.contains(.command)
         let isShift = modifiers.contains(.shift)
 
@@ -7310,8 +7316,12 @@
     }
 
     private func openPullRequestLink(_ url: URL) {
-        updateSelection()
-        if openSidebarPullRequestLinksInCmuxBrowser {
+        let openModifierFlags = NSEvent.modifierFlags
+        updateSelection(modifierFlags: [])
+        let shouldOpenInCmuxBrowser = BrowserLinkOpenSettings.shouldOpenSidebarPullRequestLinkInCmuxBrowser(
+            modifierFlags: openModifierFlags
+        )
+        if shouldOpenInCmuxBrowser {
             if tabManager.openBrowser(
                 inWorkspace: tab.id,
                 url: url,
@@ -7748,7 +7758,7 @@
         .contentShape(Rectangle())
         .onTapGesture { onFocus() }
         .onAppear(perform: renderMarkdown)
         .onChange(of: block.markdown) { _ in
             renderMarkdown()
         }
     }

Sources/Panels/BrowserPanel.swift

@@ -127,6 +127,43 @@
     }
 }
 
+enum BrowserLinkModifierBehavior: String, CaseIterable, Identifiable {
+    case commandShiftOpensCmuxOptionShiftOpensDefault
+    case commandShiftOpensDefaultOptionShiftOpensCmux
+
+    var id: String { rawValue }
+
+    var displayName: String {
+        switch self {
+        case .commandShiftOpensCmuxOptionShiftOpensDefault:
+            return "Cmd+Shift -> cmux, Option+Shift -> Default"
+        case .commandShiftOpensDefaultOptionShiftOpensCmux:
+            return "Cmd+Shift -> Default, Option+Shift -> cmux"
+        }
+    }
+
+    var summary: String {
+        switch self {
+        case .commandShiftOpensCmuxOptionShiftOpensDefault:
+            return "Cmd+Shift forces cmux browser, Option+Shift forces your default browser."
+        case .commandShiftOpensDefaultOptionShiftOpensCmux:
+            return "Cmd+Shift forces your default browser, Option+Shift forces cmux browser."
+        }
+    }
+
+    func opensInCmuxBrowser(for modifierFlags: NSEvent.ModifierFlags) -> Bool? {
+        let normalizedFlags = modifierFlags.intersection([.command, .shift, .option, .control])
+        switch normalizedFlags {
+        case [.command, .shift]:
+            return self == .commandShiftOpensCmuxOptionShiftOpensDefault
+        case [.option, .shift]:
+            return self == .commandShiftOpensDefaultOptionShiftOpensCmux
+        default:
+            return nil
+        }
+    }
+}
+
 enum BrowserLinkOpenSettings {
     static let openTerminalLinksInCmuxBrowserKey = "browserOpenTerminalLinksInCmuxBrowser"
     static let defaultOpenTerminalLinksInCmuxBrowser: Bool = true
@@ -137,6 +174,9 @@
     static let interceptTerminalOpenCommandInCmuxBrowserKey = "browserInterceptTerminalOpenCommandInCmuxBrowser"
     static let defaultInterceptTerminalOpenCommandInCmuxBrowser: Bool = true
 
+    static let linkModifierBehaviorKey = "browserLinkModifierBehavior"
+    static let defaultLinkModifierBehavior: BrowserLinkModifierBehavior = .commandShiftOpensCmuxOptionShiftOpensDefault
+
     static let browserHostWhitelistKey = "browserHostWhitelist"
     static let defaultBrowserHostWhitelist: String = ""
 
@@ -171,6 +211,38 @@
         interceptTerminalOpenCommandInCmuxBrowser(defaults: defaults)
     }
 
+    static func linkModifierBehavior(for rawValue: String?) -> BrowserLinkModifierBehavior {
+        guard let rawValue,
+              let behavior = BrowserLinkModifierBehavior(rawValue: rawValue) else {
+            return defaultLinkModifierBehavior
+        }
+        return behavior
+    }
+
+    static func linkModifierBehavior(defaults: UserDefaults = .standard) -> BrowserLinkModifierBehavior {
+        linkModifierBehavior(for: defaults.string(forKey: linkModifierBehaviorKey))
+    }
+
+    static func linkModifierOverrideOpensInCmuxBrowser(
+        modifierFlags: NSEvent.ModifierFlags,
+        defaults: UserDefaults = .standard
+    ) -> Bool? {
+        linkModifierBehavior(defaults: defaults).opensInCmuxBrowser(for: modifierFlags)
+    }
+
+    static func shouldOpenSidebarPullRequestLinkInCmuxBrowser(
+        modifierFlags: NSEvent.ModifierFlags,
+        defaults: UserDefaults = .standard
+    ) -> Bool {
+        if let modifierOverride = linkModifierOverrideOpensInCmuxBrowser(
+            modifierFlags: modifierFlags,
+            defaults: defaults
+        ) {
+            return modifierOverride
+        }
+        return openSidebarPullRequestLinksInCmuxBrowser(defaults: defaults)
+    }
+
     static func hostWhitelist(defaults: UserDefaults = .standard) -> [String] {
         let raw = defaults.string(forKey: browserHostWhitelistKey) ?? defaultBrowserHostWhitelist
         return raw
@@ -1117,7 +1189,7 @@
 @MainActor
 final class BrowserPanel: Panel, ObservableObject {
     /// Shared process pool for cookie sharing across all browser panels
     private static let sharedProcessPool = WKProcessPool()
 
     static let telemetryHookBootstrapScriptSource = """
     (() => {
@@ -1219,7 +1291,7 @@
     }
 
     private static func isDarkAppearance(
         appAppearance: NSAppearance? = NSApp?.effectiveAppearance
     ) -> Bool {
         guard let appAppearance else { return false }
         return appAppearance.bestMatch(from: [.darkAqua, .aqua]) == .darkAqua
@@ -1244,7 +1316,7 @@
 
     private static func resolvedBrowserChromeBackgroundColor(
         from notification: Notification? = nil,
         appAppearance: NSAppearance? = NSApp?.effectiveAppearance
     ) -> NSColor {
         if isDarkAppearance(appAppearance: appAppearance) {
             return resolvedGhosttyBackgroundColor(from: notification)
@@ -1375,7 +1447,7 @@
 
         // Configure web view
         let config = WKWebViewConfiguration()
         config.processPool = BrowserPanel.sharedProcessPool
         // Ensure browser cookies/storage persist across navigations and launches.
         // This reduces repeated consent/bot-challenge flows on sites like Google.
         config.websiteDataStore = .default()
@@ -1500,7 +1572,7 @@
         if Thread.isMainThread {
             apply()
         } else {
             DispatchQueue.main.async(execute: apply)
         }
     }
 
@@ -1512,7 +1584,7 @@
         if Thread.isMainThread {
             apply()
         } else {
             DispatchQueue.main.async(execute: apply)
         }
     }
 

Sources/cmuxApp.swift

@@ -202,10 +202,10 @@
                         }
                     }
                 }
                 .onChange(of: appearanceMode) { _ in
                     applyAppearance()
                 }
                 .onChange(of: socketControlMode) { _ in
                     updateSocketController()
                 }
         }
@@ -1941,7 +1941,7 @@
                             Text(option.title).tag(option.rawValue)
                         }
                     }
                     .onChange(of: sidebarPreset) { _ in
                         applyPreset()
                     }
                     .padding(.top, 2)
@@ -2297,19 +2297,19 @@
             .frame(maxWidth: .infinity, alignment: .topLeading)
         }
         .onAppear { applyLiveUpdate() }
         .onChange(of: previewEnabled) { _ in applyLiveUpdate() }
         .onChange(of: previewCount) { _ in applyLiveUpdate() }
         .onChange(of: badgeRectX) { _ in applyLiveUpdate() }
         .onChange(of: badgeRectY) { _ in applyLiveUpdate() }
         .onChange(of: badgeRectWidth) { _ in applyLiveUpdate() }
         .onChange(of: badgeRectHeight) { _ in applyLiveUpdate() }
         .onChange(of: singleDigitFontSize) { _ in applyLiveUpdate() }
         .onChange(of: multiDigitFontSize) { _ in applyLiveUpdate() }
         .onChange(of: singleDigitXAdjust) { _ in applyLiveUpdate() }
         .onChange(of: multiDigitXAdjust) { _ in applyLiveUpdate() }
         .onChange(of: singleDigitYOffset) { _ in applyLiveUpdate() }
         .onChange(of: multiDigitYOffset) { _ in applyLiveUpdate() }
         .onChange(of: textRectWidthAdjust) { _ in applyLiveUpdate() }
     }
 
     private func sliderRow(
@@ -2437,8 +2437,8 @@
             .padding(16)
             .frame(maxWidth: .infinity, alignment: .topLeading)
         }
         .onChange(of: bgGlassTintHex) { _ in updateWindowGlassTint() }
         .onChange(of: bgGlassTintOpacity) { _ in updateWindowGlassTint() }
     }
 
     private func updateWindowGlassTint() {
@@ -2674,6 +2674,8 @@
     @AppStorage(BrowserLinkOpenSettings.openTerminalLinksInCmuxBrowserKey) private var openTerminalLinksInCmuxBrowser = BrowserLinkOpenSettings.defaultOpenTerminalLinksInCmuxBrowser
     @AppStorage(BrowserLinkOpenSettings.interceptTerminalOpenCommandInCmuxBrowserKey)
     private var interceptTerminalOpenCommandInCmuxBrowser = BrowserLinkOpenSettings.initialInterceptTerminalOpenCommandInCmuxBrowserValue()
+    @AppStorage(BrowserLinkOpenSettings.linkModifierBehaviorKey)
+    private var linkModifierBehavior = BrowserLinkOpenSettings.defaultLinkModifierBehavior.rawValue
     @AppStorage(BrowserLinkOpenSettings.browserHostWhitelistKey) private var browserHostWhitelist = BrowserLinkOpenSettings.defaultBrowserHostWhitelist
     @AppStorage(BrowserInsecureHTTPSettings.allowlistKey) private var browserInsecureHTTPAllowlist = BrowserInsecureHTTPSettings.defaultAllowlistText
     @AppStorage(NotificationBadgeSettings.dockBadgeEnabledKey) private var notificationDockBadgeEnabled = NotificationBadgeSettings.defaultDockBadgeEnabled
@@ -2741,6 +2743,19 @@
         )
     }
 
+    private var selectedLinkModifierBehavior: BrowserLinkModifierBehavior {
+        BrowserLinkOpenSettings.linkModifierBehavior(for: linkModifierBehavior)
+    }
+
+    private var linkModifierBehaviorSelection: Binding<String> {
+        Binding(
+            get: { selectedLinkModifierBehavior.rawValue },
+            set: { newValue in
+                linkModifierBehavior = BrowserLinkOpenSettings.linkModifierBehavior(for: newValue).rawValue
+            }
+        )
+    }
+
     private var socketModeSelection: Binding<String> {
         Binding(
             get: { socketControlMode },
@@ -2962,6 +2977,22 @@
 
                         SettingsCardDivider()
 
+                        SettingsCardRow(
+                            "Sidebar PR Link Modifier Override",
+                            subtitle: selectedLinkModifierBehavior.summary,
+                            controlWidth: pickerColumnWidth
+                        ) {
+                            Picker("", selection: linkModifierBehaviorSelection) {
+                                ForEach(BrowserLinkModifierBehavior.allCases) { behavior in
+                                    Text(behavior.displayName).tag(behavior.rawValue)
+                                }
+                            }
+                            .labelsHidden()
+                            .pickerStyle(.menu)
+                        }
+
+                        SettingsCardDivider()
+
                         SettingsCardRow(
                             "Show Listening Ports in Sidebar",
                             subtitle: "Display detected listening ports for the active workspace."
@@ -3479,6 +3510,7 @@
         .onAppear {
             BrowserHistoryStore.shared.loadIfNeeded()
             browserThemeMode = BrowserThemeSettings.mode(defaults: .standard).rawValue
+            linkModifierBehavior = BrowserLinkOpenSettings.linkModifierBehavior(defaults: .standard).rawValue
             browserHistoryEntryCount = BrowserHistoryStore.shared.entries.count
             browserInsecureHTTPAllowlistDraft = browserInsecureHTTPAllowlist
             reloadWorkspaceTabColorSettings()
@@ -3534,6 +3566,7 @@
         browserThemeMode = BrowserThemeSettings.defaultMode.rawValue
         openTerminalLinksInCmuxBrowser = BrowserLinkOpenSettings.defaultOpenTerminalLinksInCmuxBrowser
         interceptTerminalOpenCommandInCmuxBrowser = BrowserLinkOpenSettings.defaultInterceptTerminalOpenCommandInCmuxBrowser
+        linkModifierBehavior = BrowserLinkOpenSettings.defaultLinkModifierBehavior.rawValue
         browserHostWhitelist = BrowserLinkOpenSettings.defaultBrowserHostWhitelist
         browserInsecureHTTPAllowlist = BrowserInsecureHTTPSettings.defaultAllowlistText
         browserInsecureHTTPAllowlistDraft = BrowserInsecureHTTPSettings.defaultAllowlistText
@@ -3751,7 +3784,7 @@
 
     var body: some View {
         KeyboardShortcutRecorder(label: action.label, shortcut: $shortcut)
             .onChange(of: shortcut) { newValue in
                 KeyboardShortcutSettings.setShortcut(newValue, for: action)
             }
             .onReceive(NotificationCenter.default.publisher(for: UserDefaults.didChangeNotification)) { _ in

cmuxTests/CmuxWebViewKeyEquivalentTests.swift

@@ -7636,6 +7636,129 @@ final class BrowserLinkOpenSettingsTests: XCTestCase {
         defaults.set(true, forKey: BrowserLinkOpenSettings.openTerminalLinksInCmuxBrowserKey)
         XCTAssertTrue(BrowserLinkOpenSettings.initialInterceptTerminalOpenCommandInCmuxBrowserValue(defaults: defaults))
     }
+
+    func testLinkModifierBehaviorDefaultsToCommandShiftCmux() {
+        XCTAssertEqual(
+            BrowserLinkOpenSettings.linkModifierBehavior(defaults: defaults),
+            .commandShiftOpensCmuxOptionShiftOpensDefault
+        )
+    }
+
+    func testLinkModifierBehaviorUsesStoredValue() {
+        defaults.set(
+            BrowserLinkModifierBehavior.commandShiftOpensDefaultOptionShiftOpensCmux.rawValue,
+            forKey: BrowserLinkOpenSettings.linkModifierBehaviorKey
+        )
+        XCTAssertEqual(
+            BrowserLinkOpenSettings.linkModifierBehavior(defaults: defaults),
+            .commandShiftOpensDefaultOptionShiftOpensCmux
+        )
+    }
+
+    func testLinkModifierOverrideMatchesConfiguredBehavior() {
+        defaults.set(
+            BrowserLinkModifierBehavior.commandShiftOpensCmuxOptionShiftOpensDefault.rawValue,
+            forKey: BrowserLinkOpenSettings.linkModifierBehaviorKey
+        )
+        XCTAssertEqual(
+            BrowserLinkOpenSettings.linkModifierOverrideOpensInCmuxBrowser(
+                modifierFlags: [.command, .shift],
+                defaults: defaults
+            ),
+            true
+        )
+        XCTAssertEqual(
+            BrowserLinkOpenSettings.linkModifierOverrideOpensInCmuxBrowser(
+                modifierFlags: [.option, .shift],
+                defaults: defaults
+            ),
+            false
+        )
+
+        defaults.set(
+            BrowserLinkModifierBehavior.commandShiftOpensDefaultOptionShiftOpensCmux.rawValue,
+            forKey: BrowserLinkOpenSettings.linkModifierBehaviorKey
+        )
+        XCTAssertEqual(
+            BrowserLinkOpenSettings.linkModifierOverrideOpensInCmuxBrowser(
+                modifierFlags: [.command, .shift],
+                defaults: defaults
+            ),
+            false
+        )
+        XCTAssertEqual(
+            BrowserLinkOpenSettings.linkModifierOverrideOpensInCmuxBrowser(
+                modifierFlags: [.option, .shift],
+                defaults: defaults
+            ),
+            true
+        )
+    }
+
+    func testLinkModifierOverrideIgnoresUnconfiguredModifierSets() {
+        XCTAssertNil(
+            BrowserLinkOpenSettings.linkModifierOverrideOpensInCmuxBrowser(
+                modifierFlags: [.shift],
+                defaults: defaults
+            )
+        )
+        XCTAssertNil(
+            BrowserLinkOpenSettings.linkModifierOverrideOpensInCmuxBrowser(
+                modifierFlags: [.command],
+                defaults: defaults
+            )
+        )
+        XCTAssertNil(
+            BrowserLinkOpenSettings.linkModifierOverrideOpensInCmuxBrowser(
+                modifierFlags: [.command, .shift, .control],
+                defaults: defaults
+            )
+        )
+    }
+
+    func testShouldOpenSidebarPullRequestLinkInCmuxBrowserFallsBackToToggleWhenNoOverrideModifier() {
+        defaults.set(false, forKey: BrowserLinkOpenSettings.openSidebarPullRequestLinksInCmuxBrowserKey)
+        XCTAssertFalse(
+            BrowserLinkOpenSettings.shouldOpenSidebarPullRequestLinkInCmuxBrowser(
+                modifierFlags: [],
+                defaults: defaults
+            )
+        )
+
+        defaults.set(true, forKey: BrowserLinkOpenSettings.openSidebarPullRequestLinksInCmuxBrowserKey)
+        XCTAssertTrue(
+            BrowserLinkOpenSettings.shouldOpenSidebarPullRequestLinkInCmuxBrowser(
+                modifierFlags: [],
+                defaults: defaults
+            )
+        )
+    }
+
+    func testShouldOpenSidebarPullRequestLinkInCmuxBrowserUsesModifierOverride() {
+        defaults.set(false, forKey: BrowserLinkOpenSettings.openSidebarPullRequestLinksInCmuxBrowserKey)
+        defaults.set(
+            BrowserLinkModifierBehavior.commandShiftOpensCmuxOptionShiftOpensDefault.rawValue,
+            forKey: BrowserLinkOpenSettings.linkModifierBehaviorKey
+        )
+        XCTAssertTrue(
+            BrowserLinkOpenSettings.shouldOpenSidebarPullRequestLinkInCmuxBrowser(
+                modifierFlags: [.command, .shift],
+                defaults: defaults
+            )
+        )
+
+        defaults.set(true, forKey: BrowserLinkOpenSettings.openSidebarPullRequestLinksInCmuxBrowserKey)
+        defaults.set(
+            BrowserLinkModifierBehavior.commandShiftOpensDefaultOptionShiftOpensCmux.rawValue,
+            forKey: BrowserLinkOpenSettings.linkModifierBehaviorKey
+        )
+        XCTAssertFalse(
+            BrowserLinkOpenSettings.shouldOpenSidebarPullRequestLinkInCmuxBrowser(
+                modifierFlags: [.command, .shift],
+                defaults: defaults
+            )
+        )
+    }
 }
 
 final class TerminalOpenURLTargetResolutionTests: XCTestCase {