Repository navigation
Add sidebar status and edge fade settings #6763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 15 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
0719fca
Add sidebar status and scrim style settings
austinywang a8b3fde
Use lifecycle state for sidebar status dots
austinywang ebd592f
Refresh Swift file length budget
austinywang 3c7b523
Avoid repeated sidebar lifecycle scans
austinywang 5699590
Fix sidebar status dot refresh and subtitles
austinywang db4c047
Address sidebar status review feedback
austinywang 2487f73
Fix sidebar schema localization
austinywang 1d323a7
Merge remote-tracking branch 'origin/main' into issue-6760-sidebar-ta…
austinywang 0e1d61b
Split sidebar status indicator priority
austinywang 9ecbe11
Fix Korean sidebar schema copy
austinywang ff1f8a5
Respect live push rate limit env in tests
austinywang 2a963fa
Fix sidebar status dot subtitle replacement
austinywang cbcd8cd
Preserve sidebar provider subtitles in dot mode
austinywang 34a0bbb
Separate sidebar status subtitles from provider metadata
austinywang 6f6b2a8
Address sidebar status review feedback
austinywang 8af7bef
Prioritize needs-input sidebar status dots
austinywang 55291c8
Keep generic sidebar notifications visible
austinywang e7a4735
Keep status dot accessibility current
austinywang f1eeda0
Keep sidebar enum mapping local
austinywang b885540
Surface status dot setting in Settings
austinywang 702a45a
Localize status dot setting across app locales
austinywang 91192c3
Complete sidebar settings localization
austinywang 9fe3eba
Avoid Foundation dependency in attention sidebar
austinywang 7efd987
Use structured sidebar agent status text
austinywang 7417463
Pair sidebar agent status text with lifecycle
austinywang 41f38f1
Keep needs-input rows in attention queue
austinywang 0f7ebfd
Merge remote-tracking branch 'origin/main' into issue-6760-sidebar-ta…
austinywang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
Packages/macOS/CmuxSettings/Sources/CmuxSettings/Values/SidebarScrollEdgeFadeStyle.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import Foundation | ||
|
|
||
| /// Strength of the tab-list scroll-edge fade mask in the left sidebar. | ||
| public enum SidebarScrollEdgeFadeStyle: String, CaseIterable, Sendable, SettingCodable { | ||
| /// The default fade height and opacity ramp. | ||
| case full | ||
|
|
||
| /// A shorter, lighter fade that keeps more row content visible near edges. | ||
| case subtle | ||
|
|
||
| /// No top or bottom scroll-edge fade. | ||
| case off | ||
| } |
10 changes: 10 additions & 0 deletions
10
Packages/macOS/CmuxSettings/Sources/CmuxSettings/Values/SidebarWorkspaceStatusStyle.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import Foundation | ||
|
|
||
| /// How extension-sidebar workspace rows present their agent status. | ||
| public enum SidebarWorkspaceStatusStyle: String, CaseIterable, Sendable, SettingCodable { | ||
| /// The default presentation: render the status sentence below the title. | ||
| case sentence | ||
|
|
||
| /// Compact presentation: render a status dot on the title line. | ||
| case dot | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.