Repository navigation
Fix remote SSH workspace cwd tracking #6747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7991602
Add remote cwd relay regression tests
austinywang f6650f7
Report remote shell cwd through relay
austinywang 53cddc1
Address remote cwd PR feedback
austinywang da8cf66
Address remote cwd review feedback
austinywang da3b3c7
Avoid remote cwd config hook scans
austinywang 8af450d
Fix remote cwd test compile
austinywang af708de
Make remote notification hook root explicit
austinywang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
...ket/Sources/CmuxControlSocket/Coordinator/Surface/ControlSurfaceReportPWDResolution.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| public import Foundation | ||
|
|
||
| /// The outcome of `surface.report_pwd`, preserving the report commands' | ||
| /// distinct failures and recorded identity. | ||
| /// | ||
| /// The coordinator validates the params (workspace required, surface-if-present | ||
| /// must parse, path required) and mints refs; every case echoes the workspace id | ||
| /// plus the requested-or-resolved surface id and the path. The app records the | ||
| /// current working directory against the resolved surface and returns this. | ||
| public enum ControlSurfaceReportPWDResolution: Sendable, Equatable { | ||
| /// The workspace did not resolve (`not_found` / "Workspace not found", | ||
| /// `data` echoes the workspace + requested surface). | ||
| case workspaceNotFound | ||
| /// The surface did not resolve (`not_found` / "Surface not found", `data` | ||
| /// echoes the workspace + requested surface). | ||
| case surfaceNotFound | ||
| /// The workspace is a remote workspace with no surfaces yet, so the path was | ||
| /// remembered (`ok` with `pending: true`, echoing the requested surface). | ||
| case pending | ||
| /// The path was recorded. Carries the resolved surface id (the `.ok` payload | ||
| /// echoes the resolved surface, not the requested one). | ||
| case recorded(surfaceID: UUID) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"directory"and"cwd"as undocumented aliases for the path key. No shell integration sends either of these keys — all three shells always use"path"— and theControlSurfaceContextprotocol doc only mentionspath. Accepting three different keys without documenting them creates an invisible surface area in the API; if the intent is deliberate forward-compatibility, a comment explaining the aliases would prevent future readers from pruning them as dead code.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!