Skip to content

ios: fix broken Release archive blocking all TestFlight builds #6488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawrencecchen merged 2 commits into from
Jun 20, 2026
Merged

ios: fix broken Release archive blocking all TestFlight builds #6488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9cdced
ios: fix broken Release archive (DEBUG-only WorkspaceListLayoutPrevie…
lawrencecchen Jun 20, 2026
9695921
ci: refresh Swift file-length budget for CMUXMobileRootView (+gate he…
lawrencecchen Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/swift-file-length-budget.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,8 @@
561 cmuxTests/GhosttyConfigPathResolverTests.swift
560 cmuxTests/CLISSHPTYResizeInputTests.swift
558 Packages/macOS/CmuxGit/Sources/CmuxGit/Parsing/GitMetadataService+Config.swift
555 Sources/Panels/BrowserAutomation.swift
551 Packages/macOS/CmuxSettingsUI/Sources/CmuxSettingsUI/Sections/BrowserSection.swift
549 Sources/Panels/BrowserAutomation.swift
541 Packages/macOS/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/Pane/ControlCommandCoordinator+Pane.swift
540 Packages/macOS/CmuxWorkspaces/Sources/CmuxWorkspaces/Coordinators/WorkspaceReorderCoordinator.swift
539 CLI/CMUXCLI+Themes.swift
Expand Down Expand Up @@ -221,5 +221,6 @@
505 cmuxUITests/DisplayResolutionRegressionUITests.swift
504 Packages/macOS/CmuxControlSocket/Tests/CmuxControlSocketTests/ControlCommandContextTestStubs.swift
504 cmuxTests/TerminalNotificationSocketActionTests.swift
503 Packages/iOS/CmuxMobileShellUI/Sources/CmuxMobileShellUI/CMUXMobileRootView.swift
503 Sources/Settings/ConfigSource.swift
502 Sources/CmuxEventPublishing.swift
14 changes: 13 additions & 1 deletion Packages/iOS/CmuxMobileShellUI/Sources/CmuxMobileShellUI/CMUXMobileRootView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,18 @@ struct CMUXMobileRootView: View {
#endif
}

// `WorkspaceListLayoutPreviewView` is `#if DEBUG`-only (a simulator
// screenshot fixture), so referencing it directly in `rootContent` breaks the
// Release archive ("cannot find ... in scope"). Gate the reference here, the
// same way `terminalLayoutPreview` does, so Release compiles to `EmptyView`.
@ViewBuilder private var workspaceListLayoutPreview: some View {
#if os(iOS) && DEBUG
WorkspaceListLayoutPreviewView()
#else
EmptyView()
#endif
}

var body: some View {
rootContent
.sheet(isPresented: addDeviceSheetBinding) {
Expand Down Expand Up @@ -167,7 +179,7 @@ struct CMUXMobileRootView: View {
if shouldShowTerminalLayoutPreview {
terminalLayoutPreview
} else if shouldShowWorkspaceListLayoutPreview {
WorkspaceListLayoutPreviewView()
workspaceListLayoutPreview
} else if shouldShowRestoringSession {
RestoringSessionView()
} else if !isAuthenticated {
Expand Down
Loading