Skip to content

Add 'Flash Focused Panel' to command palette - #638

Merged
lawrencecchen merged 1 commit into
mainfrom
issue-633-trigger-flash-v2
Feb 27, 2026
Merged

lawrencecchen merged 1 commit into
mainfrom
issue-633-trigger-flash-v2

Conversation

@lawrencecchen

Copy link
Copy Markdown
Contributor

Summary

  • Adds "Flash Focused Panel" as a command palette entry (Cmd+Shift+P → type "flash")
  • Wired to the same triggerFocusFlash() that Cmd+Shift+H uses
  • Shortcut hint reads from KeyboardShortcutSettings (stays in sync with custom bindings)

Closes #633

Test plan

  • Cmd+Shift+P → type "flash" → "Flash Focused Panel" appears with ⌘⇧H hint
  • Selecting it flashes the accent-color border on the focused panel
  • Remapping Cmd+Shift+H in Settings updates the palette hint

Registers palette.triggerFlash wired to triggerFocusFlash() (same as
Cmd+Shift+H). Shortcut hint reads from KeyboardShortcutSettings so it
stays in sync with custom bindings.

Closes #633
@vercel

vercel Bot commented Feb 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmux Building Building Preview, Comment Feb 27, 2026 10:43am

@lawrencecchen
lawrencecchen merged commit 23d140a into main Feb 27, 2026
5 of 7 checks passed
@coderabbitai

coderabbitai Bot commented Feb 27, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@lawrencecchen has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 26 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 5a763a8 and 346a442.

📒 Files selected for processing (1)
  • Sources/ContentView.swift
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch issue-633-trigger-flash-v2

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Added "Flash Focused Panel" to the command palette (Cmd+Shift+P), making the existing focus flash feature discoverable. The implementation correctly wires the command to tabManager.triggerFocusFlash() (the same function triggered by Cmd+Shift+H) and dynamically displays the keyboard shortcut hint by reading from KeyboardShortcutSettings, ensuring the hint stays synchronized with custom key bindings.

  • Added command palette entry with keywords: "flash", "highlight", "focus", "panel"
  • Mapped palette.triggerFlash to KeyboardShortcutSettings.Action.triggerFlash for dynamic shortcut hint
  • Registered command handler to call tabManager.triggerFocusFlash()
  • Implementation follows existing patterns for other commands with dynamic shortcuts

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Simple feature addition that follows established patterns, no breaking changes or edge cases. The implementation correctly integrates with existing systems (TabManager, KeyboardShortcutSettings, command palette) and requires only three small, consistent additions to ContentView.swift
  • No files require special attention

Important Files Changed

Filename Overview
Sources/ContentView.swift Added "Flash Focused Panel" command to command palette with dynamic keyboard shortcut hint, following existing patterns

Last reviewed commit: 346a442

0xble added a commit to 0xble/cmux that referenced this pull request Mar 7, 2026
bn-l pushed a commit to bn-l/cmux that referenced this pull request Apr 3, 2026
Registers palette.triggerFlash wired to triggerFocusFlash() (same as
Cmd+Shift+H). Shortcut hint reads from KeyboardShortcutSettings so it
stays in sync with custom bindings.

Closes manaflow-ai#633

This branch was successfully deployed

1 active deployment
Preview — 346a442c Deployed Feb 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add trigger flash feedback in command palette

1 participant