Repository navigation
Add zoom/maximize focused pane in splits - #634
Conversation
Cmd+Shift+Enter toggles zoom on the focused pane, expanding it to fill the workspace. Splitting or creating new tabs auto-unzooms. Zoom state shown as icon in sidebar tab. Includes bonsplit zoom toggle support. Closes #136
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryImplemented pane zoom/maximize functionality for split terminal layouts.
The implementation follows existing patterns in the codebase and integrates cleanly with the BonsplitController API. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant AppDelegate
participant TabManager
participant Workspace
participant BonsplitController
Note over User: Cmd+Shift+Enter pressed
User->>AppDelegate: Key event
AppDelegate->>AppDelegate: matchShortcut(toggleSplitZoom)
AppDelegate->>TabManager: toggleFocusedSplitZoom()
TabManager->>Workspace: toggleSplitZoom(panelId)
Workspace->>Workspace: paneId(forPanelId)
Workspace->>BonsplitController: togglePaneZoom(inPane)
BonsplitController-->>Workspace: Bool (success)
alt Zoom succeeded
Workspace->>Workspace: focusPanel(panelId)
Workspace-->>TabManager: true
TabManager-->>AppDelegate: true
else Zoom failed
Workspace-->>TabManager: false
TabManager-->>AppDelegate: false
end
Note over User: Auto-unzoom on split/tab creation
User->>AppDelegate: Cmd+D (split) or Cmd+T (new tab)
AppDelegate->>TabManager: createSplit() or newSurface()
TabManager->>Workspace: clearSplitZoom()
Workspace->>BonsplitController: clearPaneZoom()
BonsplitController-->>Workspace: Bool
TabManager->>TabManager: Create split/surface
Last reviewed commit: 20cb164 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 20cb164989
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| appearance: appearance | ||
| ) | ||
| self.bonsplitController = BonsplitController(configuration: config) | ||
| bonsplitController.contextMenuShortcuts = Self.buildContextMenuShortcuts() |
There was a problem hiding this comment.
Refresh context-menu shortcuts after settings updates
contextMenuShortcuts is initialized once per workspace, but shortcut values are user-editable at runtime; after changing toggleSplitZoom (or the other mapped actions) in Settings, existing workspaces keep the old context-menu key equivalents because this dictionary is never rebuilt. That leaves the UI out of sync with the active shortcuts until the workspace is recreated or the app restarts, so this should be refreshed alongside the existing shortcut-change observers.
Useful? React with 👍 / 👎.
Cmd+Shift+Enter toggles zoom on the focused pane, expanding it to fill the workspace. Splitting or creating new tabs auto-unzooms. Zoom state shown as icon in sidebar tab. Includes bonsplit zoom toggle support. Closes manaflow-ai#136
Summary
Closes #136
Test plan