Repository navigation
Fix workflow-guard-tests: expect Warp-pinned release signing runner (#6264 follow-up) - #6265
Conversation
…6264 follow-up) #6264 pinned release.yml build-sign-notarize to warp-macos-26-arm64-6x (the self-hosted minis lack the signing chain). This guard still asserted the old vars.MACOS_RUNNER_26 indirection string, so workflow-guard-tests failed on main and every PR after #6264 merged. Update the expected needle to the pinned Warp runner. nightly.yml is intentionally not covered by this guard; the self-hosted guard already accepts the warp-macos-NN-arm64 label.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CI release lane test in ChangesRunner Assertion Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
#6264 pinned the release signing job to
warp-macos-26-arm64-6x, buttest_ci_release_sdk_lane.shstill asserted the oldvars.MACOS_RUNNER_26 || ...string, soworkflow-guard-tests(required) now fails on main and every open PR. Update the guard's expectedruns-onforbuild-sign-notarizeto the pinned Warp runner. Guards verified passing locally.🤖 Generated with Claude Code
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Note
Low Risk
Test-only change to CI guard strings; no runtime, auth, or release workflow behavior is modified.
Overview
Fixes failing
workflow-guard-testsafter #6264 pinned release signing to Warp: the guard forbuild-sign-notarizeintests/test_ci_release_sdk_lane.shstill required the previousruns-on: ${{ vars.MACOS_RUNNER_26 || 'warp-macos-26-arm64-6x' }}string.The assertion now expects
runs-on: warp-macos-26-arm64-6xonly, with an updated failure message documenting why signing stays pinned (self-hosted minis lack the Developer-ID/WWDR chain). No workflow YAML changes in this PR—test expectations only.Reviewed by Cursor Bugbot for commit 437934b. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Fix workflow guard by updating
tests/test_ci_release_sdk_lane.shto expect the pinned Warp macOS runner for release signing. Thebuild-sign-notarizejob now assertsruns-on: warp-macos-26-arm64-6x, matching #6264 and restoring greenworkflow-guard-testson main and PRs.Written for commit 437934b. Summary will update on new commits.
Summary by CodeRabbit