Skip to content

Fix workflow-guard-tests: expect Warp-pinned release signing runner (#6264 follow-up) - #6265

Merged
lawrencecchen merged 1 commit into
mainfrom
fix-ci-sdk-lane-guard
Jun 16, 2026
Merged

lawrencecchen merged 1 commit into
mainfrom
fix-ci-sdk-lane-guard

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Jun 16, 2026 •

Copy link
Copy Markdown
Contributor

#6264 pinned the release signing job to warp-macos-26-arm64-6x, but test_ci_release_sdk_lane.sh still asserted the old vars.MACOS_RUNNER_26 || ... string, so workflow-guard-tests (required) now fails on main and every open PR. Update the guard's expected runs-on for build-sign-notarize to the pinned Warp runner. Guards verified passing locally.

🤖 Generated with Claude Code


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.


Note

Low Risk
Test-only change to CI guard strings; no runtime, auth, or release workflow behavior is modified.

Overview
Fixes failing workflow-guard-tests after #6264 pinned release signing to Warp: the guard for build-sign-notarize in tests/test_ci_release_sdk_lane.sh still required the previous runs-on: ${{ vars.MACOS_RUNNER_26 || 'warp-macos-26-arm64-6x' }} string.

The assertion now expects runs-on: warp-macos-26-arm64-6x only, with an updated failure message documenting why signing stays pinned (self-hosted minis lack the Developer-ID/WWDR chain). No workflow YAML changes in this PR—test expectations only.

Reviewed by Cursor Bugbot for commit 437934b. Bugbot is set up for automated code reviews on this repo. Configure here.


Summary by cubic

Fix workflow guard by updating tests/test_ci_release_sdk_lane.sh to expect the pinned Warp macOS runner for release signing. The build-sign-notarize job now asserts runs-on: warp-macos-26-arm64-6x, matching #6264 and restoring green workflow-guard-tests on main and PRs.

Written for commit 437934b. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Tests
    • Updated CI/CD release lane assertions to ensure the build-sign-notarize job runs on the correct infrastructure configuration.

…6264 follow-up)

#6264 pinned release.yml build-sign-notarize to warp-macos-26-arm64-6x (the
self-hosted minis lack the signing chain). This guard still asserted the old
vars.MACOS_RUNNER_26 indirection string, so workflow-guard-tests failed on main
and every PR after #6264 merged. Update the expected needle to the pinned Warp
runner. nightly.yml is intentionally not covered by this guard; the self-hosted
guard already accepts the warp-macos-NN-arm64 label.
@vercel

vercel Bot commented Jun 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmux Ready Ready Preview, Comment Jun 16, 2026 9:34pm
cmux-staging Building Building Preview, Comment Jun 16, 2026 9:34pm

@coderabbitai

coderabbitai Bot commented Jun 16, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 16ea11cd-5c67-4d21-9544-9ee7db04989a

📥 Commits

Reviewing files that changed from the base of the PR and between 38cdb93 and 437934b.

📒 Files selected for processing (1)
  • tests/test_ci_release_sdk_lane.sh

📝 Walkthrough

Walkthrough

The CI release lane test in tests/test_ci_release_sdk_lane.sh is updated to assert that the build-sign-notarize job in release.yml uses the pinned warp-macos-26-arm64-6x runner label directly, replacing the prior expectation of the vars.MACOS_RUNNER_26 || warp-macos-26-arm64-6x expression.

Changes

Runner Assertion Update

Layer / File(s) Summary
Update build-sign-notarize runner assertion
tests/test_ci_release_sdk_lane.sh
The require_job_contains check now expects the literal runs-on: warp-macos-26-arm64-6x runner label and updates the assertion message from "building on macOS 26" to "sign+notarize on macOS 26 Warp runner".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • manaflow-ai/cmux#4926: Directly changed the release.yml build-sign-notarize job runner back to the pinned WarpBuild label that this PR's test now asserts.
  • manaflow-ai/cmux#4984: Modified macOS runner selection logic for paid release workflows in release.yml, including the runner variable used by the build-sign-notarize job.
  • manaflow-ai/cmux#5022: Adjusted the build-sign-notarize job's runs-on runner selection between a variable and a pinned label, the same behavior this test assertion tracks.

Poem

🐇 A runner once hid behind a var's guise,
Its label obscured from these bright testing eyes.
Now pinned and declared in the plainest of ways,
warp-macos-26-arm64-6x gets all of the praise!
No more expressions—just one honest name,
And the bunny hops onward, CI test reclaimed. 🎉

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-ci-sdk-lane-guard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lawrencecchen
lawrencecchen merged commit 565a4d6 into main Jun 16, 2026
16 of 20 checks passed
@greptile-apps

greptile-apps Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This follow-up to #6264 updates the workflow-guard-tests assertion in test_ci_release_sdk_lane.sh to match the pinned Warp runner string that was written into release.yml's build-sign-notarize job.

  • The expected runs-on string is changed from ${{ vars.MACOS_RUNNER_26 || 'warp-macos-26-arm64-6x' }} to the literal warp-macos-26-arm64-6x, matching the workflow exactly.
  • The failure message is improved to document the reason for the pin (self-hosted minis lack the Developer-ID/WWDR signing chain).

Confidence Score: 5/5

Safe to merge — the test assertion now matches the literal runner string in the workflow file.

The change is a single-line string update in a guard test. The new expected value warp-macos-26-arm64-6x matches exactly what release.yml's build-sign-notarize job declares after #6264. No logic is altered, no production code is touched, and the improved failure message adds useful context about why the runner is pinned.

No files require special attention.

Important Files Changed

Filename Overview
tests/test_ci_release_sdk_lane.sh Updates the build-sign-notarize runner assertion to the pinned warp-macos-26-arm64-6x string; verified to match the actual value in release.yml.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[test_ci_release_sdk_lane.sh] -->|reads| B[.github/workflows/release.yml]
    A -->|reads| C[.github/workflows/ci.yml]
    B --> D{build-sign-notarize\nruns-on}
    D -->|before #6264| E["${{ vars.MACOS_RUNNER_26 || 'warp-macos-26-arm64-6x' }}"]
    D -->|after #6264| F["warp-macos-26-arm64-6x (pinned)"]
    F -->|this PR: guard now expects| G[Assertion passes ✅]
    E -->|old guard expected this| H[Assertion fails ❌]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[test_ci_release_sdk_lane.sh] -->|reads| B[.github/workflows/release.yml]
    A -->|reads| C[.github/workflows/ci.yml]
    B --> D{build-sign-notarize\nruns-on}
    D -->|before #6264| E["${{ vars.MACOS_RUNNER_26 || 'warp-macos-26-arm64-6x' }}"]
    D -->|after #6264| F["warp-macos-26-arm64-6x (pinned)"]
    F -->|this PR: guard now expects| G[Assertion passes ✅]
    E -->|old guard expected this| H[Assertion fails ❌]
Loading

Reviews (1): Last reviewed commit: "test_ci_release_sdk_lane: expect Warp-pi..." | Re-trigger Greptile

This branch was successfully deployed

1 active deployment
Preview – cmux — 437934b0 Deployed Jun 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant