Skip to content

Remove compact workspace row tap gestures #6124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azooz2003-bit merged 1 commit into from
Jun 14, 2026
+5 −8
Merged

Remove compact workspace row tap gestures #6124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Packages/CmuxMobileShellUI/Sources/CmuxMobileShellUI/WorkspaceGroupHeaderRow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,6 @@ struct WorkspaceGroupHeaderRow: View {
NavigationLink(value: group.anchorWorkspaceID) {
nameLabel
}
.simultaneousGesture(TapGesture().onEnded {
selectWorkspace(group.anchorWorkspaceID)
})
case .sidebar:
Button {
selectWorkspace(group.anchorWorkspaceID)
Expand Down
3 changes: 0 additions & 3 deletions Packages/CmuxMobileShellUI/Sources/CmuxMobileShellUI/WorkspaceNavigationRow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,6 @@ struct WorkspaceNavigationRow: View {
NavigationLink(value: workspace.id) {
rowLabel
}
.simultaneousGesture(TapGesture().onEnded {
selectWorkspace(workspace.id)
})
case .sidebar:
Button {
selectWorkspace(workspace.id)
Expand Down
7 changes: 5 additions & 2 deletions Packages/CmuxMobileShellUI/Sources/CmuxMobileShellUI/WorkspaceShellView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,11 @@ struct WorkspaceShellView: View {
autoOpenSelectedWorkspaceForSoakIfNeeded()
}
.onChange(of: compactNavigationPath) { _, path in
guard let selectedWorkspaceID = path.last,
store.selectedWorkspaceID != selectedWorkspaceID else {
guard let selectedWorkspaceID = path.last else {
return
}
pendingCompactCreateNavigationWorkspaceIDs = nil
guard store.selectedWorkspaceID != selectedWorkspaceID else {
return
}
store.selectedWorkspaceID = selectedWorkspaceID
Expand Down
Loading