Repository navigation
CI: refresh Swift file-length budget for files grown by merged PR 5726 - #6023
azooz2003-bit wants to merge 1 commit into
Conversation
#5726 grew Sources/TerminalNotificationStore.swift to 2623 lines (budget 2527) and Sources/Feed/FeedCoordinator.swift to 1255 (budget 1239) without refreshing .github/swift-file-length-budget.tsv, so workflow-guard-tests fails on main and on every PR branched from it. Accept the already-merged growth as known debt; no source changes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by #6020, which restored the budget properly by extracting NotificationSoundSettings. Closing. |
workflow-guard-tests is failing on main and on every PR branched from it: #5726 grew
Sources/TerminalNotificationStore.swiftto 2623 lines (budget 2527) andSources/Feed/FeedCoordinator.swiftto 1255 (budget 1239) without refreshing.github/swift-file-length-budget.tsv.This refreshes exactly those two entries to the already-merged line counts (accepting the landed growth as known debt, per the guard's own guidance). Metadata-only, no source changes, no runtime behavior change. Verified locally:
python3 scripts/swift_file_length_budget.py --budget .github/swift-file-length-budget.tsvpasses.Unblocks current PRs hitting this on unrelated diffs, e.g. #6019 and #6021.
🤖 Generated with Claude Code
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Summary by cubic
Refreshed the Swift file-length budget to match merged changes, restoring workflow-guard-tests on main and PRs. Updated
.github/swift-file-length-budget.tsvforSources/TerminalNotificationStore.swiftto 2623 lines andSources/Feed/FeedCoordinator.swiftto 1255; no source or runtime changes.Written for commit 72bf922. Summary will update on new commits.