Skip to content

CI: refresh Swift file-length budget for files grown by merged PR 5726 - #6023

Closed
azooz2003-bit wants to merge 1 commit into
mainfrom
fix-swift-length-budget
Closed

azooz2003-bit wants to merge 1 commit into
mainfrom
fix-swift-length-budget

Conversation

@azooz2003-bit

@azooz2003-bit azooz2003-bit commented Jun 12, 2026 •

Copy link
Copy Markdown
Collaborator

workflow-guard-tests is failing on main and on every PR branched from it: #5726 grew Sources/TerminalNotificationStore.swift to 2623 lines (budget 2527) and Sources/Feed/FeedCoordinator.swift to 1255 (budget 1239) without refreshing .github/swift-file-length-budget.tsv.

This refreshes exactly those two entries to the already-merged line counts (accepting the landed growth as known debt, per the guard's own guidance). Metadata-only, no source changes, no runtime behavior change. Verified locally: python3 scripts/swift_file_length_budget.py --budget .github/swift-file-length-budget.tsv passes.

Unblocks current PRs hitting this on unrelated diffs, e.g. #6019 and #6021.

🤖 Generated with Claude Code


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.


Summary by cubic

Refreshed the Swift file-length budget to match merged changes, restoring workflow-guard-tests on main and PRs. Updated .github/swift-file-length-budget.tsv for Sources/TerminalNotificationStore.swift to 2623 lines and Sources/Feed/FeedCoordinator.swift to 1255; no source or runtime changes.

Written for commit 72bf922. Summary will update on new commits.

Review in cubic

#5726 grew
Sources/TerminalNotificationStore.swift to 2623 lines (budget 2527) and
Sources/Feed/FeedCoordinator.swift to 1255 (budget 1239) without refreshing
.github/swift-file-length-budget.tsv, so workflow-guard-tests fails on main
and on every PR branched from it. Accept the already-merged growth as known
debt; no source changes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jun 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmux Ready Ready Preview, Comment Jun 13, 2026 12:15am
cmux-staging Building Building Preview, Comment Jun 13, 2026 12:15am

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • .github/swift-file-length-budget.tsv is excluded by !**/*.tsv

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 59ceaf3f-dca3-4890-af42-f597098910e3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-swift-length-budget

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@azooz2003-bit

Copy link
Copy Markdown
Collaborator Author

Superseded by #6020, which restored the budget properly by extracting NotificationSoundSettings. Closing.

@azooz2003-bit
azooz2003-bit deleted the fix-swift-length-budget branch June 13, 2026 00:20

This branch was successfully deployed

1 active deployment
Preview – cmux — 72bf9226 Deployed Jun 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant