Skip to content

Scope Biome checks to maintained JS sources - #6008

Merged
austinywang merged 2 commits into
mainfrom
issue-5980-scope-biome
Jun 13, 2026
Merged

austinywang merged 2 commits into
mainfrom
issue-5980-scope-biome

Conversation

@austinywang

@austinywang austinywang commented Jun 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add a root biome.json pinned to the Biome 2.5.0 schema.
  • Pin @biomejs/biome@2.5.0 in the root package and add bun run biome:check.
  • Scope biome check . to maintained web/JS/TS source paths and force-ignore generated bundles, build outputs, vendored trees, and review-tool metadata.
  • Document the intended command in CONTRIBUTING.md and leave CI unwired while existing source lint diagnostics remain.

Closes #5980

Verification

Before config, run locally before making changes:

NO_COLOR=1 npx -y @biomejs/biome@2.5.0 check .
Checked 1293 files in 2s. No fixes applied.
Found 24948 errors.
Found 25038 warnings.
Found 1565 infos.
Diagnostics not shown: 51531.

The first diagnostics were .greptile/config.json, .greptile/files.json, asset catalog JSON, vendor/bonsplit, and package metadata. A verbose baseline listed 871 generated/vendor/tooling paths, including .greptile/, GhosttyKit cache artifacts, Rust target, Swift .build, bundled agent-session assets, and 726 markdown-viewer bundle chunks.

After config:

bun run biome:check
Checked 315 files in 245ms. No fixes applied.
Found 69 errors.
Found 149 warnings.
Found 10 infos.
Diagnostics not shown: 208.

JSON reporter diagnostic paths after config:

diagnostics_with_paths=228
scripts=13
feed_tui=2
web=91
webviews=122
generated_vendor_tool_metadata_diagnostics=0

No app build was run; this is a repo tooling/config change only.


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.


Summary by cubic

Scopes Biome linting to maintained JS/TS sources and ignores generated, vendor, and build outputs to cut noise and speed up checks. Adds root biome.json, pins @biomejs/biome@2.5.0, introduces biome:check, removes a redundant ignore, and updates CONTRIBUTING.md; formatting/import sorting stay disabled and CI is not wired yet — closes #5980.

Written for commit aeaa1b8. Summary will update on new commits.

Review in cubic

@vercel

vercel Bot commented Jun 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmux Canceled Canceled Jun 12, 2026 10:14pm
cmux-staging Building Building Preview, Comment Jun 12, 2026 10:14pm

@coderabbitai

coderabbitai Bot commented Jun 12, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@austinywang, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 1 minute and 42 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9481a4c2-667d-470d-a68c-261e99bafa9a

📥 Commits

Reviewing files that changed from the base of the PR and between aeb8847 and aeaa1b8.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • CONTRIBUTING.md
  • biome.json
  • package.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-5980-scope-biome

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security

socket-security Bot commented Jun 12, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​biomejs/​biome@​2.5.0100100100100100

View full report

@greptile-apps

greptile-apps Bot commented Jun 12, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR introduces Biome 2.5.0 as a JS/TS linting tool for the repository, scoped to maintained source paths and properly configured to exclude generated bundles, build outputs, vendored trees, and review-tool metadata. CI is intentionally left unwired until the remaining source diagnostics are resolved.

  • biome.json: New root config pinned to the 2.5.0 schema; uses includes with !/!! patterns to restrict linting to scripts/, web/, webviews/, Resources/feed-tui/, and a handful of root config files, while force-ignoring all generated build artifacts and node_modules.
  • package.json / bun.lock: Adds @biomejs/biome@2.5.0 as a pinned dev dependency and exposes a biome:check script.
  • CONTRIBUTING.md: Documents bun run biome:check with an explicit note not to wire it into required CI until existing diagnostics are cleared.

Confidence Score: 5/5

Tooling-only change with no production code modifications; safe to merge.

All changes are confined to dev tooling configuration: a new biome.json, a lockfile update, a devDependency addition, and a documentation update. No application code, build pipeline, or CI configuration is modified. The PR author verified the scoping locally and provided before/after diagnostic counts confirming zero generated-or-vendor-path hits after the config. The explicit note in CONTRIBUTING.md to defer required CI wiring is the appropriate guardrail given remaining diagnostics.

No files require special attention.

Important Files Changed

Filename Overview
biome.json New root Biome config; file scoping via includes/excludes is well-structured and verified locally; formatter and assist are disabled; linter enabled with recommended preset.
package.json Adds @biomejs/biome@2.5.0 as a pinned devDependency and a biome:check script; straightforward change with no side effects.
bun.lock Lockfile updated to add @biomejs/biome@2.5.0 and all optional platform-specific CLI binaries; generated file, no manual concerns.
CONTRIBUTING.md Documents the biome:check command and explicitly warns against wiring it into required CI until diagnostics are resolved; accurate and well-scoped.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["bun run biome:check\n(biome check .)"] --> B{biome.json\nincludes list}
    B --> C["✅ Included\nbiome.json, package.json\nscripts/**/*.{js,mjs,cjs,ts,tsx,json,jsonc}\nweb/**\nwebviews/**\nResources/feed-tui/**"]
    B --> D["❌ ! Excluded from includes\n.greptile, skills, vendor\nghostty, web/db/migrations"]
    B --> E["🚫 !! Force-ignored\nGhosttyKit.xcframework\nNative/**/target\nPackages/**/.build\nResources/agent-session-*\nResources/markdown-viewer\nweb/.next, web/.pagefind-site\nweb/.vercel, web/build\nweb/coverage, web/dist\nweb/out, web/public/pagefind\nwebviews/build, webviews/coverage\nwebviews/dist, **/node_modules"]
    C --> F{File type\nknown to Biome?}
    F -- No --> G["⏭ Skipped\n(ignoreUnknown: true)"]
    F -- Yes --> H["🔍 Linted\n(recommended rules)\nFormatter: off\nAssist: off"]
Loading

Reviews (2): Last reviewed commit: "chore: remove redundant biome ignore" | Re-trigger Greptile

Comment thread biome.json
@austinywang
austinywang merged commit 4bbfd57 into main Jun 13, 2026
22 checks passed
hhsw2015 pushed a commit to hhsw2015/cmux that referenced this pull request Jun 14, 2026
PRs included:
- AppDelegate decomposition: CmuxSession session-snapshot repository (manaflow-ai#6030)
- Fix Cmd+T cwd after session restore (manaflow-ai#6055)
- Speed up iOS terminal scroll rendering (manaflow-ai#6035)
- Preserve Pi sessions across workspace restore (manaflow-ai#5607)
- Scope Biome checks to maintained JS sources (manaflow-ai#6008)
- Fix manaflow-ai#5917: restore OSC 11 pane-local backgrounds (manaflow-ai#5997)
- Expose stable window title templates (manaflow-ai#6059)
- Honor macos-option-as-alt left/right
- Fix macOS 27 SF Symbol rasterization crash (manaflow-ai#5999)
- CmuxRemote* family: extract Workspace remote/cloud-VM connectivity
- Fix iOS workspace swipe-delete confirmation crash (manaflow-ai#6051)
- TabManager decomposition Wave 3+4 sub-models
- Sidebar row cleanups: branchless frame anchor
- CmuxIPCService: extract AppDelegate multi-window CLI routing
- CmuxSidebarGit: extract TabManager git-metadata + PR-polling subsystem
- CmuxTerminalCore: extract terminal core leaf

Fork-side adjustments:
- ghostty submodule: cherry-pick mouse-modifier-state fix onto our renderer-realized branch
- Workspace.swift: take theirs (upstream extracted ~7700 lines into CmuxCore.Remote/CmuxRemoteSession packages); restore fork's renameTopLevelLayoutTabContaining/closeTopLevelLayoutTabContaining + surfaceTmuxClientTTYNames + WorkspaceLayoutTab integration
- TabManager.swift: take theirs; re-add static allocatePortOrdinal()
- BrowserPanelView, RenderableSystemSymbol: keep fork's cmuxSymbolPixelSize extension on top of upstream's cmuxSymbolRasterSize
- Add CmuxWorkspaces / CMUXSessionDaemon / CmuxCommandPalette imports to TerminalController, Workspace, SessionPersistence
- Sources/Workspace+P43Stubs.swift: thin shims for SplitEqualizer, WorkspaceRemoteSessionController.PortScanKickReason, WorkspaceGroupNewWorkspacePlacementSettings (legacy types fork TC still calls; replace with package APIs in P44+)
- Sources/GhosttySurfaceSizeDeferralReason.swift: restore fork-only enum (deleted by upstream)
- Sources/StableLayout/SessionBlueprintExportAction.swift: parked debug action (depends on legacy SessionPersistenceStore, gone)
- Sources/GhosttyTerminalView.swift: stub ghostty_surface_select_cursor_line_compat (needs zig 0.15.2 xcframework rebuild)
- pbxproj: keep-both, drop stale ProcessPipeReader/SplitEqualizer/Panels/BrowserProxyEndpoint refs, fix SurfaceHibernationPolicy UUID collision
- Drop fork's WorkspaceRemoteConfiguration.swift + WorkspaceRemoteSSHBatchCommandBuilder.swift (extracted to CmuxCore package)

This branch was successfully deployed

1 active deployment
Preview – cmux — aeaa1b86 Deployed Jun 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tooling: scope Biome so it does not scan generated assets and tool metadata

1 participant