Repository navigation
Scope Biome checks to maintained JS sources - #6008
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 1 minute and 42 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Greptile SummaryThis PR introduces Biome 2.5.0 as a JS/TS linting tool for the repository, scoped to maintained source paths and properly configured to exclude generated bundles, build outputs, vendored trees, and review-tool metadata. CI is intentionally left unwired until the remaining source diagnostics are resolved.
Confidence Score: 5/5Tooling-only change with no production code modifications; safe to merge. All changes are confined to dev tooling configuration: a new biome.json, a lockfile update, a devDependency addition, and a documentation update. No application code, build pipeline, or CI configuration is modified. The PR author verified the scoping locally and provided before/after diagnostic counts confirming zero generated-or-vendor-path hits after the config. The explicit note in CONTRIBUTING.md to defer required CI wiring is the appropriate guardrail given remaining diagnostics. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["bun run biome:check\n(biome check .)"] --> B{biome.json\nincludes list}
B --> C["✅ Included\nbiome.json, package.json\nscripts/**/*.{js,mjs,cjs,ts,tsx,json,jsonc}\nweb/**\nwebviews/**\nResources/feed-tui/**"]
B --> D["❌ ! Excluded from includes\n.greptile, skills, vendor\nghostty, web/db/migrations"]
B --> E["🚫 !! Force-ignored\nGhosttyKit.xcframework\nNative/**/target\nPackages/**/.build\nResources/agent-session-*\nResources/markdown-viewer\nweb/.next, web/.pagefind-site\nweb/.vercel, web/build\nweb/coverage, web/dist\nweb/out, web/public/pagefind\nwebviews/build, webviews/coverage\nwebviews/dist, **/node_modules"]
C --> F{File type\nknown to Biome?}
F -- No --> G["⏭ Skipped\n(ignoreUnknown: true)"]
F -- Yes --> H["🔍 Linted\n(recommended rules)\nFormatter: off\nAssist: off"]
Reviews (2): Last reviewed commit: "chore: remove redundant biome ignore" | Re-trigger Greptile |
PRs included: - AppDelegate decomposition: CmuxSession session-snapshot repository (manaflow-ai#6030) - Fix Cmd+T cwd after session restore (manaflow-ai#6055) - Speed up iOS terminal scroll rendering (manaflow-ai#6035) - Preserve Pi sessions across workspace restore (manaflow-ai#5607) - Scope Biome checks to maintained JS sources (manaflow-ai#6008) - Fix manaflow-ai#5917: restore OSC 11 pane-local backgrounds (manaflow-ai#5997) - Expose stable window title templates (manaflow-ai#6059) - Honor macos-option-as-alt left/right - Fix macOS 27 SF Symbol rasterization crash (manaflow-ai#5999) - CmuxRemote* family: extract Workspace remote/cloud-VM connectivity - Fix iOS workspace swipe-delete confirmation crash (manaflow-ai#6051) - TabManager decomposition Wave 3+4 sub-models - Sidebar row cleanups: branchless frame anchor - CmuxIPCService: extract AppDelegate multi-window CLI routing - CmuxSidebarGit: extract TabManager git-metadata + PR-polling subsystem - CmuxTerminalCore: extract terminal core leaf Fork-side adjustments: - ghostty submodule: cherry-pick mouse-modifier-state fix onto our renderer-realized branch - Workspace.swift: take theirs (upstream extracted ~7700 lines into CmuxCore.Remote/CmuxRemoteSession packages); restore fork's renameTopLevelLayoutTabContaining/closeTopLevelLayoutTabContaining + surfaceTmuxClientTTYNames + WorkspaceLayoutTab integration - TabManager.swift: take theirs; re-add static allocatePortOrdinal() - BrowserPanelView, RenderableSystemSymbol: keep fork's cmuxSymbolPixelSize extension on top of upstream's cmuxSymbolRasterSize - Add CmuxWorkspaces / CMUXSessionDaemon / CmuxCommandPalette imports to TerminalController, Workspace, SessionPersistence - Sources/Workspace+P43Stubs.swift: thin shims for SplitEqualizer, WorkspaceRemoteSessionController.PortScanKickReason, WorkspaceGroupNewWorkspacePlacementSettings (legacy types fork TC still calls; replace with package APIs in P44+) - Sources/GhosttySurfaceSizeDeferralReason.swift: restore fork-only enum (deleted by upstream) - Sources/StableLayout/SessionBlueprintExportAction.swift: parked debug action (depends on legacy SessionPersistenceStore, gone) - Sources/GhosttyTerminalView.swift: stub ghostty_surface_select_cursor_line_compat (needs zig 0.15.2 xcframework rebuild) - pbxproj: keep-both, drop stale ProcessPipeReader/SplitEqualizer/Panels/BrowserProxyEndpoint refs, fix SurfaceHibernationPolicy UUID collision - Drop fork's WorkspaceRemoteConfiguration.swift + WorkspaceRemoteSSHBatchCommandBuilder.swift (extracted to CmuxCore package)
Summary
biome.jsonpinned to the Biome 2.5.0 schema.@biomejs/biome@2.5.0in the root package and addbun run biome:check.biome check .to maintained web/JS/TS source paths and force-ignore generated bundles, build outputs, vendored trees, and review-tool metadata.CONTRIBUTING.mdand leave CI unwired while existing source lint diagnostics remain.Closes #5980
Verification
Before config, run locally before making changes:
The first diagnostics were
.greptile/config.json,.greptile/files.json, asset catalog JSON,vendor/bonsplit, and package metadata. A verbose baseline listed 871 generated/vendor/tooling paths, including.greptile/, GhosttyKit cache artifacts, Rusttarget, Swift.build, bundled agent-session assets, and 726 markdown-viewer bundle chunks.After config:
JSON reporter diagnostic paths after config:
No app build was run; this is a repo tooling/config change only.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Summary by cubic
Scopes Biome linting to maintained JS/TS sources and ignores generated, vendor, and build outputs to cut noise and speed up checks. Adds root biome.json, pins
@biomejs/biome@2.5.0, introducesbiome:check, removes a redundant ignore, and updates CONTRIBUTING.md; formatting/import sorting stay disabled and CI is not wired yet — closes #5980.Written for commit aeaa1b8. Summary will update on new commits.