Skip to content

Fix status pills not rendering on workspaces created after launch #5660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
obvioussean wants to merge 1 commit into from
Closed

Fix status pills not rendering on workspaces created after launch #5660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Sources/ContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15829,6 +15829,17 @@ struct TabItemView: View, Equatable {
.onAppear {
refreshWorkspaceSnapshot(force: true)
}
// Re-read current state after the modifier chain is fully established.
// .onAppear fires synchronously during view insertion, before .onReceive
// subscriptions are live. Sidebar data (status pills, metadata, etc.) set
// by socket commands between .onAppear and subscription can be missed by
// the change-only observation publishers. This one-shot async refresh runs
// on the next main-actor tick — after .onReceive is subscribed — so it
// picks up any state that .onAppear saw as empty but that was mutated in
// the gap. The snapshot comparison no-ops when nothing changed.
.task {
refreshWorkspaceSnapshot()
}
.task(id: finderDirectoryCacheKey) {
let cache = await WorkspaceFinderDirectoryResolver.cache(for: finderDirectoryCacheKey)
guard !Task.isCancelled else { return }
Expand Down