Repository navigation
Fix #5286: surface needs-input attention for feed-routed blocking decisions #5313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b81035b
Add failing test: feed blocking decision must surface needs-input att…
austinywang d66b026
Surface needs-input attention for all feed-routed blocking decisions
austinywang 31f4bcb
Address review: restore feed attention on conclusion; resolve workspa…
austinywang e2953ad
Address review: drop racy snapshot/restore; let agent hooks own clearing
austinywang e3e40d8
Address review: log when feed attention surfacing can't resolve a wor…
austinywang 2fc4e4d
Address review: refcounted, race-free clear of feed needs-input overlay
austinywang 12c2019
Address review: don't clear shared status badge while another panel p…
austinywang 7e9a0eb
Merge remote-tracking branch 'origin/main' into issue-5286-feed-permi…
austinywang b7decdd
fix: address feed attention review feedback
austinywang b2f6d6c
fix: retain feed attention cleanup target
austinywang 5988f89
fix: resolve feed attention target off main
austinywang 5e498fc
Merge remote-tracking branch 'origin/main' into issue-5286-feed-permi…
lawrencecchen 0443082
Convert merged attention tests to Swift Testing; refresh length budget
lawrencecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.