Repository navigation
Remove terminal scrollbar workspace menu #5072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
84090a7
Remove terminal scrollbar workspace menu
lawrencecchen a5b7d74
Remove per-workspace scrollbar override
lawrencecchen 40f6634
Keep scrollbar state compatibility
lawrencecchen 8478f79
Document legacy scrollbar workspace state
lawrencecchen a79b543
Merge remote-tracking branch 'origin/main' into feat-remove-scrollbar…
lawrencecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the Workspace Settings menu is removed, users who previously hid the scrollbar for a workspace can no longer unhide it:
Workspacestill persists/restoresterminalScrollBarHidden, andGhosttyTerminalView.terminalScrollBarAllowedBySettings()still returns false when that flag is true, regardless of the global Settings toggle. In that state, turning “Show Terminal Scroll Bar” back on in Settings does not restore the scrollbar for affected/restored workspaces, so this removal needs either a migration/reset path or the per-workspace flag should stop being applied.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in the follow-up commits: the sidebar context menu no longer exposes the per-workspace control, terminal rendering no longer reads the per-workspace flag, and session snapshots no longer write or restore that flag. Existing persisted hidden flags are ignored so the global Settings toggle controls the scrollbar again.
— Claude Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified again on the rebased head a79b543: the removed context-menu path is gone, GhosttyTerminalView no longer reads Workspace.terminalScrollBarHidden, Workspace session snapshots no longer write or restore terminalScrollBarHidden, and the autosave fingerprint no longer includes it. Existing persisted hidden flags are ignored, so the global Settings toggle controls scrollbar visibility.
— Claude Code