Repository navigation
Use Blacksmith as macOS CI default #5019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
63e8f17
Use Blacksmith as macOS CI default
lawrencecchen 493d3cb
Merge remote-tracking branch 'origin/main' into feat-blacksmith-ci
lawrencecchen 56156bd
Document macOS runner capacity override
lawrencecchen deaced5
Merge remote-tracking branch 'origin/main' into feat-blacksmith-ci
lawrencecchen 81108f0
Merge remote-tracking branch 'origin/main' into feat-blacksmith-ci
lawrencecchen 1071f64
Update release SDK-lane test for Blacksmith default runners
lawrencecchen 638a8c0
Hardcode Blacksmith runners; drop MACOS_RUNNER_* override variable
lawrencecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,10 @@ | ||
| self-hosted-runner: | ||
| labels: | ||
| # Active default lives in the MACOS_RUNNER_15 / MACOS_RUNNER_26 repo | ||
| # variables; these are the literal labels referenced as fallbacks or as | ||
| # manual workflow_dispatch choices. See docs/macos-ci-runners.md. | ||
| # macOS jobs run on Blacksmith (hardcoded in the workflows). These are the | ||
| # labels referenced directly or offered as manual workflow_dispatch choices. | ||
| # See docs/macos-ci-runners.md. | ||
| - blacksmith-6vcpu-macos-15 | ||
| - blacksmith-6vcpu-macos-26 | ||
| - blacksmith-6vcpu-macos-latest | ||
| - warp-macos-15-arm64-6x | ||
| - warp-macos-26-arm64-6x | ||
| - depot-macos-latest | ||
| - depot-macos-14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,44 +1,22 @@ | ||||||
| # macOS CI runners | ||||||
|
|
||||||
| All paid macOS CI/CD jobs pick their runner from two repository variables instead of a hardcoded label: | ||||||
| All paid macOS CI/CD jobs run on Blacksmith. The runner labels are hardcoded in the workflows (git-tracked); there is no repo-variable override. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: The docs overstate runner behavior: Blacksmith is the default, but manual workflows can still run on Depot runners. Prompt for AI agents
Suggested change
|
||||||
|
|
||||||
| - `MACOS_RUNNER_15` for jobs that build the real universal Release app, including nightly, stable release, `release-build`, and the e2e/perf defaults. | ||||||
| - `MACOS_RUNNER_26` for macOS 26 compatibility coverage and jobs that do not need Zig to build the real universal Ghostty CLI helper. | ||||||
| - `blacksmith-6vcpu-macos-15` for jobs that build the universal Ghostty CLI helper (zig 0.15.2 can only cross-link the x86_64 slice against a pre-26 SDK), for the GhosttyKit framework build, for unit/UI tests, and for the nightly app build (which uses Xcode 26 on the macOS 15 host). | ||||||
| - `blacksmith-6vcpu-macos-26` for the app builds that must link the macOS 26 SDK so SDK-gated SwiftUI Liquid Glass code compiles in: stable `release` `build-sign-notarize` and the CI `release-build` SDK-validation lane. `ci-macos-compat.yml` also exercises macOS 26 with `CMUX_SKIP_ZIG_BUILD=1`. | ||||||
|
|
||||||
| Workflows reference them as `runs-on: ${{ vars.MACOS_RUNNER_15 || 'warp-macos-15-arm64-6x' }}`. If a variable is unset, the job falls back to WarpBuild, so CI is never broken by a missing variable. | ||||||
| Workflows reference these labels directly, e.g. `runs-on: blacksmith-6vcpu-macos-15`. | ||||||
|
|
||||||
| Nightly and stable release stay on macOS 15 until Zig can link the real universal Ghostty CLI helper on macOS 26. `ci-macos-compat.yml` still covers macOS 26 by setting `CMUX_SKIP_ZIG_BUILD=1`, but publishing workflows cannot use that stub because the signed artifacts must include the real helper. | ||||||
| ## Changing the runner | ||||||
|
|
||||||
| ## Switch Blacksmith <-> WarpBuild | ||||||
| To switch providers or roll back to Warp, edit the `runs-on` labels in `.github/workflows/*.yml` and open a PR. There is no variable to flip; the runner choice lives in git so every change is reviewed and recorded. | ||||||
|
|
||||||
| The switch is a repo-variable change. It takes effect on the next workflow run, with no PR or commit. | ||||||
|
|
||||||
| Use Blacksmith (default): | ||||||
|
|
||||||
| ```bash | ||||||
| gh variable set MACOS_RUNNER_15 --repo manaflow-ai/cmux -b blacksmith-6vcpu-macos-15 | ||||||
| gh variable set MACOS_RUNNER_26 --repo manaflow-ai/cmux -b blacksmith-6vcpu-macos-26 | ||||||
| ``` | ||||||
|
|
||||||
| Fall back to WarpBuild (e.g. Blacksmith macOS capacity is queuing, as happened in https://github.com/manaflow-ai/cmux/pull/4926): | ||||||
|
|
||||||
| ```bash | ||||||
| gh variable delete MACOS_RUNNER_15 --repo manaflow-ai/cmux | ||||||
| gh variable delete MACOS_RUNNER_26 --repo manaflow-ai/cmux | ||||||
| ``` | ||||||
|
|
||||||
| Deleting the variables reverts to the WarpBuild fallback baked into the workflows. You can also set them explicitly to `warp-macos-15-arm64-6x` / `warp-macos-26-arm64-6x`. | ||||||
|
|
||||||
| Check current values: | ||||||
|
|
||||||
| ```bash | ||||||
| gh variable list --repo manaflow-ai/cmux | ||||||
| ``` | ||||||
| If a new runner label is introduced, add it to `.github/actionlint.yaml` so `actionlint` recognizes it. | ||||||
|
|
||||||
| ## Manual runs | ||||||
|
|
||||||
| `perf-activation.yml` and `test-e2e.yml` keep a `runner` choice input that defaults to `auto`. `auto` (and the empty `pull_request` case for perf) follows `MACOS_RUNNER_15` then the Warp fallback, so flipping the repo variable also redirects these workflows. An explicit choice wins over the variable; both dropdowns expose `warp-macos-15-arm64-6x` / `warp-macos-26-arm64-6x` so an operator can pick Warp directly during a Blacksmith outage. `test-e2e.yml` also keeps `depot-macos-*` choices and a Depot identity guard for GUI-activation runs. | ||||||
| `perf-activation.yml` and `test-e2e.yml` keep a `runner` choice input that defaults to `auto`. `auto` (and the empty `pull_request` case for perf) resolves to the hardcoded Blacksmith default; an explicit choice wins. `test-e2e.yml` also keeps `depot-macos-*` choices and a Depot identity guard for GUI-activation runs. | ||||||
|
|
||||||
| ## Guard | ||||||
|
|
||||||
| `tests/test_ci_self_hosted_guard.sh` (run by the `workflow-guard-tests` job) asserts every paid macOS job references `vars.MACOS_RUNNER_*` or a Blacksmith/Warp label, so a job can never silently fall back to a free GitHub-hosted runner. Keep new labels in `.github/actionlint.yaml`. | ||||||
| `tests/test_ci_self_hosted_guard.sh` (run by the `workflow-guard-tests` job) asserts every paid macOS job references a Blacksmith label, so a job can never silently fall back to a free GitHub-hosted runner. `tests/test_ci_release_sdk_lane.sh` asserts the release/CI app builds use macOS 26 with a macOS-15-built helper. | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Hardcoded runner label removes the
vars.MACOS_RUNNER_15override, contradicting the PR's stated design of "Auto resolution now follows MACOS_RUNNER_15 first, then Blacksmith." The original pattern allowed operators to redirect this job by setting a repo variable if Blacksmith has queue or capacity issues; the new hardcoded label removes that flexibility entirely.Prompt for AI agents