Repository navigation
Fix Settings sign-in by using the default browser #4974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
641f1c3
test: cover external browser sign-in opener
austinywang 070ab30
fix: open settings sign-in in default browser
austinywang c92e4b9
Merge remote-tracking branch 'origin/main' into issue-3617-signin-fix
austinywang 0b3dff3
Fix auth callback defer compile error
austinywang b53968a
Fix auth sign-in test build issues
austinywang 02b19e1
Address auth sign-in review feedback
austinywang 0906d87
Handle abandoned browser sign-in attempts
austinywang 541fdf4
Fix auth sign-in timeout default argument
austinywang 6775e2c
Avoid auth timeout default isolation warning
austinywang 3cd027f
test: cover stateless idle auth callbacks
austinywang 8d84d1e
fix: reject idle stateless auth callbacks
austinywang 386039a
test: use stateful auth callbacks in sign-out races
austinywang d3a5769
fix: keep auth loading scoped to browser attempt
austinywang 844a117
Merge remote-tracking branch 'origin/main' into issue-3617-signin-fix
lawrencecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new
settings.account.error.signInTimedOutstring is only translated intoen,ja,uk, andko. The catalog already supportsar,bs,da,de,es,fr,it,km,nb,pl,pt-BR,ru,th,tr,zh-Hans, andzh-Hant— users on any of those locales will see the raw English fallback "Sign in timed out. Try again." when the timeout fires. Thesettings.account.error.missingRefreshTokenandsettings.account.error.invalidCallbackstrings added in companion PRs each carry all 20 translations; this one is the odd one out.Rule Used: Flag production user-facing text that is not fully... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!