Skip to content

Unmask right sidebar chrome E2E tests #4949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawrencecchen merged 2 commits into from
May 28, 2026
Merged

Unmask right sidebar chrome E2E tests #4949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6628abb
Unmask right sidebar chrome UI tests
lawrencecchen May 28, 2026
527aca4
Fix right sidebar chrome hit-target assertions
lawrencecchen May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions cmuxUITests/BonsplitTabDragUITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,10 @@ final class BonsplitTabDragUITests: XCTestCase {
accuracy: 0.5,
"Expected \(presentationMode.rawValue)-mode right sidebar chrome metric to stay compact. geometry=\(geometry)"
)
XCTAssertEqual(
modeBarHeight,
XCTAssertGreaterThanOrEqual(
alphaTab.frame.height,
accuracy: 2,
"Expected \(presentationMode.rawValue)-mode right sidebar mode bar to match Bonsplit pane tab height. geometry=\(geometry) alphaTab=\(alphaTab.frame)"
modeBarHeight,
"Expected \(presentationMode.rawValue)-mode Bonsplit pane tab hit target to cover the compact chrome lane. geometry=\(geometry) alphaTab=\(alphaTab.frame)"
)

if let referenceTopInset {
Expand Down
14 changes: 3 additions & 11 deletions cmuxUITests/RightSidebarChromeHeightUITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,7 @@ final class RightSidebarChromeHeightUITests: XCTestCase {
app.launchEnvironment["CMUX_UI_TEST_BONSPLIT_TAB_DRAG_PATH"] = dataPath
app.launchEnvironment["CMUX_UI_TEST_BONSPLIT_SHOW_RIGHT_SIDEBAR"] = "1"
app.launchArguments += ["-workspacePresentationMode", "minimal"]
let options = XCTExpectedFailure.Options()
options.isStrict = false
XCTExpectFailure("App activation may fail on headless CI runners", options: options) {
app.launch()
}
app.launch()
defer { app.terminate() }

if app.state == .runningBackground {
Expand Down Expand Up @@ -51,7 +47,7 @@ final class RightSidebarChromeHeightUITests: XCTestCase {
}
XCTAssertEqual(secondaryBarHeight, modeBarHeight, accuracy: 0.5, "Expected secondary bar to match the right sidebar mode bar. geometry=\(geometry)")
XCTAssertEqual(secondaryBarHeight, 28, accuracy: 0.5, "Expected right sidebar chrome to use the standard minimal-mode lane height. geometry=\(geometry)")
XCTAssertEqual(CGFloat(secondaryBarHeight), alphaTab.frame.height, accuracy: 2, "Expected secondary bar to match Bonsplit pane tab height. geometry=\(geometry) alphaTab=\(alphaTab.frame)")
XCTAssertGreaterThanOrEqual(alphaTab.frame.height, CGFloat(secondaryBarHeight), "Expected Bonsplit pane tab hit target to cover the compact chrome lane. geometry=\(geometry) alphaTab=\(alphaTab.frame)")

let controlHeightKeys = [
"rightSidebarModeControl_sessionsHeight",
Expand Down Expand Up @@ -109,11 +105,7 @@ final class RightSidebarChromeHeightUITests: XCTestCase {
"-sidebarTintHexDark", "#FF0044",
"-sidebarTintOpacity", "1.0",
]
let options = XCTExpectedFailure.Options()
options.isStrict = false
XCTExpectFailure("App activation may fail on headless CI runners", options: options) {
app.launch()
}
app.launch()
defer { app.terminate() }

if app.state == .runningBackground {
Expand Down
Loading