Repository navigation
Add David Ondrej testimonial - #4896
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughA new testimonial ( ChangesWall of Love testimonial addition
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 17 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (17 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR adds David Ondrej's X testimonial to the shared testimonials list used by the home page community section and Wall of Love, with full i18n coverage across all 20 supported locales and a
Confidence Score: 5/5Safe to merge — marketing copy and a targeted CSS fix with no app logic, auth, or API changes. All 20 locales defined in No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "Move David Ondrej testimonial after Deep..." | Re-trigger Greptile |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/messages/de.json`:
- Line 1070: Replace the raw ">" quote markers in the testimonials.davidondrej1
JSON value with HTML-escaped ">" and ensure the newline escape sequence "\n"
remains between lines; update the string currently set to "> lerne cmux\n> glaub
mir" to use "> lerne cmux\n> glaub mir" so it follows the locale-specific
testimonial pattern used by the German messages.
In `@web/messages/es.json`:
- Line 1070: The testimonial string for key "davidondrej1" uses raw '>'
characters instead of HTML-escaped quotes and must be formatted as HTML-escaped
quote lines separated by an explicit newline; update the value for davidondrej1
to replace each leading '>' with '>' and ensure the two lines are separated
by '\n' (i.e., "> aprende cmux\n> créeme") so it matches the locale's
testimonials formatting rules.
In `@web/messages/fr.json`:
- Line 1070: Replace the plain angle-bracket quote in the "davidondrej1" message
with HTML-escaped quote markers to match other locales; specifically update the
value for the "davidondrej1" key so each leading '>' becomes '>' and preserve
the explicit newline (`\n`) between lines (i.e., use "> apprends cmux\n>
crois-moi") to match the format used in de.json and es.json.
In `@web/messages/zh-TW.json`:
- Line 1070: Update the testimonial entry keyed by "davidondrej1" in the zh-TW
`testimonials` map to replace each plain ">" quote marker with the HTML-escaped
">" and ensure the quoted lines end with an explicit newline sequence ("\n")
so formatting matches other locales (see structure used in `testimonials`
entries).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 895c137a-846c-41f4-8add-5bd13dfb9eac
⛔ Files ignored due to path filters (1)
web/public/avatars/davidondrej1.jpgis excluded by!**/*.jpg
📒 Files selected for processing (21)
web/app/[locale]/testimonials.tsxweb/messages/ar.jsonweb/messages/bs.jsonweb/messages/da.jsonweb/messages/de.jsonweb/messages/en.jsonweb/messages/es.jsonweb/messages/fr.jsonweb/messages/it.jsonweb/messages/ja.jsonweb/messages/km.jsonweb/messages/ko.jsonweb/messages/no.jsonweb/messages/pl.jsonweb/messages/pt-BR.jsonweb/messages/ru.jsonweb/messages/th.jsonweb/messages/tr.jsonweb/messages/uk.jsonweb/messages/zh-CN.jsonweb/messages/zh-TW.json
| "testimonials": { | ||
| "mitchellh": "Und wieder ein libghostty-basiertes Projekt, diesmal ein macOS-Terminal mit vertikalen Tabs, besserer Organisation/Benachrichtigungen, eingebettetem/skriptfähigem Browser, speziell für Leute, die viele terminalbasierte Agenten-Workflows nutzen.", | ||
| "steipete": "Ich bin spät dran, aber cmux ist großartig. Aktuelle Aufteilung: Codex-Mac-App für Wissensarbeit, Lernen und Lesen; cmux + Codex CLI fürs Coding.", | ||
| "davidondrej1": "> lerne cmux\n> glaub mir", |
There was a problem hiding this comment.
Use HTML-escaped quote markers for the German testimonial key.
Line 1070 should use > formatting to match the required locale-specific testimonial pattern.
Proposed fix
- "davidondrej1": "> lerne cmux\n> glaub mir",
+ "davidondrej1": "> lerne cmux\n> glaub mir",As per coding guidelines, web/messages/de.json must keep testimonials.davidondrej1 as HTML-escaped quote lines using > ... with \n.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "davidondrej1": "> lerne cmux\n> glaub mir", | |
| "davidondrej1": "> lerne cmux\n> glaub mir", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@web/messages/de.json` at line 1070, Replace the raw ">" quote markers in the
testimonials.davidondrej1 JSON value with HTML-escaped ">" and ensure the
newline escape sequence "\n" remains between lines; update the string currently
set to "> lerne cmux\n> glaub mir" to use "> lerne cmux\n> glaub mir" so
it follows the locale-specific testimonial pattern used by the German messages.
| "testimonials": { | ||
| "mitchellh": "Otro proyecto basado en libghostty, esta vez un terminal macOS con pestanas verticales, mejor organizacion/notificaciones, navegador integrado/scriptable, dirigido especificamente a personas que usan muchos flujos de trabajo de agentes basados en terminal.", | ||
| "steipete": "Llego tarde, pero cmux es genial. División actual: app de Codex para Mac para trabajo de conocimiento, aprendizaje y lectura; cmux + Codex CLI para programar.", | ||
| "davidondrej1": "> aprende cmux\n> créeme", |
There was a problem hiding this comment.
Format violation: Use HTML-escaped > instead of plain >.
The referenced documentation for es.json explicitly mandates: "keep the text formatted as HTML-escaped quote lines with > ... separated by an explicit newline (\n)" with the example > aprende cmux\n> créeme.
The current implementation uses plain > characters, which violates the documented pattern.
🔧 Proposed fix to match documented format
- "davidondrej1": "> aprende cmux\n> créeme",
+ "davidondrej1": "> aprende cmux\n> créeme",As per coding guidelines: Referenced documentation web/messages/es.json states "use the same stable key (davidondrej1) in the locale's testimonials map and keep the text formatted as HTML-escaped quote lines with > ... separated by an explicit newline (\n)."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@web/messages/es.json` at line 1070, The testimonial string for key
"davidondrej1" uses raw '>' characters instead of HTML-escaped quotes and must
be formatted as HTML-escaped quote lines separated by an explicit newline;
update the value for davidondrej1 to replace each leading '>' with '>' and
ensure the two lines are separated by '\n' (i.e., "> aprende cmux\n>
créeme") so it matches the locale's testimonials formatting rules.
| "testimonials": { | ||
| "mitchellh": "Encore un projet base sur libghostty, cette fois un terminal macOS avec des onglets verticaux, une meilleure organisation/notifications, un navigateur integre/scriptable, specifiquement destine aux gens qui utilisent beaucoup de workflows d'agents en terminal.", | ||
| "steipete": "J'arrive tard, mais cmux est excellent. Répartition actuelle : l'app Mac Codex pour le travail de connaissance, l'apprentissage et la lecture ; cmux + Codex CLI pour coder.", | ||
| "davidondrej1": "> apprends cmux\n> crois-moi", |
There was a problem hiding this comment.
Format violation: Use HTML-escaped > instead of plain >.
The referenced documentation for shared testimonial entries mandates HTML-escaped quote formatting with > followed by newlines. The pattern shown in de.json documentation is > lerne cmux\n> glaub mir, and es.json documentation shows > aprende cmux\n> créeme.
The current implementation uses plain > characters, which is inconsistent with the documented pattern for testimonial quote formatting.
🔧 Proposed fix to match documented format
- "davidondrej1": "> apprends cmux\n> crois-moi",
+ "davidondrej1": "> apprends cmux\n> crois-moi",As per coding guidelines: Referenced documentation web/messages/de.json and web/messages/es.json both specify to "preserve the quote formatting as HTML-escaped text using > ... plus an explicit newline (\n)."
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "davidondrej1": "> apprends cmux\n> crois-moi", | |
| "davidondrej1": "> apprends cmux\n> crois-moi", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@web/messages/fr.json` at line 1070, Replace the plain angle-bracket quote in
the "davidondrej1" message with HTML-escaped quote markers to match other
locales; specifically update the value for the "davidondrej1" key so each
leading '>' becomes '>' and preserve the explicit newline (`\n`) between
lines (i.e., use "> apprends cmux\n> crois-moi") to match the format used
in de.json and es.json.
| "testimonials": { | ||
| "mitchellh": "又一個基於 libghostty 的專案，這次是一個帶垂直分頁、更好的組織/通知、內建可編寫腳本瀏覽器的 macOS 終端機，專門針對大量使用終端機 agent 工作流程的使用者。", | ||
| "steipete": "來晚了，但 cmux 很棒。目前分工：Codex Mac App 用於知識工作、學習和閱讀；cmux + Codex CLI 用於寫程式。", | ||
| "davidondrej1": "> 學 cmux\n> 相信我", |
There was a problem hiding this comment.
Use HTML-escaped > instead of plain > for quote formatting.
The testimonial text uses plain > characters, but the documented pattern requires HTML-escaped > to match other locales. As per coding guidelines, testimonial entries should preserve the quote formatting as HTML-escaped text using > ... plus an explicit newline.
🔧 Proposed fix
- "davidondrej1": "> 學 cmux\n> 相信我",
+ "davidondrej1": "> 學 cmux\n> 相信我",Based on learnings from web/messages/de.json: "keep the testimonial entry under the locale's testimonials map using a stable key (here: davidondrej1) and preserve the quote formatting as HTML-escaped text using > ... plus an explicit newline (\n)."
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "davidondrej1": "> 學 cmux\n> 相信我", | |
| "davidondrej1": "> 學 cmux\n> 相信我", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@web/messages/zh-TW.json` at line 1070, Update the testimonial entry keyed by
"davidondrej1" in the zh-TW `testimonials` map to replace each plain ">" quote
marker with the HTML-escaped ">" and ensure the quoted lines end with an
explicit newline sequence ("\n") so formatting matches other locales (see
structure used in `testimonials` entries).
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 474ebe9. Configure here.
| name: "David Ondrej", | ||
| handle: "@DavidOndrej1", | ||
| avatar: "/avatars/davidondrej1.jpg", | ||
| text: "> learn cmux\n> trust me", |
There was a problem hiding this comment.
Newlines in testimonial text collapse on homepage
Medium Severity
The new davidondrej1 testimonial contains a \n newline in its text field. The whitespace-pre-line class was added to TestimonialCard (Wall of Love page), so newlines render correctly there. However, the homepage community section renders testimonial text inside a plain <span> without whitespace-pre-line, so the newline collapses into a space and the quote displays as "> learn cmux > trust me" — losing the intended two-line formatting.
Reviewed by Cursor Bugbot for commit 474ebe9. Configure here.
Addressed in 474ebe9; latest CodeRabbit status is green.
This branch was successfully deployed
1 participant
Adds David Ondrej's X post to the shared testimonial list, which feeds both the home page community section and Wall of Love.
Source: https://x.com/DavidOndrej1/status/2059360111336865901
Verification:
bun run lint(existing warnings only)source scripts/load-dev-env.sh && bun run buildhttp://localhost:4177/enandhttp://localhost:4177/en/wall-of-lovein ChromeNote
Low Risk
Marketing/i18n and CSS-only presentation changes on the marketing site; no auth, data, or core app logic affected.
Overview
Adds David Ondrej’s X post to the shared testimonial list used on the home community section and Wall of Love, including avatar metadata and a new
davidondrej1translation key across locale message files.Testimonial cards now use
whitespace-pre-lineon the quote and translated subtitle so multi-line posts (e.g.> learn cmux/> trust me) render with line breaks instead of collapsing to one line.Reviewed by Cursor Bugbot for commit 474ebe9. Bugbot is set up for automated code reviews on this repo. Configure here.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.Summary by cubic
Adds
@DavidOndrej1’s X testimonial to the shared list used by the home page community section and Wall of Love, with avatar and i18n strings across locales. Updates the testimonial card to render multi-line text (whitespace-pre-line) and positions this entry after the DeepMind testimonial.Written for commit 474ebe9. Summary will update on new commits. Review in cubic
Summary by CodeRabbit
New Features
Improvements