Skip to content

Restore file preview review CI coverage #4883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawrencecchen merged 1 commit into from
May 27, 2026
Merged

Restore file preview review CI coverage #4883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,6 @@ jobs:
-skip-testing:cmuxTests/CLINotifyProcessIntegrationRegressionTests/testGrokNotificationStillFiresOnRepeatedPromptWhenFeedTelemetryDoesNotReply \
-skip-testing:cmuxTests/FileExplorerStoreTests/testRemoteWorkspaceRootRequestResolvesSSHHomeInsteadOfKeepingLocalPath \
-skip-testing:cmuxTests/FilePreviewPanelTextSavingTests \
-skip-testing:cmuxTests/FilePreviewReviewFeedbackTests \
-skip-testing:cmuxTests/GhosttySurfaceOverlayTests \
test 2>&1 &
local xcodebuild_pid=$!
Expand Down
8 changes: 8 additions & 0 deletions cmuxTests/FilePreviewReviewFeedbackTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ final class FilePreviewReviewFeedbackTests: XCTestCase {
defer { try? FileManager.default.removeItem(at: url) }

let panel = FilePreviewPanel(workspaceId: UUID(), filePath: url.path)
defer { panel.close() }
await panel.loadTextContent().value

let textView = SavingTextView()
Expand Down Expand Up @@ -72,6 +73,7 @@ final class FilePreviewReviewFeedbackTests: XCTestCase {
defer { try? FileManager.default.removeItem(at: url) }

let panel = FilePreviewPanel(workspaceId: UUID(), filePath: url.path)
defer { panel.close() }
XCTAssertEqual(panel.previewMode, .quickLook)

let view = panel.nativeViewSessions.quickLook.view(
Expand Down Expand Up @@ -102,6 +104,7 @@ final class FilePreviewReviewFeedbackTests: XCTestCase {
defer { try? FileManager.default.removeItem(at: url) }

let panel = FilePreviewPanel(workspaceId: UUID(), filePath: url.path)
defer { panel.close() }
let retiredView = panel.nativeViewSessions.quickLook.view(
panel: panel,
isVisibleInUI: true,
Expand Down Expand Up @@ -191,6 +194,10 @@ final class FilePreviewReviewFeedbackTests: XCTestCase {
XCTAssertFalse(coordinator.focus(.textEditor))

let window = NSWindow(contentRect: textView.bounds, styleMask: [], backing: .buffered, defer: false)
defer {
window.contentView = nil
window.close()
}
window.contentView = textView
coordinator.fulfillPendingFocusIfNeeded()

Expand All @@ -208,6 +215,7 @@ final class FilePreviewReviewFeedbackTests: XCTestCase {

let manager = TabManager()
let workspace = manager.addWorkspace(select: true, eagerLoadTerminal: false)
defer { workspace.teardownAllPanels() }
let firstPane = try XCTUnwrap(workspace.bonsplitController.allPaneIds.first)
let existingPanel = try XCTUnwrap(workspace.newFilePreviewSurface(
inPane: firstPane,
Expand Down
Loading