Restore browser remote store CI coverage

[lawrencecchen]

Summary

Restores cmuxTests/BrowserPanelRemoteStoreTests to the required macOS unit-test job by removing the broad class-level skip from .github/workflows/ci.yml.

This continues the quarantine reduction tracked by #4524.

Verification

• git diff --check
• ruby -e 'require "yaml"; YAML.load_file(".github/workflows/ci.yml"); puts "ci.yml parsed"'\n- Hosted PR checks will exercise the restored class.\n

---

^{Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.}

---

Summary by cubic

Restore cmuxTests/BrowserPanelRemoteStoreTests in the macOS unit-test CI by removing its skip in .github/workflows/ci.yml. This re-enables browser remote store coverage and continues the quarantine reduction tracked in #4524.

^{Written for commit 44dc204. Summary will update on new commits. Review in cubic}

Summary by CodeRabbit

• Tests
  • Updated CI testing configuration for macOS unit test execution.

Note: This is an internal testing infrastructure change with no end-user visible impact.

---

Note

Low Risk
Workflow-only change; may surface flaky or failing remote-store tests on CI but does not alter app code.

Overview
Re-enables cmuxTests/BrowserPanelRemoteStoreTests on the macOS unit-test job by removing its class-level -skip-testing entry from .github/workflows/ci.yml, so those tests run again with the rest of the quarantined suite reduction (issue #4524).

No product or test source changes—only CI wiring.

^{Reviewed by Cursor Bugbot for commit 44dc204. Bugbot is set up for automated code reviews on this repo. Configure here.}

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
cmux	Ready	Preview, Comment	May 27, 2026 1:06pm
cmux-staging	Building	Preview, Comment	May 27, 2026 1:06pm

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: d58ccc1e-e112-46a4-95f1-ca814b2fa5ca

📥 Commits

Reviewing files that changed from the base of the PR and between 45e8fbe and 44dc204.

📒 Files selected for processing (1)

• .github/workflows/ci.yml

💤 Files with no reviewable changes (1)

• .github/workflows/ci.yml

---

📝 Walkthrough

Walkthrough

The CI workflow for macOS is updated to adjust which XCTest suites are quarantined during the unit test execution. The -skip-testing list removes one test and adds two others, controlling test execution without altering the surrounding timeout or retry logic.

Changes

CI Test Quarantine Updates

Layer / File(s)	Summary
XCTest skip list adjustment .github/workflows/ci.yml	The xcodebuild -skip-testing targets are modified: cmuxTests/BrowserPanelRemoteStoreTests is removed, while cmuxTests/AppDelegateShortcutRoutingTests/testCmdWClosesWindowWhenClosingLastSurfaceInLastWorkspace and cmuxTests/BrowserDeveloperToolsVisibilityPersistenceTests are added to the quarantine list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

• Replace broad macOS app-host CI quarantines with gated coverage #4524: Both changes adjust the macOS CI workflow's xcodebuild skip list in .github/workflows/ci.yml to quarantine different test suites.

Possibly related PRs

• manaflow-ai/cmux#4874: Updates the same macOS CI xcodebuild -skip-testing list, specifically adjusting how AppDelegateShortcutRoutingTests quarantine is configured.

Poem

🐰 A rabbit hops through workflows fine,
Adjusting tests—which ones to skip this time!
Remove one test, add two more to the queue,
CI runs faster with this pruned-down view.

🚥 Pre-merge checks | ✅ 18

✅ Passed checks (18 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Restore browser remote store CI coverage' directly matches the main change: removing a skip to restore BrowserPanelRemoteStoreTests to CI coverage.
Description check	✅ Passed	The description includes Summary and Verification sections with clear explanations and testing steps, though it uses 'Verification' instead of the template's 'Testing' section.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Cmux Swift Actor Isolation	✅ Passed	PR contains only CI configuration changes (.github/workflows/ci.yml) with no production Swift code modifications. Custom check requires "production Swift changes" to apply.
Cmux Swift Blocking Runtime	✅ Passed	PR only modifies CI workflow YAML (.github/workflows/ci.yml) to adjust test skips; contains no production Swift code changes, so the blocking runtime check does not apply.
Cmux No Hacky Sleeps	✅ Passed	PR only modifies .github/workflows/ci.yml, which is explicitly excluded from the rule per runtime-no-hacky-sleeps.md. No production TypeScript, JavaScript, or shell code was changed.
Cmux Algorithmic Complexity	✅ Passed	PR only modifies CI workflow YAML (.github/workflows/ci.yml) to adjust test skip lists; no production code or algorithmic changes present, rule applies to production code only.
Cmux Swift Concurrency	✅ Passed	PR modifies only .github/workflows/ci.yml (YAML CI config), introducing no Swift code changes. The custom check targets cmux-owned Swift code async patterns; not applicable here.
Cmux Swift @Concurrent	✅ Passed	PR contains no Swift code changes; only CI workflow configuration modification. Custom check applies to Swift code concurrent annotations and is not applicable to CI-only changes.
Cmux Swift File And Package Boundaries	✅ Passed	PR only modifies CI workflow configuration (.github/workflows/ci.yml), not Swift production code. The custom check for Swift file/package boundaries doesn't apply to non-Swift changes.
Cmux Swift Logging	✅ Passed	PR is a CI workflow configuration change only (.github/workflows/ci.yml), with no Swift source code modifications, so logging rules check is not applicable.
Cmux User-Facing Error Privacy	✅ Passed	PR only modifies CI workflow config (.github/workflows/ci.yml) to adjust test skipping; no production code or user-facing error messages changed.
Cmux Full Internationalization	✅ Passed	CI workflow config change only; no user-facing text, production code, or localization file modifications. Exempted as test and operational infrastructure change.
Cmux Swiftui State Layout	✅ Passed	PR contains only CI workflow configuration changes (skip-testing list updates), no SwiftUI code modifications. Custom check for SwiftUI state layout rules is not applicable.
Cmux Architecture Rethink	✅ Passed	PR is a CI workflow configuration change only; no Swift source code or architectural changes are present, making the Swift architecture rethink check not applicable.
Cmux Swift Auxiliary Window Close Shortcuts	✅ Passed	PR contains only CI workflow YAML changes (test skip configuration), no Swift code modifications to NSWindow, NSPanel, NSWindowController, or SwiftUI Window/WindowGroup code. Check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch issue-4524-browser-remote-store

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[greptile-apps]

Greptile Summary

This PR removes the class-level -skip-testing:cmuxTests/BrowserPanelRemoteStoreTests flag from the macOS unit-test job in ci.yml, restoring CI coverage for the remote store test class as part of the ongoing quarantine reduction tracked by issue #4524.

• Removes one line from the xcodebuild skip list in .github/workflows/ci.yml; no production code is touched.
• The restored test class lives in cmuxTests/GhosttyConfigTests.swift and exercises BrowserPanel remote workspace data-store scoping, loopback URL aliasing, and panel move semantics across workspace boundaries.

Confidence Score: 5/5

Safe to merge — the change is a single-line deletion in the CI skip list with no production code impact.

The diff removes exactly one -skip-testing: flag from xcodebuild. The restored test class is self-contained in cmuxTests/GhosttyConfigTests.swift, exercises well-defined BrowserPanel data-store behaviour, and is tracked as a deliberate quarantine reduction. No production code, no build matrix changes, and no new timing or concurrency patterns are introduced by this PR.

No files require special attention.

Important Files Changed

Filename	Overview
.github/workflows/ci.yml	Removes one -skip-testing:cmuxTests/BrowserPanelRemoteStoreTests line, restoring the class to the macOS unit-test job as part of tracked quarantine reduction (issue #4524).

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[macOS Unit Test Job] --> B[xcodebuild -scheme cmux-unit]
    B --> C{Skip list}
    C -->|still skipped| D[BrowserDeveloperToolsVisibilityPersistenceTests]
    C -->|still skipped| E[BrowserPanelWebViewLifecycleTests]
    C -->|still skipped| F[BrowserSessionHistoryRestoreTests]
    C -->|✅ RESTORED| G[BrowserPanelRemoteStoreTests]
    G --> H[testRemoteWorkspacePanelsShareWorkspaceScopedWebsiteDataStore]
    G --> I[testRemoteWorkspaceDefersInitialNavigationUntilProxyEndpointIsReady]
    G --> J[testRemoteWorkspaceRuntimeBridgeAliasesMultipleLoopbackPortsFromSamePage]
    G --> K[testBrowserMoveIntoRemoteWorkspaceRebuildsWebsiteDataStoreScope]
    G --> L[testBrowserMoveOutOfRemoteWorkspaceRestoresDefaultWebsiteDataStore]

Loading

_{Reviews (1): Last reviewed commit: "Restore browser remote store CI coverage" | Re-trigger Greptile}