Add algorithmic complexity review rule

[lawrencecchen]

Adds a shared review-bot rule for algorithmic complexity regressions.\n\n- Flags nested full-collection scans and per-target rescans over scalable user data.\n- Requires a linear design or benchmark-backed justification for paths expected to handle about 1000 workspaces or similar records.\n- Wires the rule into CodeRabbit and Greptile.\n\nVerification:\n- jq -e . .greptile/config.json .greptile/files.json >/dev/null\n- ruby -e 'require "yaml"; YAML.load_file(".coderabbit.yaml"); puts "coderabbit yaml ok"'

---

^{Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.}

---

Note

Low Risk
Config-only changes to review bots; no production runtime or app behavior.

Overview
Introduces a shared algorithmic complexity review rule and wires it into CodeRabbit and Greptile so PRs can be blocked on performance regressions over scalable user data.

The new .github/review-bot-rules/algorithmic-complexity.md defines fail/pass criteria: nested full-collection scans, per-target rescans in batch actions, hot-path repeated sort/filter/map, in-memory DB joins, and slower algorithms on paths sized for ~1000 workspaces without linear design or benchmarks.

CodeRabbit gets path instructions for Swift/TS/JS/shell and an error-mode pre-merge check cmux algorithmic complexity. Greptile adds cmux-algorithmic-complexity (high severity), registers the rule file in files.json, and documents it in rules.md and the review-bot README.

^{Reviewed by Cursor Bugbot for commit c6756a2. Bugbot is set up for automated code reviews on this repo. Configure here.}

---

Summary by cubic

Adds a shared algorithmic complexity review rule to catch scalability regressions on user-owned data. Integrates with CodeRabbit and Greptile as error/high-severity checks across Swift/TS/JS/shell, with aligned wording across both tools.

• New Features
  • Rule flags nested full-collection scans, per-target rescans, repeated sort/filter/map in hot paths, in-memory joins, and unbenchmarked slower choices for paths expected to handle ~1000 workspaces; passes for tiny fixed-size sets, tests/benchmarks, existing debt not worsened, and documented bounds with measurements.
  • Enabled as an error-level CodeRabbit check (“cmux algorithmic complexity”) with path hints for Swift/TS/JS/shell.
  • Added Greptile rule cmux-algorithmic-complexity (high severity) with updated .greptile/rules.md and .greptile/files.json; wording aligned with CodeRabbit.

^{Written for commit c6756a2. Summary will update on new commits. Review in cubic}

Summary by CodeRabbit

• Chores

  • Added algorithmic complexity review rules and a new pre-merge check that enforces failure for unbenchmarked or clearly inefficient algorithms in production Swift/TypeScript/JavaScript/shell code (e.g., nested full-collection scans, repeated heavy sort/filter/map work in hot paths).

• Documentation

  • Updated review-rule documentation to include the new algorithmic complexity policy and reporting guidance for flagged issues.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
cmux	Ready	Preview, Comment	May 27, 2026 10:12am
cmux-staging	Building	Preview, Comment	May 27, 2026 10:12am

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR introduces an algorithmic complexity review rule for production code. It defines specific patterns to flag—such as repeated full-collection scans, sort/filter work in hot paths, and inefficient in-memory joins—while allowing exceptions for small fixed-size collections and test code. The rule is then integrated into CodeRabbit and Greptile review systems through configuration entries and documentation updates.

Changes

Algorithmic Complexity Review Rule

Layer / File(s)	Summary
Rule definition and policy \.github/review-bot-rules/algorithmic-complexity\.md, \.github/review-bot-rules/README\.md	Introduces the algorithmic complexity rule document defining patterns to flag (full-collection scans, repeated sort/filter work in hot paths, in-memory joins, unbenchmarked slower algorithms) and patterns to pass (small bounded collections, test code, unchanged inefficiencies), plus required failure reporting (scalable collection, expected scale, fix suggestion).
Integration into CodeRabbit and Greptile systems \.coderabbit\.yaml, \.greptile/config\.json, \.greptile/files\.json, \.greptile/rules\.md	Wires the rule into CodeRabbit's path instructions and pre-merge custom checks (error mode), and into Greptile's rule configuration, file metadata registry, and review checklist documentation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A rabbit hops through configs neat,
Adding rules for algorithms sweet—
No nested scans shall pass review!
Performance checks shine fresh and new,
Code that's lean gets the bunny's chew! 🥕

🚥 Pre-merge checks | ✅ 5 | ❌ 12

❌ Failed checks (12 inconclusive)

Check name	Status	Explanation	Resolution
Cmux Swift Actor Isolation	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Cmux Swift Blocking Runtime	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Cmux No Hacky Sleeps	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Cmux Swift Concurrency	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Cmux Swift @Concurrent	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Cmux Swift File And Package Boundaries	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Cmux Swift Logging	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Cmux User-Facing Error Privacy	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Cmux Full Internationalization	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Cmux Swiftui State Layout	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Cmux Architecture Rethink	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Cmux Swift Auxiliary Window Close Shortcuts	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Add algorithmic complexity review rule' directly and clearly summarizes the main change—introducing a new review-bot rule for detecting algorithmic complexity regressions across the configuration files and documentation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The PR description provides a clear summary and verification steps, but omits the Testing, Demo Video, and Review Trigger sections from the required template.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat-review-bot-rules-algorithmic-complexity

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[greptile-apps]

Greptile Summary

This PR introduces a shared algorithmic complexity review rule and wires it into both CodeRabbit and Greptile as a high-severity, error-mode check across Swift, TypeScript, JavaScript, and shell files.

• Adds .github/review-bot-rules/algorithmic-complexity.md with Fail/Pass/Report criteria covering nested full-collection scans, per-target rescans, hot-path sort/filter/map churn, in-memory joins, and unbenchmarked slower algorithms on paths expected to handle ~1000 workspaces.
• Registers the rule in .coderabbit.yaml (path instructions with pass conditions + pre-merge error check), .greptile/config.json (high-severity rule), .greptile/files.json (file reference), and .greptile/rules.md (summary section), with scopes and summaries consistent across all four integration points.

Confidence Score: 5/5

Config-only change; no app runtime, auth, or data path is touched, so merging carries no regression risk.

All six changed files are review-bot configuration and documentation. The rule text, scopes, and pass/fail conditions are internally consistent across CodeRabbit, Greptile config, files index, and rules summary. No production logic is introduced or modified.

No files require special attention.

Important Files Changed

Filename	Overview
.github/review-bot-rules/algorithmic-complexity.md	New rule file defining Fail/Pass/Report criteria for algorithmic complexity on scalable user-owned collections; well-structured and self-consistent.
.coderabbit.yaml	Adds a path_instructions entry (with pass conditions) and an error-mode pre-merge check for algorithmic complexity, consistent with peer rules.
.greptile/config.json	Adds cmux-algorithmic-complexity rule with high severity and correct scope matching the rule file; inserted in a sensible position among existing rules.
.greptile/files.json	Adds algorithmic-complexity.md entry with scope identical to config.json, consistent with how other rule files are registered.
.greptile/rules.md	Adds a bullet to the top-level list and a full Algorithmic Complexity section summarizing fail/pass criteria; consistent with sibling rule sections.
.github/review-bot-rules/README.md	Adds algorithmic-complexity.md to the listing in correct alphabetical order.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR Opens / Updates] --> B{File matches scope?}
    B -->|**/*.swift, ts, js, sh, zsh| C[CodeRabbit path_instructions]
    B -->|**/*.swift, ts, js, sh, zsh| D[Greptile cmux-algorithmic-complexity rule]
    C --> E[Inline review comments]
    D --> F[Greptile status check + inline findings]
    A --> G[Pre-merge check]
    G --> H[cmux algorithmic complexity mode: error]
    H --> I{Violation found?}
    I -->|Nested scan / rescan / hot-path sort / in-memory join / unbenchmarked O-worse| J[Block merge]
    I -->|Fixed-size set / test / benchmark / existing debt / documented bound| K[Pass]

Loading

_{Reviews (2): Last reviewed commit: "Align algorithmic complexity review hint" | Re-trigger Greptile}

[greptile-apps]

The path_instructions entry for algorithmic complexity omits pass conditions, while every peer rule in this file (e.g., runtime-no-hacky-sleeps) explicitly lists them. Without pass conditions in the inline hint, CodeRabbit's path-level reviewer has no guidance to skip tiny fixed-size collections, tests, benchmark harnesses, or existing debt — increasing the chance of false-positive inline comments on those patterns.

Suggested change

	- path: "**/*.{swift,ts,tsx,js,jsx,mjs,cjs,sh,zsh}"
	instructions: |
	Apply `.github/review-bot-rules/algorithmic-complexity.md` during review. For production code over scalable user data, flag nested full-collection scans, repeated sort/filter/map work in hot paths, in-memory joins that belong in the data store, and unbenchmarked algorithm choices for paths expected to handle roughly 1000 workspaces or similar records.
	- path: "**/*.{swift,ts,tsx,js,jsx,mjs,cjs,sh,zsh}"
	instructions: |
	Apply `.github/review-bot-rules/algorithmic-complexity.md` during review. For production code over scalable user data, flag nested full-collection scans, per-target rescans for batch actions, repeated sort/filter/map work in hot paths, in-memory joins that belong in the data store, and unbenchmarked algorithm choices for paths expected to handle roughly 1000 workspaces or similar records. Pass for tiny fixed-size collections, tests and benchmark harnesses, existing inefficient code not worsened, and documented bounds with measurements.

[lawrencecchen]

Fixed by aligning the CodeRabbit path instruction with the rule's batch-rescan condition and pass cases.

— Claude Code