Repository navigation
Conversation
|
@gerfalcon is attempting to deploy a commit to the Manaflow Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthrough
ChangesAntigravity agent kind
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Poem
🚥 Pre-merge checks | ✅ 16 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (16 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryAdds
Confidence Score: 5/5Safe to merge — one-line addition to a well-guarded list with an existing native resume-command arm already handling the kind correctly. The change is a single-case addition to a static array. The
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Session Relaunch] --> B[Build hookKinds]
B --> C{allCases has antigravity?}
C -- Before fix NO --> D[builtInAntigravity in registry]
D --> E[Not in builtInKindIDs]
E --> F[Added as custom antigravity to hookKinds]
F --> G[Custom branch: builtInAntigravity.id check]
G --> H{Project config also registers antigravity?}
H -- YES --> I[Duplicate mismatch - relaunch aborted]
H -- NO --> J[Restored OK]
C -- After fix YES --> K[antigravity in builtInKindIDs]
K --> L[builtInAntigravity filtered from hookKinds]
L --> M[.antigravity from allCases with nil registration]
M --> N[switch case .antigravity]
N --> O[Restore with fallbackExecutable agy and --conversation flag]
O --> P[Always restored correctly]
Reviews (2): Last reviewed commit: "chore(core): remove obsolete registry-ow..." | Re-trigger Greptile |
| // Antigravity is registry-owned so the built-in Vault registration can be | ||
| // overridden by project config while direct .antigravity values still encode. | ||
| .antigravity, |
There was a problem hiding this comment.
Misleading comment mirrors Pi/Grok exclusion language
The comment above .antigravity ("registry-owned so the built-in Vault registration can be overridden…") uses word-for-word the same phrasing as the Pi/Grok comment on lines 24–25, which explains why those cases are absent from allCases. Here the comment is attached to a case that is present, making the two blocks read as equivalent when they express opposite intent. A future maintainer auditing "registry-owned" cases could reasonably conclude that .antigravity should be removed for the same reason Pi and Grok were excluded, reintroducing this regression. The comment should explicitly distinguish whether the case is included or omitted and, for the Pi/Grok block, name the cases that were left out.
Rule Used: Flag Swift fixes that patch symptoms while leaving... (source)
|
Thanks for this! Antigravity sessions restore on relaunch (routed through the hook registry instead) landed on main in #12151. You opened this first, so you got there first. Closing since main covers it now. |
Fixes relaunch/restart restore for Antigravity sessions. Previously, Antigravity sessions were decoded without proper mapping support in RestorableAgentKind.allCases, causing custom registration mismatch errors that aborted relaunch restoration. Adding .antigravity to allCases resolves this fully.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.Summary by cubic
Adds
.antigravitytoRestorableAgentKind.allCasesso Antigravity sessions restore on relaunch. Also removes an obsolete registry-owned comment and fixes decode/registration mismatches when projects override the built‑in Vault registration.Written for commit cf9845a. Summary will update on new commits. Review in cubic
Summary by CodeRabbit