Repository navigation
Stop bundling example sidebars in the app - #4662
Conversation
The picker-only options users could choose between were toy demonstrations of the sidebar extension API. They aren't useful as shipped UI, and they made the picker look like the app shipped "workspaces by project" / "attention queue" / etc. as first-class features. Drop the package from the app target so the picker only lists the default workspaces sidebar; keep the source under Examples/CmuxExtensionSidebarExamples/ as a buildable reference package for users authoring their own provider. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThis PR removes the ChangesSidebar Dependency Migration
Possibly related PRs
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 17✅ Passed checks (17 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryRemoves the six toy example sidebar providers (
Confidence Score: 5/5Safe to merge — a clean, additive removal of example code with no effect on production sidebar behavior. The only functional change is No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Sidebar Picker open] --> B[CmuxExtensionSidebarSelection.descriptors]
B --> C["[.defaultWorkspaces] + providers.map{...}"]
C --> D{"providers list"}
D -->|before PR| E["SidebarExamples.providers\n(6 toy entries)"]
D -->|after PR| F["[]\n(empty)"]
E --> G[Picker shows 7 entries]
F --> H["Picker shows 1 entry:\nDefault Workspaces"]
Reviews (2): Last reviewed commit: "Remove leftover BrowserStackSidebar noti..." | Re-trigger Greptile |
The notification was posted by the example provider, which no longer ships with the app. Without the example, nothing posts the name so the .onReceive subscription is dead. Drop it to fix the build. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
The sidebar picker shipped six toy example providers (project worktrees, attention queue, dev server, last prompt, super compact, browser stack) that demoed the
CmuxExtensionSidebarProviderAPI. They weren't real features. Dropped from the app target so the picker only shows the default workspaces sidebar.Examples/CmuxExtensionSidebarExamples/stays in the repo as a buildable Swift package — kept as reference material for users authoring their own provider. Just no longer linked into the app.This is the first of two PRs. The second will add docs for vibecoding your own sidebar (beta) and a right-click "Open docs" item on the sidebar picker chip.
Test plan
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.Note
Low Risk
Low risk: removes a single NotificationCenter trigger for refreshing the extension sidebar snapshot, reducing redundant updates without touching core rendering or data flows.
Overview
Stops listening for
BrowserStackSidebar.stateDidLoadNotificationto triggerrefreshExtensionSidebarSnapshot()inContentView, leaving sidebar refreshes driven only by the existing immediate and debounced observation publishers.Reviewed by Cursor Bugbot for commit 43f3f06. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Remove the toy example sidebars from the app so the picker only shows the Default Workspaces sidebar. Also removed a leftover
BrowserStackSidebarnotification listener to fix the build after dropping the examples.Dependencies
CmuxExtensionSidebarExamplesfrom the app target and Xcode project; kept sources underExamples/CmuxExtensionSidebarExamples/as a buildable package.Bug Fixes
BrowserStackSidebar.stateDidLoadNotificationsubscription inContentView(it was only posted by the removed examples).Written for commit 43f3f06. Summary will update on new commits. Review in cubic
Summary by CodeRabbit