Repository navigation
Flash manual unread workspace jumps #4436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
260717a
test: cover manual unread jump flash
lawrencecchen 6bef7b4
fix: flash workspace unread jumps
lawrencecchen a44762f
Merge remote-tracking branch 'origin/main' into issue-unread-flash-wo…
lawrencecchen 724be18
test: cover workspace switch overlay flash
lawrencecchen b3a0b56
fix: animate unread flash after workspace switch
lawrencecchen 1a8bb51
test: cover restored unread jump flash count
lawrencecchen d78ee42
fix: avoid duplicate restored unread jump flash
lawrencecchen 19b08e4
test: cover cmd-ctrl-u manual workspace jump
lawrencecchen 5b71491
fix: keep cmd-ctrl-u manual unread excluded
lawrencecchen f57e724
test: cover deferred unread flash rect
lawrencecchen d1c0edd
fix: defer unread flash token consumption
lawrencecchen a2e082e
test: cover first observed unread flash token
lawrencecchen c06fab0
fix: animate first observed unread flash token
lawrencecchen cfe1a93
test: cover excluded workspace notifications
lawrencecchen 17b4aa8
fix: exclude workspace notifications during unread jump
lawrencecchen b71645f
fix: include restored unread jump flash fallback
lawrencecchen ded6549
fix: prefer printable shortcut characters over physical fallback
lawrencecchen 8b36dc9
merge: sync with origin main
lawrencecchen cfe7898
test: cover focused panel unread markers
lawrencecchen beae6d6
fix: keep manual unread marker on focused panel
lawrencecchen 777d363
Merge remote-tracking branch 'origin/main' into issue-unread-flash-wo…
lawrencecchen e655991
fix: preserve command control shortcut fallback
lawrencecchen ad754ff
fix: handle workspace unread and control fallback
lawrencecchen 86a10ac
fix: clear focused read indicator on panel read
lawrencecchen 96edc79
fix: detect visible notification indicators correctly
lawrencecchen f7c8dc4
fix: clear restored workspace unread from panel toggle
lawrencecchen 4e45da2
fix: distinguish restored unread ownership
lawrencecchen e4ab404
fix: avoid duplicate workspace and panel unread
lawrencecchen 40b4861
fix: scope unread duplicate checks to focused target
lawrencecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.