Skip to content

fix(browser): handle absolute local file paths #4251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gazzua wants to merge 2 commits into from
Closed

fix(browser): handle absolute local file paths #4251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f9f531
fix(browser): handle absolute local file paths
gazzua May 16, 2026
a40ee7d
refactor(browser): simplify absolute path check
gazzua May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Sources/Panels/BrowserPanel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4555,6 +4555,11 @@ private func browserBareHostCandidate(_ lowercasedInput: String) -> String {
func resolveBrowserNavigableURL(_ input: String) -> URL? {
let trimmed = input.trimmingCharacters(in: .whitespacesAndNewlines)
guard !trimmed.isEmpty else { return nil }

if trimmed.hasPrefix("/") {
return URL(fileURLWithPath: trimmed)
}

guard !trimmed.contains(" ") else { return nil }

// Check localhost/loopback before generic URL parsing because
Expand Down
16 changes: 16 additions & 0 deletions cmuxTests/GhosttyConfigTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1207,6 +1207,22 @@ final class BrowserNewTabNavigationSeedTests: XCTestCase {
}
}

final class BrowserNavigableURLResolverTests: XCTestCase {
func testAbsoluteFilePathResolvesToFileURL() throws {
let url = try XCTUnwrap(resolveBrowserNavigableURL("/Users/example/Desktop/report.html"))

XCTAssertTrue(url.isFileURL)
XCTAssertEqual(url.path, "/Users/example/Desktop/report.html")
}

func testAbsoluteFilePathWithSpacesResolvesToFileURL() throws {
let url = try XCTUnwrap(resolveBrowserNavigableURL("/Users/example/Desktop/disk cleanup report.html"))

XCTAssertTrue(url.isFileURL)
XCTAssertEqual(url.path, "/Users/example/Desktop/disk cleanup report.html")
}
}

@MainActor
final class BrowserPanelRemoteStoreTests: XCTestCase {
func testRemoteWorkspacePanelsShareWorkspaceScopedWebsiteDataStore() {
Expand Down