Repository navigation
Fix #3998: discard input for dead terminal panes #4045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
ea4e27c
Add dead terminal input regression
austinywang 9305c65
Discard input after terminal child exit
austinywang 8a2ee18
Add stale keyboard garble regression
austinywang b5d3496
Reset terminal keyboard protocols at prompt
austinywang 7f6476d
Merge remote-tracking branch 'origin/main' into issue-3998-dead-pty-g…
austinywang fadf469
Address terminal input review feedback
austinywang 9fc629d
Address follow-up input review feedback
austinywang 25dd3da
Address child exit input feedback
austinywang 3bbf93b
Merge remote-tracking branch 'origin/main' into issue-3998-dead-pty-g…
austinywang 153a8bf
Serialize terminal socket writes with child exit
austinywang 149085f
Merge remote-tracking branch 'origin/main' into issue-3998-dead-pty-g…
austinywang c574fb3
Fix terminal input CI blockers
austinywang 8cd9e2e
Unify terminal socket input routing
austinywang 2108d8b
Merge remote-tracking branch 'origin/main' into issue-3998-dead-pty-g…
austinywang 47562bd
Preserve queued terminal text semantics
austinywang 366a49b
Report accepted terminal socket input
austinywang e623794
Merge remote-tracking branch 'origin/main' into issue-3998-dead-pty-g…
austinywang d903dbe
Fix dead terminal regression after input path merge
austinywang 6c1eb23
Preserve first terminal teardown reason
austinywang 69d214d
Preserve direct surface send readiness wait
austinywang 3bae061
Merge remote-tracking branch 'origin/main' into issue-3998-dead-pty-g…
austinywang 73eb451
Add dead PTY startup command regression
austinywang 53a2e13
Disable wait-after-command for cmux terminals
austinywang 9fbf89e
Merge remote-tracking branch 'origin/main' into issue-3998-dead-pty-g…
austinywang fefc529
Fix dead PTY test seam visibility
austinywang 1c8a0cf
Remove duplicate keyboard reset helpers
austinywang 96d6fba
Add dead terminal socket response regression
austinywang 5bcda78
Report blocked terminal socket input
austinywang b1b3ea3
Address terminal input review feedback
austinywang abdde1f
Preserve dead terminal input contracts
austinywang 82e0ddb
Avoid dead terminal surface send wait
austinywang e2eb23a
Avoid duplicate bash keyboard reset
austinywang caffcb7
merge: resolve conflicts with main
austinywang 3666b34
Fix terminal socket input helper
austinywang dc76450
Merge remote-tracking branch 'origin/main' into issue-3998-dead-pty-g…
austinywang 4702b00
Add remote split wait-after-command regression
austinywang 6afd698
Fix remote startup wait-after-command override
austinywang 3afa414
Address split terminal config feedback
austinywang fb29444
Merge branch 'main' of https://github.com/manaflow-ai/cmux into issue…
austinywang a5c9a38
fix: clarify pending terminal input synchronization
austinywang bfe100c
Merge branch 'main' of https://github.com/manaflow-ai/cmux into issue…
austinywang 2cfbd16
fix: lock pending socket input startup check
austinywang 53bb46d
Merge remote-tracking branch 'origin/main' into issue-3998-dead-pty-g…
austinywang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.