Repository navigation
Add subagent tree visualization for agent feed (#3932) #3964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
a688a16
feat: add agent tree feed view
austinywang 0e51436
Merge remote-tracking branch 'origin/main' into issue-3932-subagent-t…
austinywang 79f2728
Fix feed empty state view return
austinywang 3ce3f8a
Fix feed tree keyboard snapshot scope
austinywang 99ccd86
Address agent tree review feedback
austinywang e5a2392
Fix agent tree spawn reconciliation
austinywang c9d75a5
Merge remote-tracking branch 'origin/main' into issue-3932-subagent-t…
austinywang 1b889d7
fix: defer feed agent graph rebuilds
austinywang 7dc1492
fix: honor parent source in agent graph
austinywang 6a70b79
Merge remote-tracking branch 'origin/main' into issue-3932-subagent-t…
austinywang 09c9115
test: cover ambiguous agent spawn pruning
austinywang dab7ff3
fix: keep ambiguous agent spawns
austinywang b3c5d9d
fix: coalesce agent graph rebuilds
austinywang bca988f
test: cover parent child spawn pruning
austinywang f33a6f7
fix: centralize agent child linking
austinywang ee38cba
fix: address agent graph review feedback
austinywang c830c16
fix: address agent tree review findings
austinywang a0390a7
fix: simplify agent tree view type checking
austinywang a52e309
fix: share agent spawn tool detection
austinywang b2ca36e
fix: avoid invalidating inactive agent tree builds
austinywang 812784f
fix: address agent tree follow-up reviews
austinywang 4d61c04
fix: polish agent tree pending state
austinywang c95c6f3
fix: reduce agent tree rebuild work
austinywang 36076bc
fix: preserve agent tree session metadata
austinywang 5ac8709
fix: tighten agent tree ownership
austinywang d5c1f71
fix: use app debug log for feed focus bridge
austinywang adcfb97
merge: sync main into agent tree branch
austinywang 5dedfe8
fix: let agent tree page older feed history
austinywang e20963b
fix: remove duplicate agent tree empty state
austinywang e0d2bb3
fix: avoid duplicate agent metadata text
austinywang 644f63e
Merge remote-tracking branch 'origin/main' into issue-3932-subagent-t…
austinywang a86f82e
fix: isolate feed store observation snapshot
austinywang 0e21156
fix: align agent spawn resolution scoring
austinywang f4ec1f1
fix: address agent tree review feedback
austinywang bb23aad
fix: make feed focus registration idempotent
austinywang d08f1cf
Merge remote-tracking branch 'origin/main' into issue-3932-subagent-t…
austinywang a2cd526
fix: reuse feed focus registration path
austinywang 6baf833
test: cover sanitized agent prompt metadata
austinywang 0184e89
fix: preserve agent prompt metadata
austinywang 200adc5
test: cover subagent model priority
austinywang e5ad63d
fix: prefer spawn input model metadata
austinywang 38da68b
fix: keep spawn metadata off parent agent nodes
austinywang 1f9c00e
Merge remote-tracking branch 'origin/main' into issue-3932-subagent-t…
austinywang b73d471
Merge remote-tracking branch 'origin/main' into issue-3932-subagent-t…
austinywang 50a2d5e
fix: keep parent models out of child nodes
austinywang 5f9e48d
fix: scope child spawn metadata
austinywang 65b125b
Merge branch 'main' of https://github.com/manaflow-ai/cmux into issue…
austinywang e6042cf
merge: keep feature submodule pointers
austinywang 57e8a30
fix: align bonsplit pointer with merged workspace API
austinywang e7e0678
fix: clear stale agent tree selection
austinywang 63bdc56
merge: resolve conflicts with main
austinywang 2c0630b
merge: resolve conflicts with main
austinywang 6eb5d9f
Merge remote-tracking branch 'origin/main' into issue-3932-subagent-t…
austinywang ab8f6a6
fix: retry feed focus registration when coordinator is unavailable
austinywang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLI copies child model to parent extra fields
Medium Severity
When a spawn tool's raw hook payload lacks a top-level
modelbut the tool input contains one,copyAgentGraphMetadatacopies the child'smodelfrom tool input into the event dict's top-levelmodelkey (sinceevent["model"]is still nil after the firstrawObjectloop). On the receiver, this becomes part ofextraFieldsJSON. The graph builder'ssessionModelfor spawn tools readsextra["model"], so it incorrectly assigns the child's model to the parent session. The tool inputmodelis already available separately viaWorkstreamPayload.toolUse'stoolInputJSON, making this copy both redundant and harmful.Additional Locations (1)
Packages/CMUXWorkstream/Sources/CMUXWorkstream/WorkstreamAgentGraph.swift#L639-L645Reviewed by Cursor Bugbot for commit ab8f6a6. Configure here.