Add terminal timestamps

.circleci/config.yml

@@ -0,0 +1,343 @@
+version: 2.1
+
+executors:
+  linux-python-node:
+    docker:
+      - image: cimg/python:3.12-node
+    resource_class: medium
+
+  linux-go:
+    docker:
+      - image: cimg/go:1.22
+    resource_class: medium
+
+  macos-xcode:
+    macos:
+      xcode: "16.4.0"
+    resource_class: m4pro.medium
+    shell: /bin/bash --login -eo pipefail
+
+commands:
+  checkout-source:
+    parameters:
+      submodules:
+        type: boolean
+        default: false
+    steps:
+      - checkout
+      - when:
+          condition: << parameters.submodules >>
+          steps:
+            - run:
+                name: Initialize submodules
+                no_output_timeout: 35m
+                command: |
+                  git submodule sync --recursive
+                  git submodule update --init --recursive
+
+  install-bun:
+    steps:
+      - run:
+          name: Install Bun
+          command: |
+            BUN_VERSION="1.3.3"
+            NPM_GLOBAL="$HOME/.npm-global"
+            mkdir -p "$NPM_GLOBAL"
+            npm install --global --prefix "$NPM_GLOBAL" "bun@$BUN_VERSION"
+            BASH_ENV="${BASH_ENV:-$HOME/.bash_env}"
+            echo "export PATH=\"$NPM_GLOBAL/bin:\$PATH\"" >> "$BASH_ENV"
+            export PATH="$NPM_GLOBAL/bin:$PATH"
+            test "$(bun --version)" = "$BUN_VERSION"
+
+  install-zig:
+    steps:
+      - run:
+          name: Install zig
+          no_output_timeout: 35m
+          command: |
+            export HOMEBREW_NO_AUTO_UPDATE=1
+            export HOMEBREW_NO_INSTALL_CLEANUP=1
+            export HOMEBREW_NO_ENV_HINTS=1
+            ./scripts/install-zig-ci.sh
+
+  install-rust:
+    steps:
+      - run:
+          name: Install Rust
+          no_output_timeout: 15m
+          command: ./scripts/install-rust-ci.sh
+
+  print-xcode:
+    steps:
+      - run:
+          name: Print Xcode environment
+          command: |
+            xcodebuild -version
+            xcrun --sdk macosx --show-sdk-path
+            sw_vers
+
+  restore-swift-package-cache:
+    parameters:
+      prefix:
+        type: string
+    steps:
+      - restore_cache:
+          keys:
+            - v1-spm-<< parameters.prefix >>-{{ checksum "cmux.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved" }}
+            - v1-spm-<< parameters.prefix >>-
+
+  save-swift-package-cache:
+    parameters:
+      prefix:
+        type: string
+      path:
+        type: string
+        default: .ci-source-packages
+    steps:
+      - save_cache:
+          key: v1-spm-<< parameters.prefix >>-{{ checksum "cmux.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved" }}
+          paths:
+            - << parameters.path >>
+
+  restore-zig-cache:
+    steps:
+      - restore_cache:
+          keys:
+            - v1-zig-{{ checksum "ghostty/build.zig.zon" }}-{{ checksum "ghostty/build.zig.zon.json" }}
+            - v1-zig-
+
+  save-zig-cache:
+    steps:
+      - save_cache:
+          key: v1-zig-{{ checksum "ghostty/build.zig.zon" }}-{{ checksum "ghostty/build.zig.zon.json" }}
+          paths:
+            - ~/.cache/zig
+
+  resolve-swift-packages:
+    parameters:
+      scheme:
+        type: string
+      source-packages-dir:
+        type: string
+        default: .ci-source-packages
+    steps:
+      - run:
+          name: Resolve Swift packages
+          no_output_timeout: 35m
+          command: |
+            SOURCE_PACKAGES_DIR="$PWD/<< parameters.source-packages-dir >>"
+            mkdir -p "$SOURCE_PACKAGES_DIR"
+
+            for attempt in 1 2 3; do
+              if xcodebuild -project cmux.xcodeproj -scheme << parameters.scheme >> -configuration Debug \
+                -clonedSourcePackagesDirPath "$SOURCE_PACKAGES_DIR" \
+                -resolvePackageDependencies; then
+                exit 0
+              fi
+              if [ "$attempt" -eq 3 ]; then
+                echo "Failed to resolve Swift packages after 3 attempts" >&2
+                exit 1
+              fi
+              echo "Package resolution failed on attempt $attempt, retrying..."
+              sleep $((attempt * 5))
+            done
+
+jobs:
+  macos-unit-tests:
+    executor: macos-xcode
+    steps:
+      - checkout-source:
+          submodules: true
+      - print-xcode
+      - install-rust
+      - restore-swift-package-cache:
+          prefix: unit
+      - restore-zig-cache
+      - run:
+          name: Download pre-built GhosttyKit.xcframework
+          no_output_timeout: 35m
+          command: ./scripts/download-prebuilt-ghosttykit.sh
+      - resolve-swift-packages:
+          scheme: cmux-unit
+      - run:
+          name: Run unit tests
+          no_output_timeout: 35m
+          command: |
+            export CMUX_SKIP_ZIG_BUILD=1
+            SOURCE_PACKAGES_DIR="$PWD/.ci-source-packages"
+            run_unit_tests() {
+              xcodebuild -project cmux.xcodeproj -scheme cmux-unit -configuration Debug \
+                -clonedSourcePackagesDirPath "$SOURCE_PACKAGES_DIR" \
+                -disableAutomaticPackageResolution \
+                -destination "platform=macOS" \
+                CMUX_SKIP_ZIG_BUILD=1 \
+                -skip-testing:cmuxTests/AppDelegateShortcutRoutingTests/testCmdWClosesWindowWhenClosingLastSurfaceInLastWorkspace \
+                test 2>&1
+            }
+
+            set +e
+            run_unit_tests | tee /tmp/test-output.txt
+            EXIT_CODE=${PIPESTATUS[0]}
+            OUTPUT=$(cat /tmp/test-output.txt)
+            set -e
+
+            if [ "$EXIT_CODE" -ne 0 ] && echo "$OUTPUT" | grep -q "Could not resolve package dependencies"; then
+              echo "SwiftPM package resolution failed, clearing caches and retrying once"
+              rm -rf ~/Library/Caches/org.swift.swiftpm
+              mkdir -p ~/Library/Caches/org.swift.swiftpm
+              rm -rf ~/Library/Developer/Xcode/DerivedData/cmux-*
+              rm -rf "$SOURCE_PACKAGES_DIR"
+              mkdir -p "$SOURCE_PACKAGES_DIR"
+              xcodebuild -project cmux.xcodeproj -scheme cmux-unit -configuration Debug \
+                -clonedSourcePackagesDirPath "$SOURCE_PACKAGES_DIR" \
+                -resolvePackageDependencies \
+                CMUX_SKIP_ZIG_BUILD=1
+              set +e
+              run_unit_tests | tee /tmp/test-output.txt
+              EXIT_CODE=${PIPESTATUS[0]}
+              OUTPUT=$(cat /tmp/test-output.txt)
+              set -e
+            fi
+
+            if [ "$EXIT_CODE" -ne 0 ]; then
+              SUMMARY=$(echo "$OUTPUT" | grep "Executed.*tests.*with.*failures" | tail -1)
+              if echo "$SUMMARY" | grep -q "(0 unexpected)"; then
+                echo "All failures are expected, treating as pass"
+              else
+                echo "Unexpected test failures detected"
+                exit 1
+              fi
+            fi
+      - run:
+          name: Run bundled Ghostty theme picker helper regression
+          no_output_timeout: 35m
+          command: |
+            CMUX_SKIP_ZIG_BUILD=1 \
+              CMUX_SOURCE_PACKAGES_DIR="$PWD/.ci-source-packages" \
+              ./tests/test_bundled_ghostty_theme_picker_helper.sh
+      - run:
+          name: Run CLI no-socket regressions
+          no_output_timeout: 35m
+          command: |
+            CLI_BIN="$(
+              find "$HOME/Library/Developer/Xcode/DerivedData" -path "*/Build/Products/Debug/cmux" -exec stat -f '%m %N' {} \; \
+                | sort -nr \
+                | head -1 \
+                | cut -d' ' -f2-
+            )"
+            if [ -z "${CLI_BIN:-}" ] || [ ! -x "$CLI_BIN" ]; then
+              echo "cmux CLI binary not found in DerivedData" >&2
+              exit 1
+            fi
+
+            CMUX_CLI_BIN="$CLI_BIN" python3 tests/test_cli_version_memory_guard.py
+            CMUX_CLI_BIN="$CLI_BIN" python3 tests/test_cli_contract_help.py
+            CMUX_CLI_BIN="$CLI_BIN" python3 tests/test_cli_layout_focus_contract.py
+            CMUX_CLI_BIN="$CLI_BIN" python3 tests/test_cli_socket_operation_deadline.py
+            CMUX_CLI_BIN="$CLI_BIN" python3 tests/test_cli_omo_openagent_plugin_migration.py
+            CMUX_CLI_BIN="$CLI_BIN" python3 tests/test_cli_socket_autodiscovery.py
+            CMUX_CLI_BIN="$CLI_BIN" python3 tests/test_claude_hook_clear_running_status.py
+      - save-swift-package-cache:
+          prefix: unit
+      - save-zig-cache
+
+  macos-debug-build:
+    executor: macos-xcode
+    steps:
+      - checkout-source:
+          submodules: true
+      - print-xcode
+      - install-rust
+      - restore-swift-package-cache:
+          prefix: debug-build
+      - restore-zig-cache
+      - run:
+          name: Download pre-built GhosttyKit.xcframework
+          no_output_timeout: 35m
+          command: ./scripts/download-prebuilt-ghosttykit.sh
+      - resolve-swift-packages:
+          scheme: cmux
+      - run:
+          name: Build app and capture warnings
+          no_output_timeout: 35m
+          command: |
+            export CMUX_SKIP_ZIG_BUILD=1
+            SOURCE_PACKAGES_DIR="$PWD/.ci-source-packages"
+            xcodebuild -project cmux.xcodeproj -scheme cmux -configuration Debug \
+              -clonedSourcePackagesDirPath "$SOURCE_PACKAGES_DIR" \
+              -disableAutomaticPackageResolution \
+              -destination "platform=macOS" \
+              CMUX_SKIP_ZIG_BUILD=1 \
+              build 2>&1 | tee /tmp/cmux-build-output.txt
+      - run:
+          name: Validate Swift warning budget
+          command: python3 scripts/swift_warning_budget.py --log /tmp/cmux-build-output.txt
+      - save-swift-package-cache:
+          prefix: debug-build
+      - save-zig-cache
+
+  macos-release-build:
+    executor: macos-xcode
+    steps:
+      - checkout-source:
+          submodules: true
+      - print-xcode
+      - install-rust
+      - restore-swift-package-cache:
+          prefix: release
+      - restore-zig-cache
+      - run:
+          name: Download pre-built GhosttyKit.xcframework
+          no_output_timeout: 35m
+          command: ./scripts/download-prebuilt-ghosttykit.sh
+      - resolve-swift-packages:
+          scheme: cmux
+          source-packages-dir: .spm-cache
+      - run:
+          name: Build universal app (Release)
+          no_output_timeout: 35m
+          command: |
+            export CMUX_SKIP_ZIG_BUILD=1
+            xcodebuild -project cmux.xcodeproj -scheme cmux -configuration Release -derivedDataPath build-universal \
+              -destination "generic/platform=macOS" \
+              -clonedSourcePackagesDirPath .spm-cache \
+              -disableAutomaticPackageResolution \
+              ARCHS="arm64 x86_64" \
+              ONLY_ACTIVE_ARCH=NO \
+              CMUX_SKIP_ZIG_BUILD=1 \
+              CODE_SIGNING_ALLOWED=NO ASSETCATALOG_COMPILER_APPICON_NAME=AppIcon-Nightly build
+      - save-swift-package-cache:
+          prefix: release
+          path: .spm-cache
+      - save-zig-cache
+
+workflows:
+  ci-trusted:
+    when:
+      and:
+        - << pipeline.git.branch >>
+        - not:
+            matches:
+              pattern: "^pull/.*"
+              value: << pipeline.git.branch >>
+    jobs:
+      - macos-unit-tests
+      - macos-debug-build
+      - macos-release-build
+
+  ci-gated:
+    when:
+      or:
+        - matches:
+            pattern: "^pull/.*"
+            value: << pipeline.git.branch >>
+        - << pipeline.git.tag >>
+    jobs:
+      - hold-for-approval:
+          type: approval
+      - macos-unit-tests:
+          requires: [hold-for-approval]
+      - macos-debug-build:
+          requires: [hold-for-approval]
+      - macos-release-build:
+          requires: [hold-for-approval]

.github/review-bot-rules/runtime-no-hacky-sleeps.md

@@ -1,8 +1,6 @@
 # Runtime No Hacky Sleeps
 
-Scope: TypeScript, JavaScript, shell, and non-Swift build/runtime scripts. Swift timing and blocking primitives are covered by `swift-blocking-runtime.md`.
-
-GitHub Actions workflow and action YAML is intentionally out of scope. Fixed waits there are CI orchestration unless the PR also changes a covered runtime script that uses the wait as product synchronization.
+Scope: TypeScript, JavaScript, shell, and non-Swift runtime scripts. Swift timing and blocking primitives are covered by `swift-blocking-runtime.md`.
 
 Flag fixed delays used as synchronization in production application or runtime code.
 
@@ -15,7 +13,6 @@ Report a failure when the diff introduces or materially expands any of these in
 Allowed cases:
 
 - Deterministic sleeps in tests or explicit test-only scaffolding.
-- GitHub Actions workflow or action YAML sleeps used only for CI orchestration.
 - User-visible animation or progress timing where the timer is purely presentation and not coordination.
 - Production retry or timeout logic implemented through a dedicated cancellation-aware abstraction with bounded deadlines and tests, where the delay is part of the product behavior rather than a race repair.
 - Existing delay code that the PR does not introduce or worsen.