Repository navigation
Fix Claude resume cwd - #3816
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📝 WalkthroughWalkthroughSessionEntry's resume command is refactored to unify cwd handling: ChangesResume Command cwd Wrapping Refactor
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR fixes a Claude resume failure that occurred when
Confidence Score: 5/5Safe to merge — a straightforward consolidation of an existing cwd-prefix path into the main resume command property, with both callsites and all affected tests updated consistently. The logic moved is already battle-tested (it previously lived in No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[SessionEntry.resumeCommand] --> B{resumeCommandWithoutWorkingDirectory?}
B -- nil --> C[return nil]
B -- command --> D{resumeWorkingDirectory?}
D -- nil or .ignore --> E[return command as-is]
D -- cwd --> F["return 'cd shellQuote(cwd) && command'"]
G[ContentView.resumeSession] --> A
H[SessionIndexView Copy Resume] --> A
Reviews (2): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile |
Summary:
Testing:
Closes #3815
Note
Low Risk
Low risk: small behavior change limited to how session resume commands are constructed and used; main risk is altering quoting/
cdprefix semantics for some agents’ resume flows.Overview
Fixes session-index resume failures (notably for Claude) by making
SessionEntry.resumeCommandincludecd <recorded cwd> && …when aresumeWorkingDirectoryis available, and removing the separateresumeCommandWithCwdvariant.Routes both the UI resume action (
ContentView) and “Copy Resume Command” menu item (SessionIndexView) through the updatedresumeCommand, and updates/adds unit tests to validate cwd-changing behavior while keeping registered agents withcwd == .ignoreunchanged.Reviewed by Cursor Bugbot for commit f917cef. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Fixes resume failures for Claude when run from a different directory by cd-ing into the session’s recorded cwd before invoking the agent; both Resume and Copy Resume now use this cwd-safe command and agents marked to ignore cwd are unchanged. Fixes #3815.
SessionEntry.resumeCommandnow prefixescd <cwd> &&whenresumeWorkingDirectoryis set; removedresumeCommandWithCwd.resumeCommand.Written for commit f917cef. Summary will update on new commits.
Summary by CodeRabbit