Skip to content

Agent pane: Needs your input pill, option rows and custom answer restyled - #36877

Open
teamleaderleo wants to merge 4 commits into
feat-cmux-nextfrom
lane/needs-input-card-restyle
Open

teamleaderleo wants to merge 4 commits into
feat-cmux-nextfrom
lane/needs-input-card-restyle

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Leo, 2026-11-05, on the chat's Needs your input pill and question card (his screenshot showed the amber pill, the bold option rows and the typed custom answer as a filled block):

I feel like this is kind of ugly. But also I was thinking, like the horizontal tab, that has a different kind of icon than the sidebar icon. Like it's a yellow instead of an orange, and it's like a yellow bright dot, which I kind of like a little bit more than the sidebar. What if we try that yellow dot thing that we currently have in the horizontal tab and put that in the sidebar? And in addition, look, when I'm hovering over the tab, like I don't need to also see the icon. We can just treat it like how we already treat it, like the sidebar. Like the button replaces the spinner on the top when you hover over it, like just like the sidebar with the workspaces.

This PR covers the first sentence: the pill, the option rows and the custom-answer row. The sidebar dot and the tab hover are separate PRs.

What changes

Before: a bold amber block for the pill (dot, words and chevron all inside one rounded rectangle), bold question and option labels, a typed custom answer drawn as a filled highlighted row, a ruled footer with a bare esc and a single ⌘↩ keycap, and an empty band under the rows.

After, matching the permission card restyle in #36189:

  • Pill. The question card's pill is one capsule tinted with the mark holding the Needs you dot (.acpmux-needs-you-dot, --acpmux-needs-you-mark), the words and the fold chevron, in regular weight, the same capsule the floating pill draws. The floating Jump to latest pill (JumpPill.tsx) becomes a 32 px capsule with the same dot and the words in the mark colour, also in regular weight.
  • Option rows. The question and the option labels are regular weight. Descriptions stay muted.
  • Custom answer. While you type, the row has no fill. The words sit in a quiet field with a hairline ring that firms up while it has focus, so it reads as somewhere to type, not as a selected block.
  • Footer. No rule and no empty band. Skip is a quiet filled button and Submit is filled with the text colour, both on the body text size. Each shows Agent pane: permission card at Claude desktop's level, Esc and ⌘↩ keycaps; Needs your input pill on the live line #36189's outlined keycaps: esc, then ⌘ and ↩ as one keycap each.

Gallery (agent-pane.question-card), three looks on the card Leo showed (options plus a typed custom answer), in dark and light:

  • restyle-capsule (shipped): tinted capsule pill, quiet field for the custom answer.
  • restyle-outline: ringed pill, full-width ruled rows, underlined custom answer.
  • restyle-bare: dot and words with no capsule, accent-filled radio, custom answer as a soft filled row.

I shipped capsule because it is the only look whose pill matches #36189's live-line pill. Outline's rules bring back the heavy look. Bare keeps the filled block Leo called out.

Overlap with #36189

#36189 (chat-rendering lane) restyles the permission card and adds the live-line pill. This PR does not touch its files except two:

Testing

  • New in test/question-card-submit.test.tsx: the pill is the Needs you dot followed by a capsule with the words and the chevron, and Submit shows ⌘ and ↩ as two keycaps with aria-keyshortcuts="Meta+Enter".
  • test/needs-input-mark-color.test.ts now reads the question pill's dot as .acpmux-needs-you-dot.

Observed / Not run

  • Ran locally and passed: bun test on question-card-submit, question-consent-card, question-card-click-selects, question-card-reply-failed, agent-pane-needs-you, agent-pane-trust-never-hides-asks and src/agent-session/acpmux/question. Also passed: check:design-tokens, type-scale, layout-grid, design-scale, ui-review, text-focus, dialog-keys, icon-scale, vp fmt --check, oxlint on the changed TS files, and prepush-gate.py.
  • clickable-cursor.test.ts times out on this host on base too (2 fail on base, 1 with this change), so it is not this PR's.
  • Through cmux-ci test, at head d5fce9b: the browser lanes (needs-input-mark-color, agent-question-card) and question-card-submit passed, 23 tests (run 42127300276). vp check (type check, 4634 files) and vp lint (0 warnings) passed too (run 42128098289).
  • Not run: a Mac build. The change is webview CSS and TSX only, so a fleet build adds nothing.

Changelog

  • Changed: The agent chat's "Needs your input" pill and question card are restyled: a dot with a tinted capsule, lighter option rows, a quiet field for a custom answer, and Skip and Submit with outlined keycaps.

Agent session: agent session

🤖 Generated with Claude Code

…yled

Leo 2026-11-05 on the pill and question card: "I feel like this is kind of ugly."

The question card's pill is the one Needs you dot followed by a capsule
tinted with the mark (regular weight, chevron inside), matching the
live-line pill of #36189. The floating Needs your input pill becomes a
capsule with the same dot and the words in the mark colour. Question and
option labels drop to regular weight. The typed custom answer no longer
fills its row; it sits in a quiet hairline field. Skip and Submit use
the permission card's outlined keycaps (esc, then ⌘ and ↩ as one keycap
each), and the footer loses its rule and empty band.

Gallery: restyle-capsule (shipped), restyle-outline, restyle-bare.
Tests: question-card-submit (new pill and keycap test), consent,
click-selects, reply-failed, needs-you and question unit tests pass
locally; the browser lanes were skipped on this host.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-e55e35af44c7fcff1075
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review ca567ad: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr36877 -f ref=lane/needs-input-card-restyle -f platform=macos -f backend_mode=local

Passes: CI passes on dc0501a110.

CI passes on dc0501a110 (run 42256836465 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

web and size checks: green

Gallery before/after for dc0501a: 16 states rendered, 5 images differ, 2509 more touched states not rendered. Images are in the run's artifact, not on this public PR; the independent review of this head reads them on its own, so the PR needs no hand-made screenshots of these states.

gh run download 42256835601 -R manaflow-ai/cmux -n gallery-advisory-36877-dc0501a11051695418aa278554d8099e9e19e829 (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.access-offer/turn-no-credits Apple System Colors Light unchanged 0% own styles.css
agent-pane.access-offer/turn-no-credits Apple System Colors unchanged 0% own styles.css
agent-pane.access-offer/turn-low-credits Apple System Colors Light unchanged 0% own styles.css
agent-pane.access-offer/turn-low-credits Apple System Colors unchanged 0% own styles.css
agent-pane.access-offer/turn-no-offer Apple System Colors Light unchanged 0% own styles.css
agent-pane.access-offer/turn-no-offer Apple System Colors unchanged 0% own styles.css
agent-pane.activity-line-looks/none Apple System Colors Light unchanged 0% own styles.css
agent-pane.activity-line-looks/none Apple System Colors unchanged 0% own styles.css
agent-pane.activity-line-looks/spinner Apple System Colors changed 0.043% own styles.css
agent-pane.activity-line-looks/spinner Apple System Colors Light changed 0.0331% own styles.css
agent-pane.activity-line-looks/kind Apple System Colors changed 0.0119% own styles.css
agent-pane.activity-line-looks/kind Apple System Colors Light changed 0.006% own styles.css
agent-pane.activity-line-looks/aligned Apple System Colors Light unchanged 0% own styles.css
agent-pane.activity-line-looks/aligned Apple System Colors unchanged 0% own styles.css
agent-pane.add-project-panel/environment Apple System Colors Light unchanged 0% own styles.css
agent-pane.add-project-panel/environment Apple System Colors unchanged 0% own styles.css
agent-pane.add-project-panel/sources Apple System Colors Light unchanged 0% own styles.css
agent-pane.add-project-panel/sources Apple System Colors unchanged 0% own styles.css
agent-pane.add-project-panel/directory Apple System Colors Light unchanged 0% own styles.css
agent-pane.add-project-panel/directory Apple System Colors unchanged 0% own styles.css
agent-pane.add-project-panel/long-directory Apple System Colors Light unchanged 0% own styles.css
agent-pane.add-project-panel/long-directory Apple System Colors unchanged 0% own styles.css
agent-pane.add-project-panel/keyboard Apple System Colors Light unchanged 0% own styles.css
agent-pane.add-project-panel/keyboard Apple System Colors unchanged 0% own styles.css
agent-pane.add-project-panel/browse-error Apple System Colors Light unchanged 0% own styles.css
agent-pane.add-project-panel/browse-error Apple System Colors unchanged 0% own styles.css
agent-pane.agent-call-card/before-closed Apple System Colors Light unchanged 0% own styles.css
agent-pane.agent-call-card/before-closed Apple System Colors unchanged 0% own styles.css
agent-pane.agent-call-card/before-open Apple System Colors changed 0.0044% own styles.css
agent-pane.agent-call-card/before-open Apple System Colors Light unchanged 0% own styles.css
agent-pane.agent-call-card/report-closed Apple System Colors Light unchanged 0% own styles.css
agent-pane.agent-call-card/report-closed Apple System Colors unchanged 0% own styles.css

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

@teamleaderleo teamleaderleo added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 5, 2026
…apsule

The card's pill drew the Needs you dot outside the tinted capsule, so it read as a stray mark beside
it while the floating pill (JumpPill) holds its dot inside. Both pills now draw one capsule with the
dot, the words and the chevron.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-e55e35af44c7fcff1075
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex, router-review): SHIP at ca567ad

Reviewer: codex gpt-6.1-sol xhigh, fast tier.

SHIP at ca567ad

Visual verdict: retained pairs differ only by spinner animation phase; no retained pair covers the changed question card.

No correctness or regression issues found in the changed TSX/CSS.

Follow-ups: none

cmux-bot[bot]
cmux-bot Bot previously approved these changes Nov 5, 2026

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves ca567ad: an independent review passed this exact head (router-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

@teamleaderleo teamleaderleo changed the title Agent pane: Needs your input pill, option rows and custom answer restyled like Claude desktop's Agent pane: Needs your input pill, option rows and custom answer restyled Nov 5, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Found 16 test failures on Blacksmith runners:

Failures

Test View Logs
test/accent-glass-invariants-3.test.ts/accent-glass-invariants-3.test View Logs
test/accent-glass-invariants-3.test.ts/accent-glass-invariants-3.test View Logs
test/agent-pane-no-capsules.test.ts/agent-pane-no-capsules.test View Logs
test/agent-pane-no-capsules.test.ts/agent-pane-no-capsules.test View Logs
test/agent-pane-sent-images.test.ts/agent-pane-sent-images.test View Logs
test/agent-pane-sent-images.test.ts/agent-pane-sent-images.test View Logs
test/composer-one-row-layout.test.ts/composer-one-row-layout.test View Logs
test/composer-one-row-layout.test.ts/composer-one-row-layout.test View Logs
test/popup-surface.test.ts/popup-surface.test View Logs
test/popup-surface.test.ts/popup-surface.test View Logs

...and 6 more test failures. View all on Blacksmith

Blacksmith runners detected OOM events on the following jobs:

Job Details
web / react-apps-base-check (4) View Job

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 6, 2026 00:53 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 6, 2026 00:54 Inactive
@cmux-bot
cmux-bot Bot dismissed their stale review November 6, 2026 00:59

A newer verdict blocks c099f89 (no independent SHIP at the head).

@teamleaderleo teamleaderleo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (codex gpt-6.1-sol xhigh, next-review, since=20261106T022327Z): SHIP at c099f89

SHIP at c099f89

Visual verdict: Supplied gallery pairs are unchanged aside from tiny unrelated raster differences; changed question-card states are not included in the retained images.

Follow-ups: none

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, sweep, via the review router; full diff from merge base 8a57dbf to this head): SHIP at dc0501a

No P1/P2 findings.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — dc0501a1 Deployed Nov 6, 2026 by teamleaderleo via cmux-tui tree preflight #119301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant