Repository navigation
Agent pane: Needs your input pill, option rows and custom answer restyled - #36877
teamleaderleo wants to merge 4 commits into
Conversation
…yled Leo 2026-11-05 on the pill and question card: "I feel like this is kind of ugly." The question card's pill is the one Needs you dot followed by a capsule tinted with the mark (regular weight, chevron inside), matching the live-line pill of #36189. The floating Needs your input pill becomes a capsule with the same dot and the words in the mark colour. Question and option labels drop to regular weight. The typed custom answer no longer fills its row; it sits in a quiet hairline field. Skip and Submit use the permission card's outlined keycaps (esc, then ⌘ and ↩ as one keycap each), and the footer loses its rule and empty band. Gallery: restyle-capsule (shipped), restyle-outline, restyle-bare. Tests: question-card-submit (new pill and keycap test), consent, click-selects, reply-failed, needs-you and question unit tests pass locally; the browser lanes were skipped on this host. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-e55e35af44c7fcff1075
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Passes: CI passes on CI passes on Written by web and size checks: green Gallery before/after for
States
Pick other states with a |
…apsule The card's pill drew the Needs you dot outside the tinted capsule, so it read as a stray mark beside it while the floating pill (JumpPill) holds its dot inside. Both pills now draw one capsule with the dot, the words and the chevron. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-e55e35af44c7fcff1075
|
Review (codex, router-review): SHIP at ca567ad Reviewer: codex gpt-6.1-sol xhigh, fast tier. SHIP at ca567ad Visual verdict: retained pairs differ only by spinner animation phase; no retained pair covers the changed question card. No correctness or regression issues found in the changed TSX/CSS. Follow-ups: none |
|
Found 16 test failures on Blacksmith runners: Failures
...and 6 more test failures. View all on Blacksmith Blacksmith runners detected OOM events on the following jobs:
|
A newer verdict blocks c099f89 (no independent SHIP at the head).
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo, 2026-11-05, on the chat's Needs your input pill and question card (his screenshot showed the amber pill, the bold option rows and the typed custom answer as a filled block):
This PR covers the first sentence: the pill, the option rows and the custom-answer row. The sidebar dot and the tab hover are separate PRs.
What changes
Before: a bold amber block for the pill (dot, words and chevron all inside one rounded rectangle), bold question and option labels, a typed custom answer drawn as a filled highlighted row, a ruled footer with a bare
escand a single⌘↩keycap, and an empty band under the rows.After, matching the permission card restyle in #36189:
.acpmux-needs-you-dot,--acpmux-needs-you-mark), the words and the fold chevron, in regular weight, the same capsule the floating pill draws. The floating Jump to latest pill (JumpPill.tsx) becomes a 32 px capsule with the same dot and the words in the mark colour, also in regular weight.esc, then⌘and↩as one keycap each.Gallery (
agent-pane.question-card), three looks on the card Leo showed (options plus a typed custom answer), in dark and light:restyle-capsule(shipped): tinted capsule pill, quiet field for the custom answer.restyle-outline: ringed pill, full-width ruled rows, underlined custom answer.restyle-bare: dot and words with no capsule, accent-filled radio, custom answer as a soft filled row.I shipped capsule because it is the only look whose pill matches #36189's live-line pill. Outline's rules bring back the heavy look. Bare keeps the filled block Leo called out.
Overlap with #36189
#36189 (chat-rendering lane) restyles the permission card and adds the live-line pill. This PR does not touch its files except two:
styles.css: only the question card block (lines around 806 to 871). Agent pane: permission card at Claude desktop's level, Esc and ⌘↩ keycaps; Needs your input pill on the live line #36189 edits the permission block further down.design-tokens-baseline.jsonl: one shrink. Thestyles.cssheight line sits next to the font-weight line Agent pane: permission card at Claude desktop's level, Esc and ⌘↩ keycaps; Needs your input pill on the live line #36189 changes, so whichever lands second regenerates it withbun scripts/check-design-tokens.ts --update-baseline.Testing
test/question-card-submit.test.tsx: the pill is the Needs you dot followed by a capsule with the words and the chevron, and Submit shows⌘and↩as two keycaps witharia-keyshortcuts="Meta+Enter".test/needs-input-mark-color.test.tsnow reads the question pill's dot as.acpmux-needs-you-dot.Observed / Not run
bun teston question-card-submit, question-consent-card, question-card-click-selects, question-card-reply-failed, agent-pane-needs-you, agent-pane-trust-never-hides-asks andsrc/agent-session/acpmux/question. Also passed:check:design-tokens, type-scale, layout-grid, design-scale, ui-review, text-focus, dialog-keys, icon-scale,vp fmt --check, oxlint on the changed TS files, andprepush-gate.py.clickable-cursor.test.tstimes out on this host on base too (2 fail on base, 1 with this change), so it is not this PR's.cmux-ci test, at head d5fce9b: the browser lanes (needs-input-mark-color,agent-question-card) andquestion-card-submitpassed, 23 tests (run 42127300276).vp check(type check, 4634 files) andvp lint(0 warnings) passed too (run 42128098289).Changelog
Agent session: agent session
🤖 Generated with Claude Code