Skip to content

cmux-tui: fix the base clippy red in the action argument contract test - #36597

Merged
cmux-bot[bot] merged 1 commit into
feat-cmux-nextfrom
fix/action-arg-contract-semicolon
Nov 5, 2026
Merged

cmux-bot[bot] merged 1 commit into
feat-cmux-nextfrom
fix/action-arg-contract-semicolon

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

What

Adds the missing ; after current = None at cmux-tui/crates/cmux-tui/src/cli/tests/action_argument_contract.rs:417 (from #36260). clippy::semicolon_if_nothing_returned under -D warnings fails the required "clippy (changed cmux-tui packages)" check on every PR that changes a cmux-tui package, for example #36511.

Changelog

none

Tests

The PR's own clippy check. No behavior change.

Agent session: agent session

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the clippy::semicolon_if_nothing_returned warning in the cmux-tui action argument contract test, which was failing the required clippy check on every PR that touches a cmux-tui package.

Adds the missing semicolon after current = None; no behavior change.

Written for commit 3c4f614. Summary will update on new commits.

View guided diff Turn on auto-fix

…est (base clippy red)

clippy::semicolon_if_nothing_returned at action_argument_contract.rs:417
(from #36260) fails `clippy -D warnings` on every PR that touches a
cmux-tui package.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 3c4f614: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr36597 -f ref=fix/action-arg-contract-semicolon -f platform=macos -f backend_mode=local

Shipped in:

@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 5, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex, router-review): SHIP at 3c4f614

Reviewer: codex gpt-6-astra high, fast tier.

SHIP at 3c4f614

Visual verdict: unchanged by this diff

The semicolon is behavior-preserving and fixes the reported clippy lint. Rust tooling was unavailable in the review environment.

Follow-ups: none

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves 3c4f614: an independent review passed this exact head (router-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

@blacksmith-sh

blacksmith-sh Bot commented Nov 5, 2026

Copy link
Copy Markdown

Found 7 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmpdoh_1_si/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpxuoiwc1d/summary-missing.json (live):/summary-missing.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
test_every_routed_input_triggers_the_workflow (main.PullRequestTiers.test_every_rou
ted_input_triggers_the_workflow) (path='skills/cmux-live/SKILL.md')
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@cmux-bot
cmux-bot Bot merged commit 5c95d60 into feat-cmux-next Nov 5, 2026
163 of 174 checks passed
@cmux-bot
cmux-bot Bot deleted the fix/action-arg-contract-semicolon branch November 5, 2026 13:46
austinywang added a commit that referenced this pull request Nov 5, 2026
No conflicts. Brings the base fixes for two reds the PR inherited at
fcd98f7: the missing semicolon in action_argument_contract.rs
(#36597) and the journey's Zig
install (#36618).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch was previously deployed

3 inactive deployments
artifacts — 3c4f614c Deployed Nov 5, 2026 by teamleaderleo via publish tree-addressed cmux-tui #116353
sentry-dsyms — 3c4f614c Deployed Nov 5, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #116353
ci-routing-agent — 3c4f614c Deployed Nov 5, 2026 by teamleaderleo via cmux-tui tree preflight #116353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant