Skip to content

cloud receiver: log whether a policy read grants local admission (admit_until) and how long it took - #36551

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
receiver-log-admission
Nov 5, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
receiver-log-admission

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

The Cloud receiver's journal could not show whether local admission (#36014, cmux-platform#827) was granted. kept the current policy is logged only when a read gets no answer under admit_until, and an answered read said nothing about it. On a prod machine on 2026-11-05 the only line was receiver policy read took 6970 ms ..., which left admission unconfirmed.

An answered policy read now logs whether admit_until is present and how long the read took:

cmux link: receiver policy read took 212 ms; admit_until present (600 s of local admission)
cmux link: receiver policy read took 212 ms; admit_until absent (no local admission)

It is written on the first read and whenever admission appears or ends, never once per read; the lease is about 30 s.

Tests: link::native_process 9 pass (2 new); clippy -p cmux-tui --all-targets -D warnings clean.

Changelog

  • Cloud machine logs say whether the receiver's policy grants local admission, and how long the read took.

🤖 Generated with Claude Code

Agent session: agent session


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Cloud receiver journal lines now show whether a policy read granted local admission—previously only unanswered reads logged kept the current policy, and answered reads said nothing about admit_until. An answered read now logs whether admit_until is present and how long the read took, written on the first read and whenever admission appears or ends, not once per read.

Written for commit 56bad8a. Summary will update on new commits.

View guided diff Turn on auto-fix

…resent and how long the read took

Logged on the first read and whenever local admission appears or ends, so
the journal shows whether the control plane granted it without a line per
read.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5
@cursor

cursor Bot commented Nov 5, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 56bad8a: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr36551 -f ref=receiver-log-admission -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 4f39126 to compare; do not merge until green; see lane-rules

Shipped in:

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

…hecks which reads write a line (review of #36551)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5
@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 5, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Found 11 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmpn84vvqwk/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmpvsj8ob43/summary-fail.json (live):/summary-fail.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
main.DeveloperIdAppTests.test_download_prints_the_active_profile_only/
test_download_prints_the_active_profile_only
View Logs
stubs: /System/Library/Frameworks/Security.framework/Versions/A/Security has no stub/
Security has no stub
View Logs
stubs: CoreFoundation.tbd: install-name /System/Library/Frameworks/
CoreFoundation.framework/Versions/A/CoreFoundation, missing 1: ['_CFRetain']/
CoreFoundation, missing 1: ['_CFRetain']
View Logs
stubs: CoreFoundation.tbd: install-name /System/Library/Frameworks/
CoreFoundation.framework/Versions/A/CoreFoundation, missing 1: ['_log2']/
CoreFoundation, missing 1: ['_log2']
View Logs

...and 1 more test failures. View all on Blacksmith

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo teamleaderleo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (codex gpt-6-astra high, next-review, since=20261105T130227Z): SHIP at 56bad8a

SHIP at 56bad8a
Visual verdict: unchanged by this diff

Follow-ups: none

@teamleaderleo
teamleaderleo merged commit 784dbb3 into feat-cmux-next Nov 5, 2026
180 of 184 checks passed
@teamleaderleo
teamleaderleo deleted the receiver-log-admission branch November 5, 2026 13:19
teamleaderleo added a commit that referenced this pull request Nov 5, 2026
…ceiver policy-read log #36551)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-548f18c0a6d1ebb48240
cmux-bot Bot pushed a commit that referenced this pull request Nov 5, 2026
…ceiver policy-read log #36551) (#36640)

* Cloud VM image: pin cmux-tui 6eabd68 (receiver logs each policy read's admission and duration, #36551)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-548f18c0a6d1ebb48240

* Cloud VM image: pin cmux-tui cbbeec1 (acpmux daemon enroll #36564, receiver policy-read log #36551)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-548f18c0a6d1ebb48240

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch was previously deployed

3 inactive deployments
artifacts — 56bad8a2 Deployed Nov 5, 2026 by teamleaderleo via publish tree-addressed cmux-tui #116216
sentry-dsyms — 56bad8a2 Deployed Nov 5, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #116216
ci-routing-agent — 56bad8a2 Deployed Nov 5, 2026 by teamleaderleo via cmux-tui tree preflight #116216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant