Skip to content

cloud: a repository off GitHub that does not clone ends failed, not needs_github - #36518

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/cloud-repo-other-host-failure
Nov 5, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/cloud-repo-other-host-failure

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Off GitHub, a cmux cloud new-machine --repo clone that fails (a private, missing or offline repository on GitLab, Codeberg or a company server) now ends failed and says why. Before, it ended needs_github, so the app asked the person to connect GitHub and the runner waited to retry after that connect, which can never help a repository on another host. Leo (2026-11-05): "there's GitHub ... and then there's presumably other services, like there's GitLab or whatever."

GitHub repositories keep the needs_github path unchanged.

  • CloudMachineRepo.swift: after every clone path fails, a non-GitHub repo exits through die (status failed, exit 1) before needs_github is set.
  • New test: anotherHostThatDoesNotCloneFailsInsteadOfWaitingForGitHub.

Changelog

Fixed: a Cloud machine whose repository on another host (not GitHub) cannot be cloned reports the failure instead of asking for GitHub access.

Agent session: agent session

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes cmux cloud new-machine --repo so that a failed clone from a non-GitHub host (GitLab, Codeberg, a company server) now ends failed and reports why. Before, it ended needs_github, so the app asked the user to connect GitHub and the runner waited to retry after that connection — which can never help a repository on another host.

GitHub repositories keep the needs_github path unchanged.

Written for commit 343dfff. Summary will update on new commits.

View guided diff Turn on auto-fix

@teamleaderleo teamleaderleo added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 343dfff: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr36518 -f ref=lane/cloud-repo-other-host-failure -f platform=macos -f backend_mode=local

Shipped in:

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/42045816653 at 446a051 failed: cmux-next fleet Release compile.
Those jobs last passed at bb2ff7a. This pull request is one of 5 merged since: #36564, #36567, #36547, #36518, #36503.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@teamleaderleo teamleaderleo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (gpt-6.1-sol): SHIP at 343dfff

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Landing at 343dfff: router-review SHIP at this exact head (gpt-6.1-sol xhigh). CloudMachineRepoTests (26 tests, including the new one) passes at this head.

184 of 185 checks pass. The one red is the non-required cmux-next swift test. Its ten failing tests are all UI and sidebar tests:

  • withAPickTheNameDrawsIt
  • thePinStartsOnAnUnpinnedRowsIconColumn
  • noViewDrawsTheStockTooltip
  • reduceMotionTurningOnStopsAPulsingBubble
  • theQueuedFocusedPaneGetsTheNextFramesSurface
  • everySuiteThatOpensAWindowClosesWhatItLeaves
  • aGlassPanelIsTheSidebarCardsSurfaceAndACardIsNot
  • aPickWhileTheCardIsOpenRecolorsTheName
  • anUnansweredPlacementIsSentAgainNotUndone
  • aChatTitledOnlyByItsFirstPromptKeepsTheDaemonsName

None of them covers CloudMachineRepo, the only source file this PR changes.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 343dfff9 Deployed Nov 5, 2026 by teamleaderleo via namespace autofix #15269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant