Repository navigation
test(nightly): read the one-mini timeout expressions with the mode off (release-notary base red) - #36249
Merged
Conversation
132f7ce made nightly.yml's timeout-minutes `${{ vars.CI_NIGHTLY_MINI != '' && X || Y }}` expressions; test_gh_budget_wait.py and test_nightly_delivery_concurrency.py still int() them, so release-notary's "publish-path gh calls wait through a rate limit" and "builds and signers never cancel" steps fail with ValueError on every PR. Both now check the limit with one-mini mode off, the smaller one, as test_nightly_sign_runner.py does. Red at 68927f4: python3 tests/test_gh_budget_wait.py (3 errors), python3 tests/test_nightly_delivery_concurrency.py (ValueError). Green after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-f08996319b14c7281027
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
Collaborator
Author
|
Owned by an agent session · session |
|
Found 3 test failures on Blacksmith runners: Failures
|
Collaborator
Author
…-mini expression too 132f7ce's expressions also broke tests/test_nightly_universal_build.sh ("the six-hour schedule must allow 90 minutes") and tests/test_nightly_cmux_tui_resolve.py ("a resolver that never waits needs no 55-minute timeout"): red on base, green here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-f08996319b14c7281027
…6234) test_ci_warm_sources.py's test_every_compile_job_names_its_warm_sources fails on feat-cmux-next since #36234 added the job; it builds cmux-tui cold, like backend.yml:journey-staging. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-f08996319b14c7281027
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 5, 2026 07:05 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 5, 2026 07:05 — with
GitHub Actions
Inactive
Collaborator
Author
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Summary
Fixes a base red in release-notary. Since 132f7ce ("one-mini jobs get 120 more minutes for glaeda's capacity wait"), nightly.yml's
timeout-minutesvalues are expressions like${{ vars.CI_NIGHTLY_MINI != '' && 300 || 180 }}.tests/test_gh_budget_wait.pyandtests/test_nightly_delivery_concurrency.pystill callint()on them, so on every PR (#34670, #36065, #36079, #36212, #36233) these steps fail with a ValueError:The same expressions also break two more release-notary steps: "Validate universal nightly workflow" (
tests/test_nightly_universal_build.sh: "the six-hour schedule must allow 90 minutes") and "Validate the nightly cmux-tui resolver" (tests/test_nightly_cmux_tui_resolve.py: "a resolver that never waits needs no 55-minute timeout").All four tests now check the limit with one-mini mode off. That is the smaller of the two numbers, the same reading
tests/test_nightly_sign_runner.pygot in 132f7ce. No workflow, gate or CI step changes."Validate nightly push throttle" has a separate red: #36234 added
cloud-journey-pr.yml:journey, a cold cargo build, without a.github/warm-sources.jsonrow, sotest_every_compile_job_names_its_warm_sourcesfails on feat-cmux-next. This PR adds the row, marked cold likebackend.yml:journey-staging.Testing
python3 tests/test_gh_budget_wait.py: at base 68927f4, 3 errors (test_publish_path_timeouts_leave_room_for_the_wait, test_the_app_engine_fetch_keeps_its_budget_wrapper, test_the_attestation_reserves_budget_and_its_retry_shares_the_ledger). At this head, OK (27 tests).python3 tests/test_nightly_delivery_concurrency.py: at base, ValueError on"${{ vars.CI_NIGHTLY_MINI != '' && 300 || 180 }}". At this head, PASS.bash tests/test_nightly_universal_build.shandpython3 tests/test_nightly_cmux_tui_resolve.py: FAIL at base with the messages above. PASS at this head.python3 tests/test_ci_warm_sources.pyafter merging feat-cmux-next: OK with the new row.Observed / Not run
Observed: the commands above, run on this branch and at base 68927f4.
Not run: the other release-notary steps; CI runs them.
Changelog
none
Agent session: agent session
🤖 Generated with Claude Code