Skip to content

test(nightly): read the one-mini timeout expressions with the mode off (release-notary base red) - #36249

Merged
teamleaderleo merged 4 commits into
feat-cmux-nextfrom
goal-n30-notary-red2
Nov 5, 2026
Merged

teamleaderleo merged 4 commits into
feat-cmux-nextfrom
goal-n30-notary-red2

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fixes a base red in release-notary. Since 132f7ce ("one-mini jobs get 120 more minutes for glaeda's capacity wait"), nightly.yml's timeout-minutes values are expressions like ${{ vars.CI_NIGHTLY_MINI != '' && 300 || 180 }}. tests/test_gh_budget_wait.py and tests/test_nightly_delivery_concurrency.py still call int() on them, so on every PR (#34670, #36065, #36079, #36212, #36233) these steps fail with a ValueError:

  • Validate nightly builds and signers never cancel or replace a waiting run
  • Validate nightly publish-path gh calls wait through a rate limit

The same expressions also break two more release-notary steps: "Validate universal nightly workflow" (tests/test_nightly_universal_build.sh: "the six-hour schedule must allow 90 minutes") and "Validate the nightly cmux-tui resolver" (tests/test_nightly_cmux_tui_resolve.py: "a resolver that never waits needs no 55-minute timeout").

All four tests now check the limit with one-mini mode off. That is the smaller of the two numbers, the same reading tests/test_nightly_sign_runner.py got in 132f7ce. No workflow, gate or CI step changes.

"Validate nightly push throttle" has a separate red: #36234 added cloud-journey-pr.yml:journey, a cold cargo build, without a .github/warm-sources.json row, so test_every_compile_job_names_its_warm_sources fails on feat-cmux-next. This PR adds the row, marked cold like backend.yml:journey-staging.

Testing

  • python3 tests/test_gh_budget_wait.py: at base 68927f4, 3 errors (test_publish_path_timeouts_leave_room_for_the_wait, test_the_app_engine_fetch_keeps_its_budget_wrapper, test_the_attestation_reserves_budget_and_its_retry_shares_the_ledger). At this head, OK (27 tests).
  • python3 tests/test_nightly_delivery_concurrency.py: at base, ValueError on "${{ vars.CI_NIGHTLY_MINI != '' && 300 || 180 }}". At this head, PASS.
  • bash tests/test_nightly_universal_build.sh and python3 tests/test_nightly_cmux_tui_resolve.py: FAIL at base with the messages above. PASS at this head.
  • python3 tests/test_ci_warm_sources.py after merging feat-cmux-next: OK with the new row.
  • Every command of "Validate nightly push throttle" (promotion admission, promotion queue, push throttle, off-Blacksmith, no hosted Mac, runs-on fallback, warm sources, checkout lean, helper prebuild, killpg) exits 0 at this head.

Observed / Not run

Observed: the commands above, run on this branch and at base 68927f4.
Not run: the other release-notary steps; CI runs them.

Changelog

none

Agent session: agent session

🤖 Generated with Claude Code

132f7ce made nightly.yml's timeout-minutes `${{ vars.CI_NIGHTLY_MINI != '' && X || Y }}`
expressions; test_gh_budget_wait.py and test_nightly_delivery_concurrency.py still int() them,
so release-notary's "publish-path gh calls wait through a rate limit" and "builds and signers
never cancel" steps fail with ValueError on every PR. Both now check the limit with one-mini
mode off, the smaller one, as test_nightly_sign_runner.py does.

Red at 68927f4: python3 tests/test_gh_budget_wait.py (3 errors), python3
tests/test_nightly_delivery_concurrency.py (ValueError). Green after.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-f08996319b14c7281027
@cursor

cursor Bot commented Nov 5, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 8273881: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr36249 -f ref=goal-n30-notary-red2 -f platform=macos -f backend_mode=local

Shipped in:

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@blacksmith-sh

blacksmith-sh Bot commented Nov 5, 2026

Copy link
Copy Markdown

Found 3 test failures on Blacksmith runners:

Failures

Test View Logs
nightly cmux-tui resolve/nightly cmux-tui resolve View Logs
test_every_compile_job_names_its_warm_sources (main.ThisTree.test_every_compile_job
_names_its_warm_sources)/
test_every_compile_job_names_its_warm_sources (main.ThisTree.test_every_compile_job
_names_its_warm_sources)
View Logs
the six-hour schedule must allow 90 minutes for a cold cache build and use the matching
runner, Xcode, and visible timing output/
the six-hour schedule must allow 90 minutes for a cold cache build and use the matching
runner, Xcode, and visible timing output
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex, router-review): SHIP at ebd0886

Reviewer: codex gpt-6-astra high, fast tier.

SHIP at ebd0886

Visual verdict: unchanged by this diff

Focused workflow tests and related timeout tests pass.

Follow-ups: none

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves ebd0886: an independent review passed this exact head (router-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

teamleaderleo and others added 3 commits November 5, 2026 07:02
…-mini expression too

132f7ce's expressions also broke tests/test_nightly_universal_build.sh ("the six-hour schedule
must allow 90 minutes") and tests/test_nightly_cmux_tui_resolve.py ("a resolver that never waits
needs no 55-minute timeout"): red on base, green here.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-f08996319b14c7281027
…6234)

test_ci_warm_sources.py's test_every_compile_job_names_its_warm_sources fails on feat-cmux-next
since #36234 added the job; it builds cmux-tui cold, like backend.yml:journey-staging.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-f08996319b14c7281027
@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Nov 5, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex, router-review): SHIP at 8273881

Reviewer: codex gpt-6-astra high, fast tier.

SHIP at 8273881

Visual verdict: unchanged by this diff

Focused timeout, delivery, resolver, universal-build, one-mini, and warm-source tests pass.

Follow-ups: none

@teamleaderleo
teamleaderleo merged commit c73be7f into feat-cmux-next Nov 5, 2026
173 of 174 checks passed
@teamleaderleo
teamleaderleo deleted the goal-n30-notary-red2 branch November 5, 2026 07:17

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 82738812 Deployed Nov 5, 2026 by teamleaderleo via wait for same-key tree publisher #114929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant