Repository navigation
webviews: the gallery dev server pre-bundles its stages' deps up front - #35985
Merged
Merged
Conversation
… deps Red at base: @base-ui/react/dialog was not in the first scan. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-cb8b9969051e7411b140
vite.config.gallery-dev.ts filters out the dev server's plugins, and with them the optimizeDeps entries the dev server's shell set. The gallery server's first scan then missed every dependency below a stage's entry (Base UI parts, TanStack Virtual and Query, pretext), so a stage that imported one re-optimized mid-run and renamed the shared chunks under the open pages: accent-glass-invariants-3 lost its browser and timed out (run 41942282745, 'The file does not exist at .../deps/with-selector-CmGIwqRk.js'). The gallery's pages and the Monaco exclude are now one export both configs use. test/gallery-dev-prebundles-deps.test.ts: red at base (@base-ui/react/dialog was not in the first scan), green here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-cb8b9969051e7411b140
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 5, 2026 01:21 — with
GitHub Actions
Inactive
Collaborator
Author
|
Fleet red/green (run 41947967236, tested 0a15880): |
Collaborator
Author
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The gallery dev server (
vite.config.gallery-dev.ts, which the webviews test runner uses for its seed-gallery servers) now scans its pages' dependencies up front, so it never re-optimizes mid-run.That config filters out the dev server's plugins, and with them the
optimizeDepsentries the dev server's shell set. Its first scan then found only the gallery shell's dependencies. A stage that imported another one (a Base UI part, TanStack Virtual or Query, pretext) triggered a re-optimize that renamed the shared chunks under the open pages. In run 41942282745 (#34983),accent-glass-invariants-3hitPre-transform error: The file does not exist at .../vite/seed-gallery-1/deps/with-selector-CmGIwqRk.js, thennewPage: Target page, context or browser has been closed, and timed out at 450 s.The gallery's pages and the Monaco exclude are now one export,
galleryOptimizeDepsindev-server/plugins.ts, which both configs use.Takes back #35312: not in effect. It added
src/gallery/mock-app.htmlto the dev server's scan entries; that line moves into the sharedgalleryOptimizeDeps.entries, which the dev server still spreads into its list, so both servers now scan the mock app.Test
bun test test/gallery-dev-prebundles-deps.test.ts(fromwebviews/) starts the gallery server on a freshCMUX_VITE_CACHE_DIR, as the runner's warming file does, waits for the first scan, and checks that it contains dependencies only the stages import.@base-ui/react/dialog was not in the first scan.Observed / Not run
tsc --noEmitand oxlint on the changed files.test/react-compiler-skips-optimized-deps.test.tsfails on this host at base and at head alike: its probe in a temp folder can't resolvevite. That's unrelated to this change.Changelog
none
Agent session: agent session
🤖 Generated with Claude Code