Skip to content

base red: rustfmt the 4 cmux-tui files left unformatted on feat-cmux-next - #35845

Merged
lawrencecchen merged 1 commit into
feat-cmux-nextfrom
fix/base-red-rustfmt-1940
Nov 4, 2026
Merged

lawrencecchen merged 1 commit into
feat-cmux-nextfrom
fix/base-red-rustfmt-1940

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Base red: scripts/ci/cmux-tui-rust-check.sh fmt is red on feat-cmux-next 78fcd7c8257 (fleet step 95f2e1ad65b5194a3429b675). Nine rustfmt diffs are in four files from #34604, #35799 and #35341:

  • cmux-tui/crates/cmux-tui/src/link/sync_cli.rs (2)
  • cmux-tui/crates/cmux-tui/src/link/sync_cli/store.rs (4)
  • cmux-tui/crates/cmux-tui-core/src/lib.rs (2)
  • cmux-tui/crates/cmux-tui-core/src/apps/grants.rs (1)

Every PR whose Rust check runs fmt inherits this red. For example, the S3a durability steps e3538ce6 and a0d75c74 failed only on these files.

This PR changes formatting only. It uses rustfmt 1.95.0 (the pinned toolchain) with cmux-tui/rustfmt.toml and edition 2024. The diff touches exactly the nine places that the step reported.

Observed / Not run

  • Observed: fmt red on the base, step 95f2e1ad65b5194a3429b675. Fleet fmt step on this head: see the first comment.
  • Not run: clippy and tests. The change is whitespace and line breaks only.

Changelog

none


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the base-red rustfmt failures in four cmux-tui files so the fleet format check passes on feat-cmux-next.

The fmt step was red on feat-cmux-next, failing every PR whose Rust check runs it. This PR applies rustfmt 1.95.0 with cmux-tui/rustfmt.toml and edition 2024 to the nine diffs in link/sync_cli.rs, link/sync_cli/store.rs, cmux-tui-core's lib.rs, and apps/grants.rs. Changes are whitespace and line breaks only; clippy and tests were not run.

Written for commit 13d3035. Summary will update on new commits.

View guided diff Turn on auto-fix

…5799 and #35341

cmux-tui-rust-check.sh fmt is red on feat-cmux-next 78fcd7c (fleet step
95f2e1ad65b5194a3429b675): 9 diffs in link/sync_cli.rs, link/sync_cli/store.rs,
cmux-tui-core lib.rs and apps/grants.rs. Every PR whose Rust check runs fmt
inherits it (S3a e3538ce6 and a0d75c74 failed only on these files).
Formatting only: rustfmt 1.95.0 with cmux-tui/rustfmt.toml, edition 2024.
@lawrencecchen lawrencecchen added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 13d3035: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr35845 -f ref=fix/base-red-rustfmt-1940 -f platform=macos -f backend_mode=local

Shipped in:

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Fleet fmt step on head 13d3035: 6e349f762d2c56da25d24876 green. The same step on the base 78fcd7c: 95f2e1ad65b5194a3429b675 red (9 diffs, these 4 files).

@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Nov 4, 2026
@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Review (independent subagent): SHIP at 13d3035

  • Scope: the diff (parent 78fcd7c = merge-base with feat-cmux-next, one commit) touches only the 4 named files: link/sync_cli.rs, link/sync_cli/store.rs, cmux-tui-core/src/lib.rs, cmux-tui-core/src/apps/grants.rs.
  • Tokens: I removed all whitespace from base and head and compared them character by character. grants.rs is identical. Only 2 non-whitespace edits exist, and both are rustfmt normalizations with no change in meaning: a trailing comma in the now-vertical send_through_store(...) argument list (sync_cli.rs), and one match arm Err(fenced) => { Unsettled(..).into() } that became Err(fenced) => Unsettled(..).into(), (store.rs). No identifier, literal, operator, attribute, use, mod or comment text changed.
  • lib.rs: the base and head lines are the same multiset. The only move is #[cfg(unix)] pub mod blob_fetch;, with its attribute still attached, to the front of the module group that is sorted by name after use cmux_tui_util::debug_spans;. git_seed keeps its own #[cfg(unix)]. No item was added or removed.
  • CI evidence: base step 95f2e1ad65b5194a3429b675 (ref 78fcd7c, cargo fmt --all --check) failed with exit 1, and its 9 Diff in hunks are the 9 hunks of this PR (store.rs 140/163/450/492, sync_cli.rs 837/939, grants.rs 346, lib.rs 34/41). Head step 6e349f762d2c56da25d24876 (ref 13d3035) shows fmt pass with exit 0.

Not run: no local compile or test, by policy. A formatting-only change needs no regression test.

@lawrencecchen lawrencecchen added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Nov 4, 2026
@lawrencecchen
lawrencecchen merged commit 7dd3f2e into feat-cmux-next Nov 4, 2026
268 of 286 checks passed
@lawrencecchen
lawrencecchen deleted the fix/base-red-rustfmt-1940 branch November 4, 2026 19:57
lawrencecchen added a commit that referenced this pull request Nov 4, 2026

This branch was previously deployed

3 inactive deployments
ci-routing-agent — 13d30357 Deployed Nov 4, 2026 by github-actions[bot] via cmux-next macOS placement #70819
artifacts — 13d30357 Deployed Nov 4, 2026 by lawrencecchen via publish tree-addressed cmux-tui #112889
sentry-dsyms — 13d30357 Deployed Nov 4, 2026 by lawrencecchen via upload cmux-tui dSYMs to Sentry #112889
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant