Repository navigation
base red: rustfmt the 4 cmux-tui files left unformatted on feat-cmux-next - #35845
Merged
Merged
Conversation
…5799 and #35341 cmux-tui-rust-check.sh fmt is red on feat-cmux-next 78fcd7c (fleet step 95f2e1ad65b5194a3429b675): 9 diffs in link/sync_cli.rs, link/sync_cli/store.rs, cmux-tui-core lib.rs and apps/grants.rs. Every PR whose Rust check runs fmt inherits it (S3a e3538ce6 and a0d75c74 failed only on these files). Formatting only: rustfmt 1.95.0 with cmux-tui/rustfmt.toml, edition 2024.
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
Contributor
Author
Contributor
Author
|
Review (independent subagent): SHIP at 13d3035
Not run: no local compile or test, by policy. A formatting-only change needs no regression test. |
lawrencecchen
temporarily deployed
to
artifacts
November 4, 2026 19:50 — with
GitHub Actions
Inactive
lawrencecchen
temporarily deployed
to
sentry-dsyms
November 4, 2026 19:50 — with
GitHub Actions
Inactive
lawrencecchen
temporarily deployed
to
artifacts
November 4, 2026 19:54 — with
GitHub Actions
Inactive
lawrencecchen
added a commit
that referenced
this pull request
Nov 4, 2026
lawrencecchen
added a commit
that referenced
this pull request
Nov 4, 2026
This was referenced Nov 4, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Base red:
scripts/ci/cmux-tui-rust-check.sh fmtis red on feat-cmux-next78fcd7c8257(fleet step95f2e1ad65b5194a3429b675). Nine rustfmt diffs are in four files from #34604, #35799 and #35341:cmux-tui/crates/cmux-tui/src/link/sync_cli.rs(2)cmux-tui/crates/cmux-tui/src/link/sync_cli/store.rs(4)cmux-tui/crates/cmux-tui-core/src/lib.rs(2)cmux-tui/crates/cmux-tui-core/src/apps/grants.rs(1)Every PR whose Rust check runs
fmtinherits this red. For example, the S3a durability stepse3538ce6anda0d75c74failed only on these files.This PR changes formatting only. It uses rustfmt 1.95.0 (the pinned toolchain) with
cmux-tui/rustfmt.tomland edition 2024. The diff touches exactly the nine places that the step reported.Observed / Not run
95f2e1ad65b5194a3429b675. Fleet fmt step on this head: see the first comment.Changelog
none
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the base-red rustfmt failures in four
cmux-tuifiles so the fleet format check passes onfeat-cmux-next.The
fmtstep was red onfeat-cmux-next, failing every PR whose Rust check runs it. This PR applies rustfmt 1.95.0 withcmux-tui/rustfmt.tomland edition 2024 to the nine diffs inlink/sync_cli.rs,link/sync_cli/store.rs,cmux-tui-core'slib.rs, andapps/grants.rs. Changes are whitespace and line breaks only; clippy and tests were not run.Written for commit 13d3035. Summary will update on new commits.