Repository navigation
ci(nightly): republished nightly-next builds follow their source's CEF pack and source archive; report a failed fetch - #35735
Merged
Conversation
…F pack and source archive; report a failed fetch Follow-ups F1-F3 from the review of #35588 at b1d50f5: - F1: publish-nightly publishes the Chromium runtime pack when the selected build has one. A republished build follows its source run (republish-nightly-next's cef), so a switch flipped since then neither drops a pack the app's pin names nor fails on one the source never made. - F2: a republished build whose source made no cmux-next source tarball publishes none (republish-verified-nightly.py's source_archive; the artifact always carries the license trees), instead of failing at `mv nightly-out/source-archive` after the feed was written. CMUX_NEXT_PUBLISH_SOURCE_ARCHIVE stays the switch. - F3: republish-nightly-next is in report-nightly-failure's needs, so a failed fetch opens the nightly failure issue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-03add12a0ffdd7814ff4
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 4, 2026 17:42 — with
GitHub Actions
Inactive
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
Collaborator
Author
|
Found 2 test failures on Blacksmith runners: Failures
|
teamleaderleo
commented
Nov 4, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Follow-ups F1 to F3 from the review of #35588 (receipt at b1d50f5), which added the republish path for a verified nightly-next build. This is item 2 of cmuxterm-hq#7061, "Republish with tip tooling".
F1, Chromium runtime pack.
publish-nightly's "Select the build to publish" step now outputscef, and both CEF steps gate on it instead of onvars.CMUX_NEXT_CEF_ON_DEMAND. Own and notarization-recovered builds still follow the switch. A republished build follows its source run:republish-nightly-nextoutputscef, which is true when the source's signer uploadedcef-runtime-pack, the same condition under which the app was signed with an on-demand pin. Flipping the switch after the build therefore neither drops a pack the app needs nor fails on a pack the source never made.F2, source archive. The
cmux-next-source-archiveartifact always carries the license trees. The tarball is in it only whileCMUX_NEXT_PUBLISH_SOURCE_ARCHIVEwas 1.republish-verified-nightly.pynow outputssource_archive, true when exactly onecmux-next-source-*.tar.gzwas restored.publish-nightlyoutputssource_archive: the switch, and for a republished build also that tarball. All three source-archive steps inpublish-nightly-next-githubgate on it. A republish of a source with no tarball now publishes no archive, instead of failing atmv nightly-out/source-archiveafter the feed was written. The variable stays the switch, and own and recovered builds behave as before.F3, failure reporting.
republish-nightly-nextis now inreport-nightly-failure'sneeds, so a failed fetch, which leavespublish-nightlyskipped, opens the nightly failure issue. Itsifalready reports any failed need.Tests
tests/test_nightly_next_recovery.py: 78 pass, 4 of them new (pack and archive per switch and source, the tarball check, and a failed fetch reporting).tests/test_nightly*.py,tests/test_ci_nightly*.pyandtests/test_nightly_universal_build.shpasses, excepttest_nightly_next_arm64_only.pyandtest_nightly_owned_minis_only.py. Those two (OwnedWorkdirSteps) also fail at base 3e464b0.Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Makes republished nightly-next builds match the build they republish: they now carry the same Chromium runtime pack and source archive, and a failed republish fetch opens the nightly failure issue.
CMUX_NEXT_CEF_ON_DEMANDswitch.CMUX_NEXT_PUBLISH_SOURCE_ARCHIVEswitch still gates own and recovered builds.republish-nightly-nextis now a dependency ofreport-nightly-failure, so failed fetches produce the nightly failure issue.Written for commit 104765a. Summary will update on new commits.