Skip to content

transcript-cohesion: give the file a 480 s limit (it takes about 240 s; shard 1 timed out) - #35516

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/transcript-cohesion-claude-fold
Nov 4, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/transcript-cohesion-claude-fold

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

What

Base red: test/transcript-cohesion.test.ts fails or times out on feat-cmux-next, and it takes webviews shard 1 past its 30-minute limit. That blocks every PR whose shard 1 runs it, #35312 among them.

Testing

On a fleet worker with the CI runner (bun run test test/transcript-cohesion.test.ts, no retries):

  • before: 46 pass and 2 fail (claude keeps the activity rhythm, light and dark) in 235 s, which is a TIMEOUT at the 120 s limit;
  • after: PASS, 48 of 48, in 237 s.

Observed / Not run

  • Observed: the run above.
  • Not run: the full webviews suite.

Changelog

none

🤖 Generated with Claude Code

Agent session: agent session


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Adds the cmux-web-test-timeout: 480 file limit to transcript-cohesion, whose 48 browser cases take about 240 s and kept timing out at the runner's 120 s default, taking webviews shard 1 along with it. The merge from feat-cmux-next also brings in #35410, which fixed the claude variant's assertion to expect the folded Worked for header introduced by #34774 and #35113.

Written for commit ee6a659. Summary will update on new commits.

View guided diff Turn on auto-fix

… for fold, and declares its 4-minute run

#34774 and #35113 fold a finished Claude turn under one Worked for, so the claude variant's
'no header' expectation no longer held. The file's 48 browser cases take about 240 s, past the
runner's 120 s default, so CI timed it out (and shard 1 with it).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-fb75b7af9902231028aa
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review ee6a659: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr35516 -f ref=lane/transcript-cohesion-claude-fold -f platform=macos -f backend_mode=local

Shipped in:

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent, correctness) at cf61d14: SHIP. The claude variant now draws one closed Worked for fold (turnFoldStyle conclusion: true from #35113), so the new assertions match. The timeout header is in the form the runner reads (first 20 lines). Follow-up: the gallery entry's notes still say Claude has no whole-turn fold.

Agent session: agent session

@blacksmith-sh

blacksmith-sh Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test_every_compile_job_names_its_warm_sources (main.ThisTree.test_every_compile_job
_names_its_warm_sources)/
test_every_compile_job_names_its_warm_sources (main.ThisTree.test_every_compile_job
_names_its_warm_sources)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

…its version, plus the 480 s file limit

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-fb75b7af9902231028aa
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

#35410 landed the same Claude assertion fix on the base, so this PR now merges the base, keeps that version of the test, and adds only the // cmux-web-test-timeout: 480 line. The file takes about 240 s against the 120 s default, which is the shard 1 timeout. The diff against the base is that one line; the earlier review covered it.

Agent session: agent session

@teamleaderleo teamleaderleo changed the title base red: transcript-cohesion expects Claude's Worked for fold and declares its 4-minute run transcript-cohesion: give the file a 480 s limit (it takes about 240 s; shard 1 timed out) Nov 4, 2026
@cursor

cursor Bot commented Nov 4, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent, correctness): SHIP at ee6a659. run-webviews-tests.sh's file_limit() reads the marker from the first 20 lines and applies max(480, 120), capped at 900. pane-english.ts still finds l10n-allow-file within the first 2000 characters, so the file stays exempt.

Agent session: agent session

@teamleaderleo
teamleaderleo merged commit f3bdee7 into feat-cmux-next Nov 4, 2026
185 of 195 checks passed
@teamleaderleo
teamleaderleo deleted the lane/transcript-cohesion-claude-fold branch November 4, 2026 16:35

This branch was previously deployed

1 inactive deployment
ci-routing-agent — ee6a659c Deployed Nov 4, 2026 by teamleaderleo via wait for same-key tree publisher #112277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant